https://sourceforge.net/p/asap/patches/2024-07-04T16:11:52.439000ZRecent changes to patches2024-07-04T16:11:52.439000Z2024-07-04T16:11:52.439000ZPiotr Fusikhttps://sourceforge.net/u/pfusik/https://sourceforge.netc47c082989af299329b8b181b7289a4f669cac2f

<div class="markdown_content"><ul> <li><strong>status</strong>: open --&gt; closed-out-of-date</li> <li><strong>assigned_to</strong>: Piotr Fusik</li> </ul></div>

2023-05-08T09:12:05.814000Z2023-05-08T09:12:05.814000ZDrei Eckhttps://sourceforge.net/u/dreieck/https://sourceforge.net50a8fe289f2ea689750f8a08a98439627820f4a9

<div class="markdown_content"><p>Ahoj,</p> <blockquote> <p>It doesn't stop from overriding the flags on the command<br/> line:</p> <div class="codehilite"><pre><span></span><code>`C:\0\a8\asap\git&gt;make CFLAGS=-g V=1 asapconv` </code></pre></div> </blockquote> <p>Ah, OK, I was not aware of that!</p> <blockquote> <p>Why is <code>+=</code> superior? I understand it enables environment variables,<br/> but <em>why</em> would we want to set flags via an environment variable and<br/> not the <code>make</code> command line? </p> </blockquote> <p>In your use case, you can still specify specific CFLAGS that are needed<br/> to build the project correctly (I suppose mainly when you forcefully<br/> need to switch off some optimisations).</p> <p>In the use case I am referring to, it is helpful with Arch Linux<br/> packaging:</p> <p>There you can define in a global configuration file standard CFLAGS,<br/> which get passed to the build scripts via environment variable.</p> <p>This way, they are automatically honoured if the software's build<br/> system honours the envoronment variable.</p> <p>OK, if this patch is not applied, I can add in the package manually the<br/> inclusion of <code>$CFLAGS</code>, or just keep the patch around.</p> <p>Regards!</p></div>

2023-05-07T19:13:06.263000Z2023-05-07T19:13:06.263000ZPiotr Fusikhttps://sourceforge.net/u/pfusik/https://sourceforge.net7a67314df8890304e147b45cc81ecaf42d4d5878

<div class="markdown_content"><ul> <li><strong>assigned_to</strong>: Piotr Fusik</li> </ul></div>

2023-05-06T12:27:26.784000Z2023-05-06T12:27:26.784000ZDrei Eckhttps://sourceforge.net/u/dreieck/https://sourceforge.neta022987aee138030c80f465bdc7d5bb9492bc202

<div class="markdown_content"><p>(Use even <code>-O3</code> and not <code>-O2</code> to achieve even more optimisation. Or not set this at all, so the user can influence this via <code>$CFLAGS</code>, e.g. can also set <code>-Og</code> for debug optimisation.)</p></div>

2023-05-06T12:26:14.985000Z2023-05-06T12:26:14.985000ZDrei Eckhttps://sourceforge.net/u/dreieck/https://sourceforge.net27fb5213cd23797163767fa74a984e43a6847cb4

<div class="markdown_content"><p>Current <code>Makefile</code> hard-sets <code>$CFLAGS</code> and <code>$LDFLAGS</code>.</p> <p>Feature request: Do not re-set the flags, but just append options.</p> <p>The following patch, which does this, is taken from <a class="" href="https://aur.archlinux.org/packages/asap" rel="nofollow">the <code>asap</code> Arch Linux package</a>:</p> <div class="codehilite"><pre><span></span><code><span class="gd">--- a/Makefile 2021-10-07 21:48:58.204086012 -0700</span> <span class="gi">+++ b/Makefile 2021-10-07 22:14:39.290565502 -0700</span> <span class="gu">@@ -3,9 +3,9 @@</span> <span class="w"> </span>bindir = $(prefix)/bin <span class="w"> </span>libdir = $(prefix)/lib <span class="w"> </span>CC = gcc <span class="gd">-CFLAGS = -O2 -Wall</span> <span class="gi">+CFLAGS += -O2 -Wall</span> <span class="w"> </span>CPPFLAGS = <span class="gd">-LDFLAGS = -s</span> <span class="gi">+LDFLAGS += -s</span> <span class="w"> </span>AR = ar <span class="w"> </span>ARFLAGS = rc <span class="w"> </span>DO_CC = $(DO)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ $(if $(filter %.so,$@),-shared -fPIC) $(INCLUDEOPTS) $(filter %.c,$^) $(LDFLAGS) </code></pre></div> </div>

2023-05-06T12:26:14.985000Z2023-05-06T12:26:14.985000ZDrei Eckhttps://sourceforge.net/u/dreieck/https://sourceforge.net38100e6add8777b00f214722d17d02a151b7dc55

<div class="markdown_content"><p>Ticket 6 has been modified: Honour pre-set CFLAGS and LDFLAGS.<br/> Edited By: Piotr Fusik (pfusik)<br/> Owner updated: None =&gt; 'pfusik'</p></div>

2015-04-07T10:57:19.963000Z2015-04-07T10:57:19.963000Zdash551https://sourceforge.net/u/dash551/https://sourceforge.net5c9eb28d1dcc07f5484075379271a15648209311

<div class="markdown_content"><p>This is a source RPM generated using that spec file.</p></div>

2015-04-07T10:56:28.311000Z2015-04-07T10:56:28.311000Zdash551https://sourceforge.net/u/dash551/https://sourceforge.net4b7ede1d7a9d59b73217d7f74c6cbe0b3e389894

<div class="markdown_content"><p>I have updated the asap.spec file to add support for Audacious plugin if somebody needs it.</p></div>

2015-04-07T10:56:28.311000Z2015-04-07T10:56:28.311000Zdash551https://sourceforge.net/u/dash551/https://sourceforge.net27415d9f648cbc56ab5ed7e58fdbd0e839bd23bd

<div class="markdown_content"><p>Ticket 5 has been modified: RPM Spec file for Audacious plugin<br/> Edited By: Piotr Fusik (pfusik)<br/> Status updated: 'open' =&gt; 'closed-out-of-date'<br/> Owner updated: None =&gt; 'pfusik'</p></div>

2014-09-13T17:49:23.477000Z2014-09-13T17:49:23.477000ZPiotr Fusikhttps://sourceforge.net/u/pfusik/https://sourceforge.net8f81a6ddefb8209e5ed425980e659ac1d8bd49e6

<div class="markdown_content"><ul> <li><strong>status</strong>: open --&gt; accepted</li> <li><strong>assigned_to</strong>: Piotr Fusik</li> </ul></div>