Recent changes to patches

#5 RPM Spec file for Audacious plugin

Piotr Fusik — Thu, 04 Jul 2024 16:11:52 -0000

status: open --> closed-out-of-date
assigned_to: Piotr Fusik

#6 Honour pre-set CFLAGS and LDFLAGS.

Drei Eck — Mon, 08 May 2023 09:12:05 -0000

Ahoj,

It doesn't stop from overriding the flags on the command
line:
`C:\0\a8\asap\git>make CFLAGS=-g V=1 asapconv`

Ah, OK, I was not aware of that!

Why is += superior? I understand it enables environment variables,
but why would we want to set flags via an environment variable and
not the make command line?

In your use case, you can still specify specific CFLAGS that are needed
to build the project correctly (I suppose mainly when you forcefully
need to switch off some optimisations).

In the use case I am referring to, it is helpful with Arch Linux
packaging:

There you can define in a global configuration file standard CFLAGS,
which get passed to the build scripts via environment variable.

This way, they are automatically honoured if the software's build
system honours the envoronment variable.

OK, if this patch is not applied, I can add in the package manually the
inclusion of $CFLAGS, or just keep the patch around.

Regards!

#6 Honour pre-set CFLAGS and LDFLAGS.

Piotr Fusik — Sun, 07 May 2023 19:13:06 -0000

assigned_to: Piotr Fusik

#6 Honour pre-set CFLAGS and LDFLAGS.

Drei Eck — Sat, 06 May 2023 12:27:26 -0000

(Use even -O3 and not -O2 to achieve even more optimisation. Or not set this at all, so the user can influence this via $CFLAGS, e.g. can also set -Og for debug optimisation.)

Honour pre-set CFLAGS and LDFLAGS.

Drei Eck — Sat, 06 May 2023 12:26:14 -0000

Current Makefile hard-sets $CFLAGS and $LDFLAGS.

Feature request: Do not re-set the flags, but just append options.

The following patch, which does this, is taken from the asap Arch Linux package:

--- a/Makefile  2021-10-07 21:48:58.204086012 -0700
+++ b/Makefile  2021-10-07 22:14:39.290565502 -0700
@@ -3,9 +3,9 @@
 bindir = $(prefix)/bin
 libdir = $(prefix)/lib
 CC = gcc
-CFLAGS = -O2 -Wall
+CFLAGS += -O2 -Wall
 CPPFLAGS =
-LDFLAGS = -s
+LDFLAGS += -s
 AR = ar
 ARFLAGS = rc
 DO_CC = $(DO)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ $(if $(filter %.so,$@),-shared -fPIC) $(INCLUDEOPTS) $(filter %.c,$^) $(LDFLAGS)

Honour pre-set CFLAGS and LDFLAGS.

Drei Eck — Sat, 06 May 2023 12:26:14 -0000

Ticket 6 has been modified: Honour pre-set CFLAGS and LDFLAGS.
Edited By: Piotr Fusik (pfusik)
Owner updated: None => 'pfusik'

#5 RPM Spec file for Audacious plugin

dash551 — Tue, 07 Apr 2015 10:57:19 -0000

This is a source RPM generated using that spec file.

RPM Spec file for Audacious plugin

dash551 — Tue, 07 Apr 2015 10:56:28 -0000

I have updated the asap.spec file to add support for Audacious plugin if somebody needs it.

RPM Spec file for Audacious plugin

dash551 — Tue, 07 Apr 2015 10:56:28 -0000

Ticket 5 has been modified: RPM Spec file for Audacious plugin
Edited By: Piotr Fusik (pfusik)
Status updated: 'open' => 'closed-out-of-date'
Owner updated: None => 'pfusik'

#4 Update to Audacious 3.5 plugin API

Piotr Fusik — Sat, 13 Sep 2014 17:49:23 -0000

status: open --> accepted
assigned_to: Piotr Fusik