Should I submit these changes for bashdb?

Jokerwild — Sun, 14 Jan 2024 08:24:25 -0000

Rocky, sure, I will have a look at zshdb on GitHub, as you suggest.

Should I submit these changes for bashdb?

Rocky Bernstein — Sat, 13 Jan 2024 09:33:35 -0000

@Jokerwild - I have created a github repository for this and copied all of the code there.

If you have a github account, please suggest changes as Pull Requests (PR's) there.

Here is a suggestion for something to do that is both needed and will get understanding the code better. Look at https://github.com/rocky/zshdb/ and the more recent changes there. See if these can be applied to bashdb.

When this project was started, there wasn't much in the way of linters for shell code. In the past I have used ksh -n which offers some checks. Nowadays there is "ShellCheck" .

Should I submit these changes for bashdb?

Jokerwild — Sat, 13 Jan 2024 02:20:07 -0000

My understanding of Bash is rather rudimentary, but I would like to help. If I can assist in any simple way to start with, please let me know.

Should I submit these changes for bashdb?

Rocky Bernstein — Fri, 05 Jan 2024 12:05:28 -0000

Starting next week my time will finally free up. for open-source things. The top priority will be whatever is needed for bashdb and zshdb.

Should I submit these changes for bashdb?

Joachim Ansorg — Fri, 05 Jan 2024 11:28:35 -0000

@rockyb Thanks!
I've submitted most of the commits as merge requests. There's one against 4.4 and one against 5.1 where applicable.
I've kept most PRs to just one commit to help with the review.

Should I submit these changes for bashdb?

Rocky Bernstein — Sat, 16 Dec 2023 22:22:07 -0000

Yes, please submit these, to the extend we can I would prefer the code bases to as close as possible.

As for the changes due pygments changing things from time to type, my view is that this is fragility in testing . Testing should be done without pygmentizing output.

There should be tests just to see that pygments does something, but that test needs to be crafted more careful so that it does not rely too heavily on specific kinds of formatting that is likely to change. For example it might detect that listings vary the output, and maybe even check that keywords have tagging. around them.

I am going to be busy until Jan 9th or so. After that I will probably have a lot more time to devote to open-source kinds of things.

Should I submit these changes for bashdb?

Joachim Ansorg — Thu, 14 Dec 2023 10:18:22 -0000

I've cleaned my commits and made sure that all tests are passing.
I had to repair a few, the commits should contain the details. Some failures were related to a new version of pygmentize. I wasn't sure which version is expected to run the tests.

Commits to bash-5.1, which may be useful:
- https://github.com/BashSupport-Pro/bashdb/commit/89f60e890ad7dbc904e61cd8861f74a643162958
- https://github.com/BashSupport-Pro/bashdb/commit/d83d7dc913fc66521926cfb3a689c3b9f6708f0a
- https://github.com/BashSupport-Pro/bashdb/commit/2d25b38290d317161efeb5c080e02184d3f5959d
- https://github.com/BashSupport-Pro/bashdb/commit/49d6c4379be1c5fd4d4e9089e718575b5d96380a
- https://github.com/BashSupport-Pro/bashdb/commit/084d95d5447182151efc51cf324015b1ce5b4d7e
- https://github.com/BashSupport-Pro/bashdb/commit/1eea0c01bbdaba0585deecfc9c61fe11640f9175

Commits to bash-4.4, mostly the same as above:
- https://github.com/BashSupport-Pro/bashdb/commit/1cf584c9cdb7255c411572e953beb9b615687045
- https://github.com/BashSupport-Pro/bashdb/commit/4e76fda17466bae06cd7bef028645b199d95b028
- https://github.com/BashSupport-Pro/bashdb/commit/b74a8f09725754e1264aa732692b75e2bb7d42b2
- https://github.com/BashSupport-Pro/bashdb/commit/a9ef0772dbe2c761cf5e8614ceb82ab19f0cf0af
- https://github.com/BashSupport-Pro/bashdb/commit/6b0837c1ccf866b7f6c904f51559127cb5692f5d

Should I submit these changes for bashdb?

Rocky Bernstein — Wed, 13 Dec 2023 19:03:39 -0000

Thanks - I will look at the changes this weekend to let you know.

Should I submit these changes for bashdb?

Joachim Ansorg — Wed, 13 Dec 2023 18:57:11 -0000

For BashSupport Pro, I have made a few changes to my fork of bashdb which were not yet submitted.
https://github.com/BashSupport-Pro/bashdb/commits/bashsupport-5.1 for the 5.1 branch and https://github.com/BashSupport-Pro/bashdb/commits/bashsupport-4.4 for the 4.4 branch.

Commits like https://github.com/BashSupport-Pro/bashdb/commit/389ad7668318ed6866d4fde32b820c1e321302dc are most likely only useful for the use in BashSupport.

For example, there's https://github.com/BashSupport-Pro/bashdb/commit/f0bda0c2d67515444c2dcda18f7228f000c53d75, which makes "info variables" faster (should be O(1) instead of O(n) now, I think) and keeps bash's escapes im the output to support linefeeds and spaces in the output.

Because SF.net is so awkward, I wanted to make sure if these patches would be accepted before I submit them.
If it's likely that they'd be merged, I'd clean it up and submit them with tests.

Thanks!

bashdb on bash 5.1

Rocky Bernstein — Sat, 19 Aug 2023 19:44:11 -0000

Actually, I just tried from branch 5.1 and I do not see "This package is only known to work with Bash 5.0". line 106 of configure.ac looks like 5.1 was allowed since 2020-07-29 in commit 6daffb5c.

I have just adjusted the error message which reported that only 5.0 was allowed.

As for the failures. I do still see two of them,. test-bash-rematch however is not in there, but another one test-bug-loc. Again though these can be ignored.

Recent posts to Discussion

Should I submit these changes for bashdb?

Should I submit these changes for bashdb?

Should I submit these changes for bashdb?

Should I submit these changes for bashdb?

Should I submit these changes for bashdb?

Should I submit these changes for bashdb?

Should I submit these changes for bashdb?

Should I submit these changes for bashdb?

Should I submit these changes for bashdb?

bashdb on bash 5.1