Thread: [Beepcore-java-users] The semantics of close()

I've been thinking about how session.close() works and I'm not really
comfortable with it. If I call close() on a session that is already
closing I get an illegal state exception from it, yet I have no way of
finding out if a session is in the process of closing or is already
closed.

This makes it difficult to write code that cleans up when it is through
with a session.

On Wed, 2003-06-04 at 10:03, Paul Andrews wrote:
> I've been thinking about how session.close() works and I'm not really
> comfortable with it. If I call close() on a session that is already
> closing I get an illegal state exception from it, yet I have no way of
> finding out if a session is in the process of closing or is already
> closed.
> 
> This makes it difficult to write code that cleans up when it is through
> with a session.

This is a very good point. Would it be ok with you if close() did
nothing if the state of the session was CLOSING or CLOSED?

--Huston

Yes, that would be perfect. I was thinking that it might also be worth
adding a method to query the state, though that would obviously present
a race condition, I don't think it would matter if close() was modified
like you propose.

> -----Original Message-----
> From: Huston [mailto:hu...@us...] 
> Sent: Wednesday, June 04, 2003 1:14 PM
> To: Paul Andrews
> Cc: Bee...@li...
> Subject: Re: [Beepcore-java-users] The semantics of close()
> 
> 
> On Wed, 2003-06-04 at 10:03, Paul Andrews wrote:
> > I've been thinking about how session.close() works and I'm 
> not really
> > comfortable with it. If I call close() on a session that is already
> > closing I get an illegal state exception from it, yet I 
> have no way of
> > finding out if a session is in the process of closing or is already
> > closed.
> > 
> > This makes it difficult to write code that cleans up when 
> it is through
> > with a session.
> 
> This is a very good point. Would it be ok with you if close() did
> nothing if the state of the session was CLOSING or CLOSED?
> 
> --Huston
>