Recent changes to patches

#41 Compliling fails using GCC-15

Sergei Golovan — Thu, 02 Apr 2026 10:08:52 -0000

Hi!

In newer GCC another issue emerges: there are two variables named true and false, which is not acceptable as for now. I've modified the patch and renamed them into truev and falsev.

#46 Blt_TclInit() and Blt_TkInit() are declared only if USE_BLT_STUBS is defined

Sergei Golovan — Thu, 03 Jul 2025 15:54:13 -0000

Hi!

My patch seems to be incomplete. The way it is, including blt.h withou prior tcl.h leads to compile errors because Tcl_AppInitProc is undefined. This will break configure scripts which try to find blt.h by compiling simple files with #include <blt.h> in them. Here is one possible fix - included tcl.h inside blt.h.</blt.h>

A few fixes and changes in blt::vector

Sergei Golovan — Mon, 30 Jun 2025 16:25:06 -0000

Hi!

1) It looks like two vector operations have bugs in BLT 3:
* skew(x) is defined incorrectly as a normalized mean of the absolute value of x^3, there shouldn't be an absolute value (Ex^3/s^3, not E|x|^3/s^3). This bug is present in BLT 2 as well.
* q2(x) is defined as mean(x), but should be median(x). There's no q2() in BLT 2.
2) Looking into tests/vector.tcl, I've found the following failing test [blt::vector create z_values(50)]. Since specifying vector length as (50) or first/last indices as (1:50) was the intended way of creating preallocated vectors in BLT 2, I've tried to reimplement it for BLT 3 as well. Also, I've added options -first and -last (they were listed in the comments in bltVectors.c, so I assume that it's the new way to specify the range of indices).

Please, consider the attached patch with the following changes:
1) src/bltVecMath.c: fixes bugs with skew() and q2().
2) src/bltVectors.c: adds -first and -last options for vector creation. Also, changes the type of -length to BLT_SWITCH_INT_POS because the size have type int (so BLT_SWITCH_LONG_POS overwrites switches.first).
3) src/bltVectors.c: Moves parsing name(12) and name(1:10) to a separate function, which is called both from VectorCreateOp() and OldVectorCreate().
4) src/bltVectors.c: changes size = last - first to size = last - first + 1 on vector creation. Probably, you wanted ranges like 1:3 mean 1 2, but this would require the respective changes in other places where ranges are acceptable (like ::vector value set 1:3 1 which currently sets values for 3 elements, and not for 2. Clearly, this change can be discussed further.
5) src/bltVectors.c: implements defining vector size and offset in [blt::vector create] by both (23:42) and -first 23 -last 42'. 6) src/bltVectors.c: implementsv(:)as a synonym tov(all). It didn't work as it was before for the case of an empty vector. 7) tests/vector.tcl: fixes all the existing tests and adds a few tests for[blt::vector create]`.

Blt_TclInit() and Blt_TkInit() are declared only if USE_BLT_STUBS is defined

Sergei Golovan — Mon, 30 Jun 2025 15:58:23 -0000

Hi!

Appears that Blt_TclInit() and Blt_TkInit() are declared in blt.h only if USE_BLT_STUBS is defined. As far as I understand, they should be called even if BLT stubs aren't in use (but say, Tcl/Tk stubs are used by BLT).

Please, consider the attached patch, which moves #endif higher and declares these init functions unconditionally.

tabset uses wrong padding for windows in its tabs

Sergei Golovan — Tue, 17 Jun 2025 14:03:59 -0000

Hi!

There's a bug in BLT 3 tabset widget: it doubles left and top paddings when drawing windows inside tabs. The attached demo (taken from the Python's PMW library and rewritten in Tcl) shows this in the Helpers panel (there is a lone button with huge paddings, it should be centered in the tab, but it's shifted down and to the right). Appears that subtracting the paddings from the cavity width and height is missing in bltTabset.c (it is there in version 2). The attached patch re-adds the code.

tabset closes tab when it loses its window

Sergei Golovan — Tue, 17 Jun 2025 13:58:02 -0000

Hi!

BLT 3 has a change with respect to BLT 2, which I'd call a bug: When a tab in a tabset widget loses its window (in the attached example it is stealed by another tab) it deletes the tab itself. In BLT 2 the tab stays empty. The attached example is taken from Python's library PMW and is rewritten to Tcl. Here two tabs (Appearance and Images) steal a window (label .tabset.ap) from each other on tab selection. I think that not deleting the tab is more reasonable behavior, hence the attached patch (taken from the corresponding part of bltTabset.c of version 2).

Typos in bltParseargs.c

Sergei Golovan — Mon, 09 Jun 2025 07:01:10 -0000

Hi!

There are two typos in bltParseargc.c which make $args set and $args restore treat the argument names as agument values. The attached patch fixes that (and parseargs demo starts working after that.

Fix segfault in the htext widget

Sergei Golovan — Thu, 05 Jun 2025 09:55:27 -0000

Hi!

Currently, in BLT 3.0 from Got's HEAD, htext segfaults when I'm trying to select the text inside it. Looks like a typo in its config specs for the selection background (uses BLT_CONFIG_BORDER type instead of BLT_CONFIG_BACKGROUND). The attached patch fixes the segfault.

#39 Missing declarations and symbols when linking with stubs enabled

Sergei Golovan — Wed, 04 Jun 2025 18:47:20 -0000

I'm sorry, the second patch is incomplete. It misses adding the two functions to the bltTkProcs structure. Here is the corrected patch.

Compliling fails using GCC-15

Sergei Golovan — Fri, 30 May 2025 14:03:20 -0000

Hi!

GCC 15 adds the new bool type, which makes BLT failing to build because it has some variables named bool in the sources. Also, gcc 15 complains about incorrect prototype in one case. The attached patch defines the "bool" macro to make BLT compilable, but maybe it's not the baest way of fixing the bug. I think it'd be better to rename the variables. The secont part of the patch fixes a function prototype.