Recent changes to patches

#2 Add additional information to Makefile

2018-04-05T07:18:41.234000Z

status: accepted --> closed

#2 Add additional information to Makefile

2018-04-05T07:18:05.966000Z

status: open --> accepted
assigned_to: Stefan Evert

Add additional information to Makefile

2018-04-04T19:30:12.693000Z

Please add license information as well as a hint to your web site at sourceforge to the CWB module. I could make it easier to contribute.
The information is shown nicely on metacpan at the left side.
Cf. https://sourceforge.net/p/perl-trg/code/HEAD/tree/trunk/Makefile.PL for a nice example for a lot of additional Makefile information.

HTH

Add additional information to Makefile

2018-04-04T19:30:12.693000Z

Ticket 2 has been modified: Add additional information to Makefile
Edited By: Stefan Evert (schtepf)
Status updated: u'open' => u'accepted'
Owner updated: None => u'schtepf'

Add additional information to Makefile

2018-04-04T19:30:12.693000Z

Ticket 2 has been modified: Add additional information to Makefile
Edited By: Stefan Evert (schtepf)
Status updated: u'accepted' => u'closed'

#1 patches to PrintMode SGML

2016-07-20T11:45:00.936000Z

status: open --> wont-fix
Group: --> Unstable_(example)

#1 patches to PrintMode SGML

2016-07-20T11:44:49.498000Z

We're not going to change this in CWB 3.5 as it may break other programs that expect the traditional delimiters. Users who require different output formats can patch the source code and recompile CQP.

SGML, HTML and Latex output modes are deprecated and will no longer be supported in future releases (4.0 and later).

patches to PrintMode SGML

2010-09-15T08:57:56Z

There are two \(or three\) problems with SGML output which makes wrapping into another program difficult: 1\. The attribute separator is "/", which is a problem when the word or an attribute contains "/", e.g.: CORPUS> show +lemma; CORPUS> "1/2"; <CONCORDANCE> <attribute type=positional name="word" anr=0> <attribute type=positional name="lemma" anr=1> <LINE>\(...\)<CONTENT>\(...\) <MATCH><TOKEN>1/2/1/2</TOKEN></MATCH> \(...\)</CONTENT></LINE> \(...\) </CONCORDANCE> As you can see, it's impossible to extract the attributes from the SGML. My suggestion is to use "<ATTR>" as the attribute separator instead, which will work since "<" and ">" are SGML escaped. 2\. When using an aligned corpus, the SGML in the aligned text is escaped: CORPUS\_SWE> show +corpus\_nld -lemma; CORPUS\_SWE> "veranda"; <CONCORDANCE> <attribute type=positional name="word" anr=0> <LINE>\(...\)<CONTENT> \(...\) <MATCH><TOKEN>veranda</TOKEN></MATCH> \(...\)</CONTENT></LINE> <align name="saltnld\_nld"><CONTENT> \(...\) <TOKEN>veranda</TOKEN> \(...\) <TOKEN>.</TOKEN> </CONTENT> \(...\) </CONCORDANCE> My suggestion is of course that the aligned text should not be escaped. ALso, that an "</align>" be printed in the end. 3\. A smaller problem \(and not a bug at all\), is that the rows in the group output are contextual: CORPUS> X = "de" \[\]; CORPUS> group X matchend lemma by match pos cut 50; <TABLE> <TR><TD>DT<TD>\_\_UNDEF\_\_<TD>152</TR> <TR><TD>PN<TD>vara<TD>146</TR> <TR><TD> <TD>ha<TD>117</TR> <TR><TD> <TD>skola<TD>100</TR> <TR><TD> <TD>inte<TD>89</TR> <TR><TD> <TD>komma<TD>80</TR> <TR><TD>DT<TD>mången<TD>71</TR> <TR><TD> <TD>där<TD>61</TR> <TR><TD> <TD>andra,annan,två<TD>52</TR> </TABLE> The 3rd row 1st column contains " ", which is a way of saying "the same as above". This is okay for ascii output and HTML output, but SGML is designed for computer readability, so personally I think that it shouldn't refer to earlier rows. Similar to "PrettyPrint off", which only works for "PrintMode ascii"... My suggestion is that the group printer only prints   if PrettyPrint is on. 4\. I did some digging in the source code, and it was pretty easy to do the necessary changes. \(Kudos to the programmers for making the code readable\). Only 4 lines are affected, here's a diff: Index: sgml-print.c =================================================================== \--- sgml-print.c \(revision 182\) +++ sgml-print.c \(working copy\) @@ -77,7 +77,7 @@ "<TOKEN>", /\* BeforeToken \*/ " ", /\* TokenSeparator \*/ \- "/", /\* AttributeSeparator \*/ \+ "<ATTR>", /\* AttributeSeparator \*/ "</TOKEN>", /\* AfterToken \*/ "<CONTENT>", /\* BeforeField \*/ @@ -213,7 +213,8 @@ sgml\_puts\(stream, "<align name=\"", 0\); sgml\_puts\(stream, attribute\_name, 0\); sgml\_puts\(stream, "\">", 0\); \- sgml\_puts\(stream, line, SUBST\_ALL\); \+ sgml\_puts\(stream, line, 0\); \+ sgml\_puts\(stream, "</align>", 0\); fputc\('\n', stream\); \} @@ -431,7 +432,7 @@ source\_id = group->count\_cells\[cell\].s; \- if \(source\_id \!= last\_source\_id\) \{ \+ if \(\!pretty\_print || \(source\_id \!= last\_source\_id\)\) \{ last\_source\_id = source\_id; sgml\_puts\(fd, Group\_id2str\(group, source\_id, 0\), SUBST\_ALL\); nr\_targets = 0;

patches to PrintMode SGML

2010-09-15T08:57:56Z

Ticket 1 has been modified: patches to PrintMode SGML
Edited By: Stefan Evert (schtepf)
Status updated: u'open' => u'wont-fix'
milestone updated: '' => u'Unstable(example)'