Recent changes to patches

#218 Fix the bug #1187 (Chromium-based apps misbehave)

Matthias S. Benkmann — Tue, 26 Nov 2024 18:22:00 -0000

It's an unfortunate side effect of the coarse nature of the patch.The ideal implementation would be to grab exactly those Button+Modifier combinations that are necessary due to the configuration. In your case that would be Button1+Alt. Unfortunately the Fluxbox grabbing code isn't easy to understand, so I wasn't able to do the fine-grained solution.

For you personally, you can simply change the patch so that in the function ungrabClickToFocus() after the XUngrabButton()... you add a XGrabButton(display,Button1,Mod1Mask,frame().window().window(),True,ButtonPressMask,GrabModeSync,GrabModeSync,None,None)

That will re-grab Button1+Alt so your movement works while Chromium-apps will still keep working unless they use Button1+Alt.
You may have to add a second XGrabButton with Mod1Mask+Mod2Mask to cover the case where you have NumLock enabled.

#218 Fix the bug #1187 (Chromium-based apps misbehave)

crpb — Tue, 26 Nov 2024 17:40:17 -0000

Sadly it's buggy. I just happened to open krusader and hat focus in it, and then i couldn't use my Alt+Left-Mouse movement anymore, Did a quick rebuild w/o the patch ant it works again w/o a hitch.

Fix the bug #1187 (Chromium-based apps misbehave)

Matthias S. Benkmann — Tue, 26 Nov 2024 09:05:36 -0000

The fix is
inspired by FVWM3 which (like most/all other WMs) doesn't suffer from this
issue despite having a ClickToFocus option.

FVWM3

1) only grabs windows when necessary, so if someone doesn't use click-to-focus,
he's completely unaffected by the issue
2) releases the grab when a window gains focus

I was unable to implement 1) in Fluxbox because I could not figure out when and where all
the grabbing and ungrabbing happens. However implementing 2) was pretty easy.

#173 Window move/resize enhancement

Thomas Luebking — Wed, 24 Feb 2021 15:22:06 -0000

I think the "has to grab the whole xserver" part is a misinterpretation, he did that for the outline version to prevent artifacts.
About the server load, I'll push a patch to github and make a pull request (no refactoring, only opaque resize - the strategy is to limit the resizes/second with a timer which works nicely even for very slow clients that would create a huge backlog on continuous resizes)

#215 Updated Translation.m for da_DK

scootergrisen — Fri, 16 Mar 2018 20:28:45 -0000

I think you might have written the username incorrect.
It says "scootergrinsen" but should be "scootergrisen" as author on http://git.fluxbox.org/fluxbox.git/log/nls/da_DK/Translation.m

#217 Remove last workspace problems

dive — Thu, 22 Feb 2018 03:45:20 -0000

Sorry, should have said the fluxbox version is a git clone a few months ago.

Remove last workspace problems

dive — Thu, 22 Feb 2018 03:44:42 -0000

When I add a new workspace and then later remove it, it still remains in init and also seems that X thinks it still exists.

Here I had workspaces 1-5, addded a new one then removed it, but according to init:

session.screen0.workspaceNames: 1,2,3,4,5,Workspace 6,

However, it does not show in the workspace menu.

The problem is that pypanel polls for workspace names and it is still listed, so it shows in the workspace list. I tried doing a reload config and a restart, but it remains unless I exit fluxbox completely.

#161 Warping vertically

Mathias Gumz — Sun, 19 Nov 2017 19:15:38 -0000

status: open --> closed-accepted
assigned_to: Mathias Gumz
Group: --> 1.4.0

#161 Warping vertically

Mathias Gumz — Sun, 19 Nov 2017 19:15:14 -0000

merged as 7cb7bfaa448003466315ccc21d08b71f5c77df70

#161 Warping vertically

Mathias Gumz — Sun, 19 Nov 2017 15:08:19 -0000

the resource "workspace_warping_vertical_offset" in your patch is "bool", you want it to be "int" (otherwise your suggested usage won't work)