Thread: [FE-discuss] String validator, max/min and None value

Hi,

When "max" parameter is specified for String validator that is allowed
to be empty, error occures when None value is passed:

........ line 842, in validate_python
    if self.max is not None and len(value) > self.max:
TypeError: len() of unsized object

Is it a bug or am I doing something wrong?


Thanks,

Ksenia.

Ksenia Marasanova wrote:
> Hi,
> 
> When "max" parameter is specified for String validator that is allowed
> to be empty, error occures when None value is passed:
> 
> ........ line 842, in validate_python
>     if self.max is not None and len(value) > self.max:
> TypeError: len() of unsized object
> 
> Is it a bug or am I doing something wrong?

Sounds like a bug, should be fixed in r975.  Should also work with min 
now as well.

-- 
Ian Bicking  /  ia...@co...  /  http://blog.ianbicking.org

2005/9/8, Ian Bicking <ia...@co...>:
> Ksenia Marasanova wrote:
> > Hi,
> >
> > When "max" parameter is specified for String validator that is allowed
> > to be empty, error occures when None value is passed:
> >
> > ........ line 842, in validate_python
> >     if self.max is not None and len(value) > self.max:
> > TypeError: len() of unsized object
> >
> > Is it a bug or am I doing something wrong?
>=20
> Sounds like a bug, should be fixed in r975.  Should also work with min
> now as well.

Thanks for the quick response.
But it looks like "min" now implies "not_empty". Is it intentional?

>>> validators.String(max=3D2).to_python(None)
>>> validators.String(min=3D2).to_python(None)
Traceback (most recent call last):
  File "<stdin>", line 1, in ?
  File "/Users/ksenia/www/3rdparty/formencode/api.py", line 223, in to_pyth=
on
    self.validate_python)
  File "/Users/ksenia/www/3rdparty/formencode/api.py", line 211, in
attempt_convert
    post(converted, state)
  File "validators.py", line 851, in validate_python
    value, state)
api.Invalid: Enter a value 2 characters long or more
>>>=20


--=20
Ksenia

Ksenia Marasanova wrote:
> 2005/9/8, Ian Bicking <ia...@co...>:
> 
>>Ksenia Marasanova wrote:
>>
>>>Hi,
>>>
>>>When "max" parameter is specified for String validator that is allowed
>>>to be empty, error occures when None value is passed:
>>>
>>>........ line 842, in validate_python
>>>    if self.max is not None and len(value) > self.max:
>>>TypeError: len() of unsized object
>>>
>>>Is it a bug or am I doing something wrong?
>>
>>Sounds like a bug, should be fixed in r975.  Should also work with min
>>now as well.
> 
> 
> Thanks for the quick response.
> But it looks like "min" now implies "not_empty". Is it intentional?

Well, that's kind of an outstanding issue; right now not_empty is 
implied in many places.  But not everywhere.  This just exposes that, I 
guess; it wasn't really changed.

To me min>0 does kind of imply not_empty, though I suppose it could be 
argument that None should still get through if not_empty had to be given 
explicitly.  Except None and '' are generally treated very similarly, 
and min>0 *definitely* implies that '' isn't valid.

-- 
Ian Bicking  /  ia...@co...  /  http://blog.ianbicking.org

2005/9/8, Ian Bicking <ia...@co...>:
> Ksenia Marasanova wrote:
> > 2005/9/8, Ian Bicking <ia...@co...>:
> >
> >>Ksenia Marasanova wrote:
> >>
> >>>Hi,
> >>>
> >>>When "max" parameter is specified for String validator that is allowed
> >>>to be empty, error occures when None value is passed:
> >>>
> >>>........ line 842, in validate_python
> >>>    if self.max is not None and len(value) > self.max:
> >>>TypeError: len() of unsized object
> >>>
> >>>Is it a bug or am I doing something wrong?
> >>
> >>Sounds like a bug, should be fixed in r975.  Should also work with min
> >>now as well.
> >
> >
> > Thanks for the quick response.
> > But it looks like "min" now implies "not_empty". Is it intentional?
>=20
> Well, that's kind of an outstanding issue; right now not_empty is
> implied in many places.  But not everywhere.  This just exposes that, I
> guess; it wasn't really changed.
>=20
> To me min>0 does kind of imply not_empty, though I suppose it could be
> argument that None should still get through if not_empty had to be given
> explicitly.  Except None and '' are generally treated very similarly,
> and min>0 *definitely* implies that '' isn't valid.

I think I am in the camp of "None is not '' " :). Maybe it can be made
an option, something like "keep_blank_values" in cgi.FieldStorage...

--=20
Ksenia