Thread: [FE-discuss] Testing FormEncode 1.3.0a1

Hi,
i'm testing the new version (we are porting our 120KSLOC app on Python
3) and I have a question about it, because some tests are broken. Is
the new version strictly compatible with the 1.2.4 version?

-- 
Sebastien Douche <sd...@gm...>
Twitter: @sdouche / G+: +sdouche

Hi Sebastien,

1.3 is mostly compatible but there are a few changes that are backward in
compatible. They should all be listed here
http://www.formencode.org/en/latest/whatsnew-1.3.html but I readily admit
that one of the things holding back a full 1.3 release is documentation.
There *may* be something that is inadvertently backwards incompatible and
if you find something like that please submit a bug to
https://github.com/formencode/formencode/issues?state=open . Also the 1.2.5
release had some backwards incompatible changes that might cause a problem
if you have custom validators that expect sequences to be passed to them
from a Schema. Details can be found here:
http://www.formencode.org/en/latest/whatsnew-1.2.5.html.

-Chris


On Thu, Dec 5, 2013 at 11:27 AM, Sebastien Douche <sd...@gm...> wrote:

> Hi,
> i'm testing the new version (we are porting our 120KSLOC app on Python
> 3) and I have a question about it, because some tests are broken. Is
> the new version strictly compatible with the 1.2.4 version?
>
> --
> Sebastien Douche <sd...@gm...>
> Twitter: @sdouche / G+: +sdouche
>
>
> ------------------------------------------------------------------------------
> Sponsored by Intel(R) XDK
> Develop, test and display web and hybrid apps with a single code base.
> Download it for free now!
>
> http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
> _______________________________________________
> FormEncode-discuss mailing list
> For...@li...
> https://lists.sourceforge.net/lists/listinfo/formencode-discuss
>



-- 
Christopher Lambacher
ch...@ka...

On Thu, Dec 5, 2013 at 5:37 PM, Chris Lambacher <ch...@ka...> wrote:
> Hi Sebastien,

Hi Chris

> Also the 1.2.5
> release had some backwards incompatible changes that might cause a problem
> if you have custom validators that expect sequences to be passed to them
> from a Schema. Details can be found here:
> http://www.formencode.org/en/latest/whatsnew-1.2.5.html.

Right, same broken tests with the 1.2.5.




-- 
Sebastien Douche <sd...@gm...>
Twitter: @sdouche / G+: +sdouche

Hi Sebastien,

>
> > Also the 1.2.5
> > release had some backwards incompatible changes that might cause a
> problem
> > if you have custom validators that expect sequences to be passed to them
> > from a Schema. Details can be found here:
> > http://www.formencode.org/en/latest/whatsnew-1.2.5.html.
>
> Right, same broken tests with the 1.2.5.


That narrows things down. Do you have a custom validator that expects a
sequence that doesn't derive from a formencode validator that expects as
sequence (list, dict, tuple, etc)? If so you will need to add
an accept_iterator = True property to your validator. You can do a quick
test for that by adding it to the instantiation args somewhere you use the
validator.

-Chris

-- 
Christopher Lambacher
ch...@ka...

On Thu, Dec 5, 2013 at 6:12 PM, Chris Lambacher <ch...@ka...> wrote:
>> Right, same broken tests with the 1.2.5.
>
> That narrows things down. Do you have a custom validator that expects a
> sequence that doesn't derive from a formencode validator that expects as
> sequence (list, dict, tuple, etc)? If so you will need to add an
> accept_iterator = True property to your validator. You can do a quick test
> for that by adding it to the instantiation args somewhere you use the
> validator.

Exact, we use iterator. It's work now with FormEncode 1.2.6. I will
try later with 1.3.0a1.  Thanks Chris.


-- 
Sebastien Douche <sd...@gm...>
Twitter: @sdouche / G+: +sdouche

On Wed, Dec 11, 2013 at 6:04 PM, Sebastien Douche <sd...@gm...> wrote:
> On Thu, Dec 5, 2013 at 6:12 PM, Chris Lambacher <ch...@ka...> wrote:
>>> Right, same broken tests with the 1.2.5.
>>
>> That narrows things down. Do you have a custom validator that expects a
>> sequence that doesn't derive from a formencode validator that expects as
>> sequence (list, dict, tuple, etc)? If so you will need to add an
>> accept_iterator = True property to your validator. You can do a quick test
>> for that by adding it to the instantiation args somewhere you use the
>> validator.
>
> Exact, we use iterator. It's work now with FormEncode 1.2.6. I will
> try later with 1.3.0a1.  Thanks Chris.

Tests pass with 1.3.0a1 :).


-- 
Sebastien Douche <sd...@gm...>
Twitter: @sdouche / G+: +sdouche

On Wed, Dec 11, 2013 at 12:04 PM, Sebastien Douche <sd...@gm...>wrote:

>
> Exact, we use iterator. It's work now with FormEncode 1.2.6. I will
> try later with 1.3.0a1.  Thanks Chris.


Was  it a custom validator or are we missing a built in one that should
accept an iterator that does not have the flag set?

Thanks,
Chris

-- 
Christopher Lambacher
ch...@ka...

On Wed, Dec 11, 2013 at 6:13 PM, Chris Lambacher <ch...@ka...> wrote:
>> Exact, we use iterator. It's work now with FormEncode 1.2.6. I will
>> try later with 1.3.0a1.  Thanks Chris.
>
> Was  it a custom validator or are we missing a built in one that should
> accept an iterator that does not have the flag set?

We use the Constant Validator on an iterator value.

-- 
Sebastien Douche <sd...@gm...>
Twitter: @sdouche / G+: +sdouche

On Wed, Dec 11, 2013 at 12:18 PM, Sebastien Douche <sd...@gm...>wrote:

> On Wed, Dec 11, 2013 at 6:13 PM, Chris Lambacher <ch...@ka...>
> wrote:
> >> Exact, we use iterator. It's work now with FormEncode 1.2.6. I will
> >> try later with 1.3.0a1.  Thanks Chris.
> >
> > Was  it a custom validator or are we missing a built in one that should
> > accept an iterator that does not have the flag set?
>
> We use the Constant Validator on an iterator value.


I think it is reasonable that Constant Validator should accept an iterator
by default. I'll make that change.

-Chris

-- 
Christopher Lambacher
ch...@ka...