common.inc.php scope problem?

2002-02-09T22:07:30Z

Using RH7.2 with PHP4.0.6 and General 0.3.6

Trying to figure out what getref does in
common.inc.php and noticed this check:

$support = array();
...
if( !in_array( $param["url"], array_keys( $support ) )
|| !is_object( $support[$param["url"]] ) )

The variable $support is defined local to the getref
function and you've done nothing with it yet. What do
you expect to find in it? Here, you're searching it
for array keys for a specific URL and if there's an
object at that key?

Then I noticed you have another $support = array();
declared at the beginning of this include file. Why?
Unless you meant to have the including file be able to
use it...without passing it into the functions.

In summary, I think you want to change this line in
the getref function from:

$support = array();

-to-

global $support = array();

That way, you're changing the variable that's global
in this include file.

openldap.class.php bug?

2002-02-09T02:34:37Z

I'm on RH7.2, PHP4.0.6, Apache1.3.22. Was tracking
down a login problem and noticed these in
openldap.class.php:

$errmsg .= $loc->i18n( "Unable to search
user" ) . "\n";

-and-

$errmsg .= $loc->i18n( "Unable to get result" ) . "\n";

Shouldn't these be:

$errmsg .= $this->i18n( "Unable to search
user" ) . "\n";

-and-

$errmsg .= $this->i18n( "Unable to get
result" ) . "\n";

I'm not good with objects in PHP, but this looked
fishy to me.

Recent changes to bugs

common.inc.php scope problem?

openldap.class.php bug?