Recent changes to bugs

#329 make: gfn file skips trailing comments from inp code file

Sven Schreiber — Mon, 23 Mar 2026 18:14:08 -0000

status: open --> closed

#329 make: gfn file skips trailing comments from inp code file

Allin Cottrell — Mon, 23 Mar 2026 16:26:57 -0000

No, I think it can now be closed again.

#329 make: gfn file skips trailing comments from inp code file

Sven Schreiber — Mon, 23 Mar 2026 14:25:17 -0000

I tested this with some package code of my own with the latest snapshot and inline / end-of-line comments show up alright in the code view of the package.
So I would close this again, or did you have other tests in mind, @allin?

#329 make: gfn file skips trailing comments from inp code file

Allin Cottrell — Fri, 20 Mar 2026 14:06:00 -0000

status: closed --> open

#327 problem with strsub

Sven Schreiber — Thu, 19 Mar 2026 14:04:31 -0000

status: open --> closed

#329 make: gfn file skips trailing comments from inp code file

Sven Schreiber — Thu, 19 Mar 2026 14:02:54 -0000

status: open --> closed

#329 make: gfn file skips trailing comments from inp code file

Sven Schreiber — Thu, 19 Mar 2026 14:02:44 -0000

The more or less official recommendation right now is what you said before: if you want the comments to appear to the user in the code view, then only put them on separate lines, not inline.
Of course, for non-packaged functions and especially for your own codebase you can continue to put the comments wherever you like. Personally, I also use the inline commenting style a lot, but I understand that currently the cost-benefit ratio of preserving those inside a packaged function is too large.
So I'm going to close this.

#329 make: gfn file skips trailing comments from inp code file

Allin Cottrell — Wed, 18 Mar 2026 18:21:04 -0000

I wouldn't say this is a feature, exactly. But it's not inadvertent and I wouldn't say it's a bug. It's kind of a forced move to ensure greatest efficiency of hansl function code. We can fairly easily detect lines that are entirely comment, and store them but mark them as IGNORE for execution purposes. It would no doubt be possible, but would be a good deal more complicated, to preserve trailing inline comments.

#327 problem with strsub

Sven Schreiber — Tue, 17 Mar 2026 18:26:49 -0000

Some further discussion about the situation with escaping in string (literals) has been added to the guide, see https://sourceforge.net/p/gretl/git/ci/6fdeea228dfe5fba0f0038b475063fbeb797587c/
It seems there is no clean and backwards-compatible way out of this puzzle; but OTOH you can already do everything you need to do, so it's not a big deal. When in doubt, use sprintf() where you have the full backslash escaping rules in effect.
So this ticket may probably be closed soon, even though part of the problem will persist.

#329 make: gfn file skips trailing comments from inp code file

Sven Schreiber — Tue, 17 Mar 2026 18:18:20 -0000

Not sure this is a feature instead of a bug. I believe it is actually a recent change that comments are preserved at all in the gfn, and so I'd guess that the removal of trailing comments is perhaps an oversight. (It still seems to happen, at least for me with a recent snapshot.)