Recent changes to patches

#166 Cannot select track other than first one

Solbu — Tue, 31 Aug 2021 14:01:13 -0000

Ticket moved from /p/grip/bugs/397/

#165 Splitting on Artist/Title results in corrupted titles

Solbu — Mon, 02 Dec 2019 23:14:57 -0000

status: open --> closed-fixed
Group: Bug -->

#165 Splitting on Artist/Title results in corrupted titles

Solbu — Mon, 02 Dec 2019 23:09:09 -0000

Ticket moved from /p/grip/bugs/409/

Splitting on Artist/Title results in corrupted titles

Dan Fandrich — Mon, 02 Dec 2019 21:21:55 -0000

Ticket 165 has been modified: Splitting on Artist/Title results in corrupted titles
Edited By: Solbu (solbu)
Status updated: u'open' => u'closed-fixed'
_milestone updated: u'Bug' => ''

#164 Ignore deprecated declarations from GTK/Gnome

Solbu — Fri, 04 Oct 2019 23:55:32 -0000

status: open --> closed-fixed
Group: -->

#163 Replace deprecated glib print methods

Solbu — Fri, 04 Oct 2019 23:52:07 -0000

status: open --> closed-fixed
Group: -->

#163 Replace deprecated glib print methods

Solbu — Fri, 04 Oct 2019 21:32:53 -0000

Interesting timing of this and the other patch. :-)
i just received a patchset from the Fedora grip maintainer, that fixes this and the deprecated declarations.

I was just about to test them after applying, and if they work I'll push and release later tonight.

Ignore deprecated declarations from GTK/Gnome

Stephan Wurm — Fri, 04 Oct 2019 21:29:04 -0000

Recently, I ran into many output like this:

/usr/include/glib-2.0/gobject/gtype.h:679:1: note: declared here
  679 | {
      | ^
In file included from /usr/include/gtk-2.0/gtk/gtktoolitem.h:31,
                 from /usr/include/gtk-2.0/gtk/gtktoolbutton.h:30,
                 from /usr/include/gtk-2.0/gtk/gtkmenutoolbutton.h:30,
                 from /usr/include/gtk-2.0/gtk/gtk.h:126,
                 from /usr/include/libgnomeui-2.0/gnome.h:4,
                 from main.c:24:
/usr/include/gtk-2.0/gtk/gtktooltips.h:73:3: error: 'GTimeVal' is deprecated: Use 'GDateTime' instead [-Werror=deprecated-declarations]
   73 |   GTimeVal last_popdown;
      |   ^~~~~~~~
In file included from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from /usr/include/glib-2.0/gobject/gbinding.h:28,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from /usr/include/glib-2.0/gio/gioenums.h:28,
                 from /usr/include/glib-2.0/gio/giotypes.h:28,
                 from /usr/include/glib-2.0/gio/gio.h:26,
                 from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
                 from /usr/include/gtk-2.0/gdk/gdk.h:32,
                 from /usr/include/gtk-2.0/gtk/gtk.h:32,
                 from /usr/include/libgnomeui-2.0/gnome.h:4,
                 from main.c:24:
/usr/include/glib-2.0/glib/gtypes.h:551:8: note: declared here
  551 | struct _GTimeVal
      |        ^~~~~~~~~
In file included from /usr/include/libgnome-2.0/libgnome/libgnome.h:29,
                 from /usr/include/libgnomeui-2.0/gnome.h:5,
                 from main.c:24:
/usr/include/libgnome-2.0/libgnome/gnome-program.h:246:28: error: 'GParameter' is deprecated [-Werror=deprecated-declarations]
  246 |                            guint nparams, GParameter *params);
      |                            ^~~~~
In file included from /usr/include/glib-2.0/gobject/gobject.h:26,
                 from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from /usr/include/glib-2.0/gio/gioenums.h:28,
                 from /usr/include/glib-2.0/gio/giotypes.h:28,
                 from /usr/include/glib-2.0/gio/gio.h:26,
                 from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
                 from /usr/include/gtk-2.0/gdk/gdk.h:32,
                 from /usr/include/gtk-2.0/gtk/gtk.h:32,
                 from /usr/include/libgnomeui-2.0/gnome.h:4,
                 from main.c:24:
/usr/include/glib-2.0/gobject/gparam.h:271:8: note: declared here
  271 | struct _GParameter /* auxiliary structure for _setv() variants */
      |        ^~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [Makefile:498: main.o] Error 1

I have added a patch, that requests GCC to ignore thos deprecated declarations from the GTK / Gnome libraries.

Ignore deprecated declarations from GTK/Gnome

Stephan Wurm — Fri, 04 Oct 2019 21:29:04 -0000

Ticket 164 has been modified: Ignore deprecated declarations from GTK/Gnome
Edited By: Solbu (solbu)
Status updated: u'open' => u'closed-fixed'

Replace deprecated glib print methods

Stephan Wurm — Fri, 04 Oct 2019 21:03:49 -0000

Recent version of glib replaced some deprecated print methods:

g_string_sprintf -> g_string_printf
g_string_sprintfa -> g_string_append_printf

The attached patch fixes usage of the deprecated functions.