Recent changes to bugs

Destructor silently fails to delete class object

Michał Mrozik — Wed, 12 Jun 2024 08:59:57 -0000

Hello,

I am using tclsh 8.6 and itcl 4.2.1. My machine's OS is CentOS Linux release 7.9.2009 (Core).
I have noticed a bug in itcl destructor. A destructor with tcl syntax error can silently pass, but the object is not deleted. I created an itcl::local instance of my_class (a class with a syntax error in destructor) inside a procedure body. First procedure call passes with the error silented (which is already quite bad). Another call fails because of already existing object with the specified name in the current namespace. At that point I can't remove the object manually, since interpreter claims that it is currently being deleted.

Check the following example:

package require itcl

itcl::class my_class {
destructor {
puts "my_class destructor start"
dict for {k v} {
puts "syntax error on purpose"
}
}
}
proc my_proc {} {
itcl::local my_class 123
}
puts "Error in destructor is silented"
my_proc
puts "'123' exists in current namespace"
my_proc
itcl::delete object 123 ;# -> can't delete an object while it is being destructed

Thread containing an itcl::ensemble crashes by releasing

Szabó László Zoltán — Wed, 26 May 2021 12:05:18 -0000

thread::send -async [thread::create {thread::wait}] {
package require Itcl
::itcl::ensemble dummy {}
} result
After releasing the thread, the interpreter crashes with "alloc: invalid block..."

#291 memory leak in ItclCreateArgList function

Don Porter — Fri, 31 May 2019 15:46:09 -0000

status: open --> closed-out-of-date
Group: 3.3.0 --> 4.0*

#291 memory leak in ItclCreateArgList function

Don Porter — Fri, 31 May 2019 15:45:11 -0000

Sure looks like this was fixed more than 2 years ago. Upgrade to fix.

https://core.tcl-lang.org/itcl/info/0b0d0e0b8cd8105c

#291 memory leak in ItclCreateArgList function

Don Porter — Fri, 31 May 2019 15:31:54 -0000

That said, the routine ItclCreateArgList() in current development certainly includes ckfree() calls on both argv and defaultArgv. Can you specify the code path that misses those calls and leaks?

#291 memory leak in ItclCreateArgList function

Don Porter — Fri, 31 May 2019 15:30:34 -0000

~~~
All work on Itcl 4.0.* is abandoned. Upgrade to Itcl 4.1.2 or development trunk.

#291 memory leak in ItclCreateArgList function

Gevorg Tevosyan — Fri, 31 May 2019 13:43:51 -0000

My Itcl version is 4.0.4

memory leak in ItclCreateArgList function

Gevorg Tevosyan — Fri, 31 May 2019 13:34:24 -0000

file -> itclHelpers.c
function ->ItclCreateArgList

Tcl_SplitList allocates memory on argv and defaultArgv but those not fried in this function after usage which cause memory leaks

Below documentation for Tcl_SplitList https://www.tcl.tk/man/tcl8.4/TclLib/SplitList.htm in which it says that it is caller responsibility to free memory.

Thanks,
Gevorg

memory leak in ItclCreateArgList function

Gevorg Tevosyan — Fri, 31 May 2019 13:34:24 -0000

Ticket 291 has been modified: memory leak in ItclCreateArgList function
Edited By: Don Porter (dgp)
Status updated: u'open' => u'closed-out-of-date'
_milestone updated: u'3.3.0' => u'4.0*'

Class Procedures Can Be Called Like Methods

Tim Tomkinson — Thu, 28 Mar 2019 12:50:11 -0000

Class procedures can be erroneously called like methods. They even have access to instance variables:

package require Itcl

itcl::class A {

    public proc hello {} {
        puts hello
    }

    private variable var there

    public proc there {} {
        puts $var
    }
}

# Works as expected.
A::hello

# Works, but shouldn't.
set a [A #auto]
$a hello

# Can even access instance variables.
$a there

With Itcl 4.1.2:

hello
hello
there

With Itcl 3.4:

hello
bad option "hello": should be one of...
  a0 cget -option
  a0 configure ?-option? ?value -option value...?
  a0 isa className
    while executing
"$a hello "