Recent changes to bugs

#24 Licensing bugs

Henri Yandell — Tue, 23 Aug 2016 04:00:07 -0000

Vikram Roopchand - I saw you were active on the project. Any thoughts on the above?

#16 thread jI_ShutdownHook NullPointerException

ZhangXue — Tue, 10 May 2016 09:24:38 -0000

Got the same exception. Is there some workaround?

Licensing bugs

Henri Yandell — Wed, 25 Jun 2014 17:29:07 -0000

There are two licensing bugs in the current trunk.

1/ After the LGPL->EPL relicensing, an lgpl.txt file is still sitting in the source code. Presumably this needs to be removed?

https://sourceforge.net/p/j-interop/code/HEAD/tree/trunk/j-interop/lgpl.txt

2/ The https://sourceforge.net/p/j-interop/code/HEAD/tree/trunk/j-interop/src/org/jinterop/dcom/transport/niosupport/ChannelListener.java file says that is CC-NonCommercial. This isn't compliant with LGPL or EPL. Is this an error?

Thanks,

Hen

Possible errors

Shelohnev Dmitry — Sat, 10 May 2014 08:13:29 -0000

Sorry for my english !

I have method:

RequestData (
    [in] long count,
    [in, out] DataRow* data,
    [out] long* time,
    [out] short* msec);

DataRow {
    unsigned short index;
    unsigned char attr;
    unsigned char node;
    single val;
    unsigned long status;
    char* list;
};

I think I found two errors that can life reproduced with the above method:
1. Objects of JIPointer from array listOfDefferedPointers do not need aligning (in method JICallBuilder.readPacket)
2. HResult value must be aligned to 4 byte in JICallBuilder.readResult.
The same changes must be made when serializing request.

In an attachment, files with changes that I suggest to add to the project.

I call this method so:

public RequestDataResult requestData(DataRow[] dataRows) throws Exception {
        callBuilder.reInit();
        //RequestData(
        callBuilder.setOpnum(4);
        //[in] long count,
        callBuilder.addInParamAsInt(dataRows.length, JIFlags.FLAG_NULL);
        JIStruct[] dra = new JIStruct[dataRows.length];
        for(int i = 0; i < dataRows.length; i++) {
            dra[i] = dataRows[i].toJIStruct();
        }
        //[in, out] DATAROW* data,
        callBuilder.addInParamAsArray(new JIArray(dra, true), JIFlags.FLAG_NULL);
        callBuilder.addOutParamAsObject(new JIArray(DataRow.toJIStructTemplate(), null, 1, true), JIFlags.FLAG_NULL);
        //[out] long* time,
        callBuilder.addOutParamAsType(Integer.class, JIFlags.FLAG_NULL);
        //[out] short* msec);
        callBuilder.addOutParamAsType(Short.class, JIFlags.FLAG_NULL);

        Object[] result = iTmRtm.call(callBuilder);
        if (result.length > 0) {
            JIStruct[] structDataRows = (JIStruct[]) ((JIArray)result[0]).getArrayInstance();
            for(int i = 0; i < dataRows.length; i++) {
                dataRows[i] = DataRow.parse(structDataRows[i]);
            }
            return new RequestDataResult(dataRows, (int)result[1], (short) result[2]);
        }
        throw new Exception("Сервер TraceMode вернул некорректное значение");
    }

public JIStruct toJIStruct() {
        JIStruct struct = null;
        try {
            struct = new JIStruct();
            //unsigned short index
            struct.addMember(JIUnsignedFactory.getUnsigned(index, JIFlags.FLAG_REPRESENTATION_UNSIGNED_SHORT));
            //unsigned char attr
            struct.addMember(JIUnsignedFactory.getUnsigned(attribute, JIFlags.FLAG_REPRESENTATION_UNSIGNED_BYTE));
            //unsigned char node;
            struct.addMember(JIUnsignedFactory.getUnsigned(node, JIFlags.FLAG_REPRESENTATION_UNSIGNED_BYTE));
            //single val
            struct.addMember(value);
            //unsigned long status
            struct.addMember(JIUnsignedFactory.getUnsigned(status, JIFlags.FLAG_REPRESENTATION_UNSIGNED_INT));
            //char* list
            struct.addMember(new JIPointer(list));
        } catch (JIException ex) {
            logger.error(ex.getMessage());
        }
        return struct;
    }

    public static JIStruct toJIStructTemplate() {
        JIStruct struct = null;
        try {
            struct = new JIStruct();
            //unsigned short index
            struct.addMember(JIUnsignedShort.class);
            //unsigned char attr
            struct.addMember(JIUnsignedByte.class);
            //unsigned char node;
            struct.addMember(JIUnsignedByte.class);
            //single val
            struct.addMember(Float.class);
            //unsigned long status
            struct.addMember(JIUnsignedInteger.class);
            //char* list
            struct.addMember(new JIPointer(Byte.class));
        } catch (JIException ex) {
            logger.error(ex.getMessage());
        }
        return struct;
    }

#22 destroySession blocked by Release_Reference_TImerTask

Vikram Roopchand — Wed, 02 Apr 2014 08:14:30 -0000

Hi,

Can you try this JISession.setGlobalSocketTimeout, set it to something like 5 mins.

thanks,
best regards,
Vikram

destroySession blocked by Release_Reference_TImerTask

Wellington Rats — Mon, 31 Mar 2014 13:31:16 -0000

I have an application that collects Windows information periodically using threads.
Each thread connects to a Windows Server and uses it's own JISession and releases it using JISession.destroySession(...) after collect information and waits for next cycle.

Eventually after a few days one of this threads becames BLOCKED and don't collects anymore.

Analyzing source code and stack trace above, it seems that for any reason, it becomes blocked by Timer (Release_References_TimerTask).

My Thread is "pool6-thread-25"
Release_References_TimerTask is "Timer-5"

It seems that both threads are lockeds.

Is it possible not to start "Release_Reference_TimerTask" at static code of JISession ?
Is there a way to Timer do not blocks other threads ?

"pool-6-thread-25" - Thread t@46
java.lang.Thread.State: BLOCKED
at org.jinterop.dcom.core.JIComServer.addRef_ReleaseRef(JIComServer.java:1021)
- waiting to lock (a java.lang.Object) owned by "Timer-5" t@59
at org.jinterop.dcom.core.JISession.releaseRefs(JISession.java:982)
at org.jinterop.dcom.core.JISession.destroySession(JISession.java:664)
at br.com.xact.xmon.plugins.protocols.wmi.Wmi.close(Wmi.java:294)
at br.com.xact.xmon.plugins.wmi.AbstractPluginWmi.finish(AbstractPluginWmi.java:68)
at br.com.xact.xmon.kernel.core.PluginRunnable.run(PluginRunnable.java:231)
at br.com.xact.xmon.kernel.core.RecursoMonitorado.executaPluginNestaThread(RecursoMonitorado.java:1754)
at br.com.xact.xmon.kernel.core.RecursoMonitorado.executaPluginMonitoramento(RecursoMonitorado.java:1920)
at br.com.xact.xmon.kernel.core.RecursoMonitorado.verificaMonitoramento(RecursoMonitorado.java:2770)
at br.com.xact.xmon.kernel.core.RecursoMonitorado.execute(RecursoMonitorado.java:2981)
at br.com.xact.xframe.core.types.Task.run(Task.java:107)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:304)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)

Locked ownable synchronizers:
- locked <93c8a6> (a java.util.concurrent.ThreadPoolExecutor$Worker)

"Timer-5" - Thread t@59
java.lang.Thread.State: WAITING
at sun.misc.Unsafe.park(Native Method)
- parking to wait for (a java.util.concurrent.SynchronousQueue$TransferStack)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
at java.util.concurrent.SynchronousQueue$TransferStack.awaitFulfill(SynchronousQueue.java:458)
at java.util.concurrent.SynchronousQueue$TransferStack.transfer(SynchronousQueue.java:359)
at java.util.concurrent.SynchronousQueue.take(SynchronousQueue.java:925)
at org.jinterop.dcom.transport.JIComTransport.receive(JIComTransport.java:304)
at rpc.DefaultConnection.receiveFragment(DefaultConnection.java:201)
at rpc.DefaultConnection.receive(DefaultConnection.java:86)
at rpc.ConnectionOrientedEndpoint.receive(ConnectionOrientedEndpoint.java:226)
at rpc.ConnectionOrientedEndpoint.call(ConnectionOrientedEndpoint.java:123)
at rpc.Stub.call(Stub.java:113)
at org.jinterop.dcom.core.JIComServer.call(JIComServer.java:990)
- locked (a java.lang.Object)
at org.jinterop.dcom.core.JIComServer.call(JIComServer.java:945)
at org.jinterop.dcom.core.JIComServer.addRef_ReleaseRef(JIComServer.java:1029)
- locked (a java.lang.Object)
at org.jinterop.dcom.core.JISession.releaseRefs(JISession.java:982)
at org.jinterop.dcom.core.JISession.access$9(JISession.java:969)
at org.jinterop.dcom.core.JISession$Release_References_TimerTask.run(JISession.java:347)
at java.util.TimerThread.mainLoop(Timer.java:555)
at java.util.TimerThread.run(Timer.java:505)

Locked ownable synchronizers:
- None

#5 java.io.IOException: Socket Closed

JMekala — Tue, 23 Apr 2013 19:54:41 -0000

How you fixed this? I have the same issue

Socket Closed - OPC Server

JMekala — Tue, 23 Apr 2013 19:52:45 -0000

I get the following exception, seemingly at random.
The problem generally happens when the connection is open and has been in use for a few minutes (anywhere from 7 sec).

Any ideas about what is going wrong here or how I can fix it would be greatly appreciated.

Log file attached. See "java.io.IOException: Socket Closed" at line 10299.

Caused by: org.jinterop.dcom.common.JIException: An internal error occurred. [0x8001FFFF]
at org.jinterop.dcom.core.JIComServer.call(JIComServer.java:799)
at org.jinterop.dcom.core.JIComServer.call(JIComServer.java:753)
at org.jinterop.dcom.core.JIComObjectImpl.call(JIComObjectImpl.java:209)
at org.jinterop.dcom.core.JIComObjectImpl.call(JIComObjectImpl.java:114)
at org.jinterop.dcom.win32.JIDispatchImpl.getIDsOfNames(JIDispatchImpl.java:101)
at org.jinterop.dcom.win32.JIDispatchImpl.get(JIDispatchImpl.java:416)
... 6 more
Caused by: java.io.IOException: Socket Closed
at rpc.DefaultConnection.receiveFragment(DefaultConnection.java:365)
at rpc.DefaultConnection.receive(DefaultConnection.java:69)
at rpc.ConnectionOrientedEndpoint.receive(ConnectionOrientedEndpoint.java:197)
at rpc.ConnectionOrientedEndpoint.bind(ConnectionOrientedEndpoint.java:174)
at rpc.ConnectionOrientedEndpoint.rebind(ConnectionOrientedEndpoint.java:149)
at org.jinterop.dcom.transport.JIComEndpoint.rebindEndPoint(JIComEndpoint.java:40)
at org.jinterop.dcom.core.JIComServer.call(JIComServer.java:789)
... 12 more

win7 localhost JIComServer.init () bug

Martin Appl — Tue, 31 Jan 2012 16:03:59 -0000

I came across this exeption: org.jinterop.dcom.common.JIException: An internal error occurred. \[0x8001FFFF\] at org.jinterop.dcom.core.JIRemUnknownServer.call$JIRemUnknownServer.java:158$ at org.jinterop.dcom.core.JIRemUnknownServer.addRef\_ReleaseRef$JIRemUnknownServer.java:181$ at org.jinterop.dcom.core.JISession.addRef\_ReleaseRef$JISession.java:782$ at org.jinterop.dcom.core.JIComObjectImpl.addRef$JIComObjectImpl.java:119$ at org.jinterop.dcom.core.JIComServer.createInstance$JIComServer.java:844$ at org.openscada.opc.lib.list.ServerList.<init>$ServerList.java:61$ at cz.appl.proofOfConcept.OpcInterface.findServer$OpcInterface.java:56$ at cz.appl.proofOfConcept.OpcInterface.connectServer$OpcInterface.java:44$ at cz.appl.proofOfConcept.MainWindow$1.widgetSelected$MainWindow.java:54$ at org.eclipse.swt.widgets.TypedListener.handleEvent$TypedListener.java:240$ at org.eclipse.swt.widgets.EventTable.sendEvent$EventTable.java:84$ at org.eclipse.swt.widgets.Widget.sendEvent$Widget.java:1053$ at org.eclipse.swt.widgets.Display.runDeferredEvents$Display.java:4165$ at org.eclipse.swt.widgets.Display.readAndDispatch$Display.java:3754$ at org.eclipse.jface.window.Window.runEventLoop$Window.java:825$ at org.eclipse.jface.window.Window.open$Window.java:801$ at cz.appl.proofOfConcept.MainWindow.main$MainWindow.java:116$ Caused by: java.net.SocketException: Address family not supported by protocol family: connect at sun.nio.ch.Net.connect$Native Method$ at sun.nio.ch.SocketChannelImpl.connect$Unknown Source$ at org.jinterop.dcom.transport.JIComTransport.attach$JIComTransport.java:185$ at rpc.Stub.attach$Stub.java:106$ at org.jinterop.dcom.core.JIRemUnknownServer.call$JIRemUnknownServer.java:142$ I did some googling and found this should be known issue, at should have been fixed someday during spring, So I used trunk codes and found out issue is still there. A debug it and found out source of problem lies in JIComServer.java on line 681. Returned bindings does not inlude localhost loop adress 127.0.0.1 but only network adapter adress. But expected target adress is 127.0.0.1. Since network adress does not corespond to 127.0.0.1, we cant pass check on line 681 $binding.getNetworkAddress\($.substring$0,index$.equalsIgnoreCase$targetAddress$\) and we fall to next loop which gives us ip6 address which is then put to setAddress. Ip6 address will then cause "Address family not supported by protocol family: connect" exception. I dont know hot to fix bindings provider, so I just added check for loopback adress and take binding with network adapter adress instead, Dont know if this will be fully operational solution. Please take a look at this issue.

JIVariant missing byte constructor (VT_I1)

Morten Andersen — Tue, 04 Oct 2011 11:22:17 -0000

Keywords: Creating VT\_I1 value. Patch attached. Various lines JIVariant $SVN revision @136$ The JIVariant class misses the two byte constructors: \[code\] public JIVariant$byte value, boolean isByRef$ public JIVariant$byte value$ \[/code\] These are needed to create a JIVariant of type VT\_I1 by calling them with a byte as value. The JIVariant\#makeVariant-method also requires these, as it is using the two-args constructor via reflection when called with a Byte-object. This fails and leads to null and the following warning in the log: \[code\] Oct 4, 2011 1:11:29 PM org.jinterop.dcom.core.JIVariant makeVariant WARNING: Could not create Variant for <value> , isByRef false \[/code\]