https://sourceforge.net/p/jonpy/patches/2010-09-17T22:07:26ZRecent changes to patches2010-09-17T22:07:26Z2010-09-17T22:07:26Zrraehttps://sourceforge.net/u/rrae/https://sourceforge.net9d5de61484d41eba58ebf35dea1653b715dd68f9

<div class="markdown_content"><p>as a call of dbpool.cursor() may create a new connection, it is neccessary to be able to do a rollback() on &gt;that&lt; connection, a call to dbpool.rollback does obviously no sense, here. to not have to call rollback on the hidden _connection attribute, i added a rollback method to _Cursor</p> <p>this patch is meant for dbpool.py in jonpy-0.09</p></div>

2004-09-27T11:16:21Z2004-09-27T11:16:21ZAnonymoushttps://sourceforge.net/u/userid-None/https://sourceforge.netb6b8fb2a7bf6d1f15e280846c95c9be9432d3442

<div class="markdown_content"><p>I got funny exceptions in the _connection_notinuse<br /> function of dbpool.py. My hunch was that because I<br /> instantiated many threads at the same time, all using<br /> the same connection, they maybe all entering this<br /> function at the same time. _make_available has a lock,<br /> but the rest of the stuff in _connection_notinuse isn't<br /> inside a lock. so I added another lock<br /> (_lock_not_in_use) which I aquire inside the<br /> _connection_notinuse function and release at the end.</p> <p>This got rid of the errors. Haven't tested extensively,<br /> but things seem to work fine now. I'm not a python (and<br /> especially not a threading) guru yet, so I'm not sure<br /> if this is the most efficient fix, but it does at least<br /> help proove my theory, I think.</p> <p>(by the way - great module. Exactly what I was looking<br /> for. Saved me a lot of work)</p> <p>--- dbpool.py 2002-07-03 18:50:38.000000000 +0200<br /> +++ jonpy-0.06/jon/dbpool.py 2004-09-27<br /> 12:30:04.000000000 +0200<br /> @@ -10,6 +10,7 @@</p> <p>_dbmod = None<br /> _lock = _thread.allocate_lock()<br /> +_lock_not_in_use = _thread.allocate_lock()<br /> _refs = {}</p> <p>@@ -62,6 +63,8 @@</p> <p>def _connection_notinuse(ref):<br /> + _lock_not_in_use.acquire()<br /> + try:<br /> inner = _refs[ref]<br /> del _refs[ref]<br /> inner._cursorref = None<br /> @@ -71,6 +74,8 @@<br /> if _make_available is not None:<br /> _make_available(_Connection(inner))</p> <p>+ finally:<br /> + _lock_not_in_use.release()</p> <p>class _Connection:<br /> def __init__(self, inner, *args, **kwargs):</p></div>