Recent changes to patches

#18 fix use-after-free / fixup trans_lang_get_similar

Felipe Castro — Sat, 26 Nov 2022 00:22:29 -0000

Ok, I have understood now. I'll apply the patch in next release, 3.14. Thank you very much!

I had tested a lot that function and it was working even with a pointer copy: strangely, the original pointer got modified by the local assignments (g_free, g_strdup, etc). But I understand that this is not the expected behavior, so I have fixed accordingly to your remark.

#18 fix use-after-free / fixup trans_lang_get_similar

Will Dietz — Fri, 25 Nov 2022 02:56:32 -0000

Without the patch it modifies a copy, not the original, that's the bug.

Look at the code paths exiting that function (lines modified by this patch) that do...

free(test);
test = strdup(...);
return TRUE;

This allocates a string and stores the pointer to it in the function-local char * "test" which is immediately leaked and does not modify or write to the address of the original.
The original still points at what it did previously, memory which has now been freed.

To store the char * of the new string (returned from strdup) into the original variable (in the caller of this function) you should have a pointer to the original variable (char **), which is what this patch fixes. To update the original you need to pass its address so it can be updated, hence the '&'.

This is a real bug, and needed to be fixed to avoid crashing on every launch when packaging. Please look again?

#19 update icon names to non-deprecated replacements (since GTK 3.10)

Felipe Castro — Thu, 24 Nov 2022 23:08:15 -0000

status: open --> closed

#17 Add missing semicolon at the end of klavaro.desktop's keyword entries

Felipe Castro — Thu, 24 Nov 2022 22:29:22 -0000

status: open --> closed

#16 Install metainfo files in 'metainfo' directory (not 'appdata')

Felipe Castro — Thu, 24 Nov 2022 22:11:05 -0000

status: open --> closed

#18 fix use-after-free / fixup trans_lang_get_similar

Felipe Castro — Thu, 24 Nov 2022 21:59:12 -0000

status: open --> wont-fix

update icon names to non-deprecated replacements (since GTK 3.10)

Will Dietz — Mon, 14 Mar 2022 14:02:45 -0000

Many of the references icon names are deprecated and don't appear in recent themes.

To work with these systems, update the various icons (mostly gtk-*) to their new names.

A few were left where the deprecation advice was to not use an icon but instead use a label. Those icons don't appear missing in themes I checked anyway.

Fixes missing icons when executing on systems without the old icons/names.

Deprecation notices mention this has been deprecated since GTK 3.10, which came out in 2013.

update icon names to non-deprecated replacements (since GTK 3.10)

Will Dietz — Mon, 14 Mar 2022 14:02:45 -0000

Ticket 19 has been modified: update icon names to non-deprecated replacements (since GTK 3.10)
Edited By: Felipe Castro (felipo)
Status updated: 'open' => 'closed'

fix use-after-free / fixup trans_lang_get_similar

Will Dietz — Mon, 14 Mar 2022 13:55:15 -0000

Fix memory corruption / use-after-free when setting up language.

Basically this method seems intended to change the char * in the caller, but instead changes only its local copy which is especially bad because it frees the original memory first. This leads to crashing or other bugs.
Fix this by passing a char ** and accessing it indirectly.

fix use-after-free / fixup trans_lang_get_similar

Will Dietz — Mon, 14 Mar 2022 13:55:15 -0000

Ticket 18 has been modified: fix use-after-free / fixup trans_lang_get_similar
Edited By: Felipe Castro (felipo)
Status updated: 'open' => 'wont-fix'