implicit declaration of functions and non-void functions that don't return a value

bob finch — Thu, 05 Sep 2024 19:02:49 -0000

Problem compiling with gcc 14.2.1 v/v the implicit errors... here's the output:

misc.c: In function ‘scale_entry_pair_set_entry’:
misc.c:410:3: error: implicit declaration of function ‘enable_circ_buttons’ [-Wimplicit-function-declaration]
410 | enable_circ_buttons(CIRCLIST_ENTRYSET);
| ^~~~~~~~~~~~~~~~~~~
misc.c: In function ‘on_comp_scale_value_changed’:
misc.c:438:3: error: implicit declaration of function ‘recalculate_all’ [-Wimplicit-function-declaration]
438 | recalculate_all(DST_SCREEN);
| ^~~~~~~~~~~~~~~
make[2]: *** [Makefile:450: misc.o] Error 1

Any progress on porting to Gtk-3?

Thu, 18 Jul 2024 15:44:22 -0000

Hi John,
Thanks for all of your work on this tool. It would be really nice if you can provide the already modified code. It does not make sense to do all the work again. Debugging is something else than try to start from scratch with shift to gtk3.

Best regards
R.

Any progress on porting to Gtk-3?

roucaries bastien — Fri, 01 Mar 2024 14:30:07 -0000

Hi,

Thanks John for your work

Could you try to post your WIP tree ? On debian side we may help to debug

rouca@debian.org

implicit declaration of functions and non-void functions that don't return a value

Ryan Carsten Schmidt — Wed, 10 Jan 2024 12:10:41 -0000

linSmith was added to MacPorts in 2004, back when the project was called DarwinPorts; we changed our name to MacPorts in 2006. Not all of our contributors always inform the upstream developers when their software becomes available in MacPorts, but you do mention the availability of this port here:

http://jcoppens.com/soft/linsmith/distros.en.php

If you retain this information on your web site, please change the link to https://ports.macports.org/port/linsmith and change "Mac OS X" to "macOS". (Apple renamed the operating system to "OS X" in 2012 and to "macOS" in 2016.) It also says we offer 0.9.2, but that hasn't been true since 2011 when we updated to 0.99.21, and we updated to 0.99.31, the version we currently have, in 2019. The versions you claim are available in Fink and OpenMamba are also outdated and your link to Debian is 404 not found. Rather than trying to keep track of which distributions offer which versions of your software you could outsource the task by just providing a link to repology.

Yes, the missing script is present, so the problem is that it is too old. It contains this line:

scriptversion=2005-06-08.21

meanwhile your build system was generated in 2017 using autoconf 2.69 (released in 2012) and automake 1.15 (released in 2015). The solution is to regenerate the build system using autoreconf -fvi. This will replace the bundled missing script, and all the other related bundled autotools files, with the current versions. Anyone who wants to build 0.99.33 can run this command manually before configuring but if you release another version of the autotools- and gtk2-based linSmith, you should make sure you install the latest autoconf and automake and fully renerate the build system before making the release. One last working release of the autotools/gtk2 branch to fix these issues and any other showstopping bugs would be a good idea, because I can imagine that the switch to meson and gtk3 and goocanvas will bring with it a whole new set of problems which will take time to solve, and your users will appreciate having a stable version of the old branch to use in the meantime. For such a release you can probably also remove your autogen.sh script; most autogen.sh scripts are no longer needed, their function having been replaced with autoreconf.

I am using clang, not gcc; clang is the preferred compiler on macOS for over a decade now. However, any C99-or-later compiler including gcc should at least print warnings about implicit function declarations, since they have been forbidden since C99, and you can turn those warnings into errors if you want to. Apple clang 12 and later and llvm.org clang 16 and later consider them to be errors by default and I expect gcc eventually will as well.

MacPorts continues to offer gtk2 and gtk3.

implicit declaration of functions and non-void functions that don't return a value

John Coppens — Wed, 10 Jan 2024 03:52:16 -0000

Hello Ryan!

Thanks for the heads-up on the MacPort of LinSmith... To be honest, this was the
first time I heard about the program being ported at all ;-) Kudos!

Here are some comments:

configure: WARNING: 'missing' script is too old or missing

... That error is new to me. I don't have the code here, but I seem to remember
the 'missing' script was there.

The 'implicit' declarations issues, I understand. I could solve them, but I haven't
seen them here. Are you using gcc?

Apart from that, I am a little surprised that you can still compile, because most
of modern distros dropped support for all the old GTK 2 stuff. I have largely
ported linSmith to Gtk3 and dropped the dependency on the old libs. As development
with autotools framework is getting difficult at the moment, I have also changed to
Meson. And ported the graphics to GooCanvas.

Last year was difficult for me but I was hoping I could use these days to continue
with the job.

What do you suggest?

implicit declaration of functions and non-void functions that don't return a value

Ryan Schmidt — Tue, 09 Jan 2024 07:01:24 -0000

Hello, I'm a developer with MacPorts. We have version 0.99.31 of linSmith in MacPorts and it does not build on current versions of macOS (with clang). I noticed 0.99.32 and 0.99.33 were released last year and hoped that the build issues might have been corrected but they have not been.

At configure time, this message is printed:

configure: WARNING: 'missing' script is too old or missing

I can use autoreconf to work around that, but at build time, these errors occur:

remote.c:40:37: error: non-void function 'remove_fifos' should return a value [-Wreturn-type]
element.c:315:16: error: non-void function 'clear_element_lnlist' should return a value [-Wreturn-type]
element.c:830:8: error: implicit declaration of function 'xml_file_loaded' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
import.c:77:10: error: implicit declaration of function 's2p_file_loaded' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
import.c:496:3: error: implicit declaration of function 'load_append' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
import.c:538:7: error: implicit declaration of function 'number_loads' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
import.c:543:27: error: implicit declaration of function 'loadlist_clear' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
import.c:588:5: error: implicit declaration of function 'load_append' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
chart.c:657:5: error: implicit declaration of function 'clear_element_lnlist' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
misc.c:410:3: error: implicit declaration of function 'enable_circ_buttons' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
misc.c:438:3: error: implicit declaration of function 'recalculate_all' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
misc.c:495:5: error: implicit declaration of function 'enable_circ_buttons' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
misc.c:498:5: error: implicit declaration of function 'enable_circ_buttons' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
misc.c:572:3: error: implicit declaration of function 'enable_circ_buttons' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
misc.c:580:3: error: implicit declaration of function 'enable_circ_buttons' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
load_rx.c:52:8: error: implicit declaration of function 'load_rx_valid' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
load_rx.c:66:9: error: implicit declaration of function 'number_selected_loads' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
load_rx.c:181:3: error: implicit declaration of function 'enable_load_buttons' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
load_rx.c:244:3: error: implicit declaration of function 'enable_load_buttons' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
load.c:221:25: error: implicit declaration of function 'enable_load_rx_buttons' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
load.c:222:26: error: implicit declaration of function 'enable_load_nb_buttons' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
load.c:262:7: error: implicit declaration of function 'on_load_rx_selected' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
load.c:265:7: error: implicit declaration of function 'on_load_nb_selected' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
load.c:296:7: error: implicit declaration of function 'loadlist_rx_clear' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
load.c:298:7: error: implicit declaration of function 'loadlist_nb_clear' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
load.c:376:8: error: implicit declaration of function 'xml_file_loaded' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

A fix for the return type issues was added to MacPorts a decade ago but we haven't worked on fixing the implicit function declaration issues; the fix is obvious though (declare functions before you call them).

Any progress on porting to Gtk-3?

Mattia Zomer — Wed, 29 Nov 2023 17:01:07 -0000

Hello, I registered here just to say thank you for such an incredibly useful tool. I really enjoy using it to understand what happens to my antennas and it helps a lot.

The package is not there for Debian Bookworm and I had no luck compiling it from source. But I managed to make the Appimage version above work by copying a few libraries that the program needs from an older Debian that had them (libgnomeui-2 libgnomecanvas-2, libgnome-2, libbonobo-2, libbonoboui-2, libart_lgpl_2, libbonobo-activation, libORBit-2, libgnomevfs-2, libgconf-2, libgnome-keyring, libORBitCosNaming-2).

The insight this program gives is fantastic, please keep it alive!
Best regards,
Mattia
IN3GYK

Any progress on porting to Gtk-3?

Harry McGavran — Thu, 09 Feb 2023 00:34:36 -0000

No guarantees, but you might try this...

Any progress on porting to Gtk-3?

Harry McGavran — Wed, 08 Feb 2023 20:07:51 -0000

Thanks for the reply John! I'm really looking forward to the Gtk3 version -- I'd like to help.

Any progress on porting to Gtk-3?

Harry McGavran — Wed, 08 Feb 2023 16:50:57 -0000

There is no libgnomeeui-2.0 with Ubuntu 20.04 and later -- and I'm not finding the Gtk3 version anywhere. Where can I download the Gtk3 version???

Recent posts to Discussion

implicit declaration of functions and non-void functions that don't return a value

Any progress on porting to Gtk-3?

Any progress on porting to Gtk-3?

implicit declaration of functions and non-void functions that don't return a value

implicit declaration of functions and non-void functions that don't return a value

implicit declaration of functions and non-void functions that don't return a value

Any progress on porting to Gtk-3?

Any progress on porting to Gtk-3?

Any progress on porting to Gtk-3?

Any progress on porting to Gtk-3?