Recent changes to attention-required

/Userland/ata/ata.h (8:02AM(AEST) 23-07-07

kmcguire — Wed, 22 Aug 2007 23:12:26 -0000

/Userland/ata/ata.h (8:02AM(AEST) 23-07-07

The header states a definition and a declaration of the 'Tata_ctl_info' structure.

The definition is correct placed, however the declaration should be in the/a source file.

Build System Using Make (8:02AM(AEST) 23-07-07

kmcguire — Wed, 22 Aug 2007 22:41:43 -0000

Regarding: Changes as of 8:02 AM (AEST) 23-07-07.

There are current six points that require attention for the build system using make that was just recently changed (8:02AM(AEST) 23-07-07).

These points are critical in that they completely prevent the build system from becoming functional, unless someone makes some pretty comprehensive fixes. The fixes requires are outlined below:

---------------------------------------------------
1. The file link.ld is missing from the root directory when compiling the kernel. (must be missing from the commit)
---------------------------------------------------
2. The 'rm_int' directory is still present in your commits, and the make system compiles and links it into the kernel with errors.
./rm_int/int_v86.o: In function `int_v86(int)':
rm_int/int_v86.cc:95: undefined reference to `enter_rm'
---------------------------------------------------
3. When 'ld' is executed it is looking for a link.ld file in each Userland directory.
---------------------------------------------------
4. You still use hard paths (not placed in a central configuration file) --- /Userland/mattise_lib/Makefile
---------------------------------------------------
5. In the root /Makefile you do a "make -f Userland/Makefile all" which does not account for having a clean build -- since right afterward you actually change into the mattise_lib directory then build it. (The userland directory need mattise_lib first.)
5.FIX
A fixed number five by changing the rule 'all' for the root /Makefile.
# makes everything
all:
@make -f kernel.mk all
@make -f Userland/Makefile all
Then I went into /Userland/Makefile and changed the FOLDERS to:
FOLDERS:=Userland/mattise_lib Userland/ata Userland/devfs Userland/fat Userland/matti.............

The important part is that Userland/mattise_lib comes first.
---------------------------------------------------
6. The kernel.mk makefile will fail during cleaning if certain compiler or linker flags are changed or using a configuration unlike you have. A actual example is the compiler not producing the *.d files which are assumed to exist...
6.PROBLEM
The problem is this stops the entire cleaning process. It would be nice if it simply complained about files it wanted to delete but did not exist. This will cause someone trying to compile your kernel a headache since they have to start searching through the Makefiles and figuring out how you build the kernel which may seem very simple to you.. but not others. =\ (It is simple to me.. but I have been looking at it for quite a few weeks)
(16:31:21) Kevin McGuire: 6.FIX
(16:31:40) Kevin McGuire: I fixed 6 by changing the clean rule in the root /Makefile to:
# cleans everything
clean:
rm $(shell find -iname "*.[oda]")

source tree: redundant declaration of critical structures

kmcguire — Sun, 19 Aug 2007 01:13:09 -0000

There are redundant declarations of critical structures in the source tree in the user land folder.

/Userland/devfs/main.c
struct vfs_Action;
struct vfs_ReqData;
struct devfs_Device;

/Userland/mattisevfs/main.c
struct vfs_Action;
struct vfs_ReqData;
struct devfs_Device;

One solution, but by no means the only solution, would be to create a directory like so:
1. /Userland/usr/include
2. /Userland/shared/include

Then place all shared declaration in their own header. For an example the file /Userland/shared/include/vfs.h could define/declare all structures used in message communication.

This should help prevent typos and the need for manual propagation of structure changes (or declaration changes) to multiple units.

-------------- extra --------------

So far two major groups of libraries and includes exist:
1. /newlib/
2. /Userland/mattise_lib/[lib,include]/
<<< 3. /Userland/[shared,usr]/include

I have dubbed (1) as the STDLIB, and (2) as the SYSLIB. The (3) could be dubbed as the USRLIB.