Recent changes to bugs

AssertMo.failNotEquals() has wrong visibility

David Emmett — Sun, 07 Jan 2007 15:51:11 -0000

The com.mockobjects.util.AssertMo.failNotEquals()method is declared as static protected void. However, since JUnit 3.8.2 (actually, CVS revision 1.19 of Assert), the visibility of junit.framework.Assert.failNotEquals() has changed from private to public.

This means that the com.mockobjects.util.AssertMo class will not compile against JUnit 3.8.2.

This needs to be fixed by modifying the visibility of the AssertMo.failNotEquals() method from protected to public. I have attached a file with this change made, based on revision 1.3.2.1 of the AssertMo class.

J2EE1.3 ServletRequest.getParameter() no param error

cparedes — Tue, 21 Mar 2006 12:09:25 -0000

Method getParameter(String) on MockHttpServletRequest
throws an Error for a parameter that is not included on
J2EE 1.3.

On version 1.2 getParameterValues(String key) calls
get(key) on the ReturnObjectBag that contains the
parameters. In version 1.3 calls getNextReturnObject(key).

ReturnObjectBag.getNextReturnObject() has an assert to
check that the value to return is not null.

I think this is not an improvement as the mocked
HttpServletRequest doesn't throw an exception when
getting a parameter that is not included in the
request, it returns null.

Also, this assert doesn't permit to test code that
deals with the situation that a parameter is not coming
with the request.

Trace of the Error:

junit.framework.AssertionFailedError: parameters does
not contain itemId
at junit.framework.Assert.fail(Assert.java:51)
at junit.framework.Assert.assertTrue(Assert.java:38)
at junit.framework.Assert.assertNotNull
(Assert.java:199)
at com.mockobjects.ReturnObjectBag.getNextReturnObject
(ReturnObjectBag.java:109)
at com.mockobjects.servlet.MockHttpServletRequest
.getParameterValues(MockHttpServletRequest.java:185)
at com.mockobjects.servlet.MockHttpServletRequest
.getParameter(MockHttpServletRequest.java:169)

make class MockResultSet public

Sergey Yevtushenko — Thu, 18 Aug 2005 07:52:54 -0000

Reason: I have written some helper code for simplify
mock testing of JDBC.
It looks like follows:

private Object
executePreparedStatementAndVerify(IDBOperation operation,

MockPreparedStatement prepared,

MockMultiRowResultSet aResultSet) {
prepared.addResultSet(aResultSet);

connection.setupAddPreparedStatement(operation.getStatementSQL(),
prepared);
Object result = operation.executeDBCall();
aResultSet.verify();
prepared.verify();
connection.verify();
return result;
}

However, when I want to change it for using
MockResultSet, (as I like to support the both
MockMultiRowResultSet and MockSingleRowResultSet with
this method).

MockPreparedStatement accepts MockResultSets, but as
this class is package local, I can not use it in the
code outside of com.mockobjects.sql.

Source Distribution contains CVS folders

Ilja Preuß — Tue, 20 Jul 2004 15:03:47 -0000

It would probably be better to filter them when building
the tar file.

Broken URL

Anonymous — Thu, 24 Jun 2004 20:13:38 -0000

The 1st hyper link on page:
http://www.mockobjects.com/MocksObjectsPaper.html
is broken.

nick_freespirit@yahoo.com

Critical: NEED 0.9.1 CallSequence.reset NOT resets callIndex

Anton Tagunov — Fri, 28 May 2004 15:19:07 -0000

Hi, gang! Awesome job, well done!

I see that lots has happened since 0.9, but I'm pledging
you the world needs 0.9.1 release!

com.mockobjects.dynamic.CallSequence.reset()

does not reset callIndex to zero, making reset() unusable.

Here's the fix:

public void reset()
{
this.expectedCalls.clear();
this.matchedCalls.reset();
+ callIndex = 0;
}

PLEASE, DO ROLL OUT A 0.9.1, IT'S REALLY CRITICAL

mockobjects does not compile on Gump

Antoine Levy-Lambert — Sun, 01 Feb 2004 21:33:27 -0000

The gump build
http://lsd.student.utwente.nl/gump/mockobjects/mockobjects.html
tries to compile the class
core.test.mockobjects.dynamic.InvocationMatcherTest

this class does not compile because it tries to use the
internal class
com.mockobjects.dynamic.InvocationMatcher.Arguments
which was suppressed on the 29th of October :
http://cvs.sourceforge.net/viewcvs.py/mockobjects/mockobjects-java/src/core/com/mockobjects/dynamic/InvocationMatcher.java?r1=1.3&r2=1.4

*there are lots of dependencies for mockobjects in gump
* Can you fix your program quickly ?

Thanks in advance.

Antoine Levy-Lambert

MockHttpServletRequest setupGetAttributeNames Mispelled

Mike Olson — Mon, 15 Dec 2003 16:46:07 -0000

On the MockHttpRequest, the method
setupExpectedAttribute is spelled
setupExpectedAttrubute. I'm assuming this is spelled
incorrect.

MockFileInputStream not platform independent

Gino Marckx — Wed, 10 Dec 2003 20:51:21 -0000

Because a FileInputStream needs a real file to be
instantiated, the corresponding mock object also needs such
a file. For this reason, a KNOWN_FILE static member is
used, it is specified as C:/autoexec.bat
It is obvious that this only works on Windows, resulting in a
FileNotFound exception. If this public static member would
have been changeable, no problem, but it happens to be
final.
A better approach is to create a temp file and make sure it
is deleted upon shutdown of the VM.

Mock.expect() can't handle null values for method parameters

Eugene Kuleshov — Wed, 12 Nov 2003 16:33:07 -0000

In mock interface I have method setAttribute(
name:String, value:String):void. So, I wrote the
following condition:

mockServletContext.expect( "setAttribute", new
ConstraintMatcher() {
public boolean matches( Object[] args) {
if( "myname".equals( args[ 0])) {
return true;
}
return false;
}
public Object[] getConstraints() {
return new Object[] {};
}
});

This code should handle any value. However if method is
called with null value I have an exception:

java.lang.NullPointerException
at
com.mockobjects.dynamic.DynamicUtil.join(DynamicUtil.java:118)
at
com.mockobjects.dynamic.DynamicUtil.methodToString(DynamicUtil.java:104)
at
com.mockobjects.dynamic.CallCollection.createUnexpectedCallError(CallCollection.java:11)
at com.mockobjects.dynamic.CallBag.call(CallBag.java:31)
at com.mockobjects.dynamic.Mock.invoke(Mock.java:88)
at $Proxy0.setAttribute(Unknown Source)
.....

Am I doing something wrong?