Question about ac_trie_findnext()

Kamiar Kanani — Wed, 13 Jan 2016 23:55:04 -0000

Yes, it is safe. Before stack is deallocated, a copy of sruct is made to the caller's memory space. Note that it does not return a pointer to that structure. It return the structure itself.

This is a thread safe implementation for that function, since each thread has its own stack. Because of this extra copy, it is a little bit slower than the _search() function. So it is recommended to use the search method.

Regards,

Question about ac_trie_findnext()

Andrew Stromnov — Tue, 12 Jan 2016 12:15:47 -0000

Is it safe to use ac_trie_findnext()?

ahocorasick.c: AC_MATCH_t allocated on stack at line 270 and returned as a result at line 280. But AFAIK result is undefined in that case because 'match' will be freed on function exit (due to stack nature).

Licence exception for PHP Extension

Dusan Klinec (ph4r05) — Thu, 10 Dec 2015 19:40:40 -0000

Thank you!
I will try to submit it to the PECL.

Regards,

Dusan Klinec

Licence exception for PHP Extension

Kamiar Kanani — Thu, 03 Dec 2015 13:49:15 -0000

Hi Dusan,

Thanks for your interest in using MultiFast. I am so glad that you found it useful and workable for your project. It seems that LGPLv3 is a little bit restrictive for some projects. For now, To solve your problem I would like you to provide you with the following:

HEREBY, IT IS DECLARED THAT THE MULTIFAST PROJECT
(HTTP://MULTIFAST.SOURCEFORGE.NET/) CAN BE USED UNDER THE PHP LICENSE 3.01 IN
THE PROJECTS HOSTED BY PHP PECL REPOSITORY (HTTPS://PECL.PHP.NET/).

KAMIAR KANANI
3-DECEMBER-2015

I hope that it solves your problem. Please let me know if you need a more formal declaration issued for the php.net community.

Regards

--
Kamiar

Licence exception for PHP Extension

Dusan Klinec (ph4r05) — Wed, 02 Dec 2015 13:21:45 -0000

Hello,

I am Dusan (ph4r05) Klinec, creator of Multifast wrapper for PHP, available here:
https://github.com/ph4r05/php_aho_corasick

Multifast is a great implementation of AhoCorasick pattern matching algorithm. I've been using pure PHP implementation of AhoCorasick but it was not as fast as I expected. Then I stumbled upon Multifast and decided to implement PHP Extension using Multifast in the background.

When implemented as a native extension for PHP it works a lot faster. I am not aware of any multiple pattern matching implementation in PHP that would be faster than my wrapper for Multifast.

To make it available to community, project is hosted on GitHub, users can compile it and use it.
In order to make it even simpler to use, it would be great to have this extension included in PHP PECL repository. (https://pecl.php.net/). Publishing to PECL would make extension more visible to users and much easier to install and use.

I reference you and your project in my PHP extension. Licenced as your project, under LGPLv3.
But unfortunatelly, PECL repository has a strict view on licensing of php extensions. Qouting:
"We strongly encourage contributors to choose the PHP License 3.01 for their extensions, in order to avoid possible troubles for end-users of the extension. Other solid options are BSD and Apache type licenses.
Note: wrappers for GPL (all versions) or LGPLv3 libraries will not be accepted. Wrappers for libraries licensed under LGPLv2 are however allowed while being discouraged.
"

So I would like to ask you to publish Multifast under LGPLv2+, so end user can decide whether he will use v2 or v3, as is usuall with GPL licences. Or can you give me license exception for this particular purpose? It would help a lot to spread your piece of work to more people.

I think this license change does not go against any LGPL philosophy. PHP extension is distributed and used in a binary form. PHP is using dynamic linking to load extension, which contains multifast. My wrapper is licensed in the same way as Multifast which is directly contained in the wrapper, available on GitHub with all changes made to Multifast available to the world. I will state your name and Multifast in the extension documentation.

Thanks for considering this to help spread our pieces of software.

Recent posts to Discussion

Question about ac_trie_findnext()

Question about ac_trie_findnext()

Licence exception for PHP Extension

Licence exception for PHP Extension

Licence exception for PHP Extension