https://sourceforge.net/p/nethogs/patches/2016-01-01T20:03:02.332000ZRecent changes to patches2016-01-01T20:03:02.332000Z2016-01-01T20:03:02.332000ZArnout Engelenhttps://sourceforge.net/u/raboofje/https://sourceforge.netb0b39360fd83e2c81fd9f88014b7574b3b544c1b

<div class="markdown_content"><p>Hello GArik,</p> <p>Sorry about not responding to this patch, I'll try and do better in the future. If you're still interested in working on this, could you present it as PR on the github project at <a href="https://github.com/raboof/notion?" rel="nofollow">https://github.com/raboof/notion?</a> Thanks!</p> <p>Kind regards,</p> <p>Arnout</p></div>

2016-01-01T20:01:29.726000Z2016-01-01T20:01:29.726000ZArnout Engelenhttps://sourceforge.net/u/raboofje/https://sourceforge.netfd40d05e104b75412288ab6cf79a785872c2e6e1

<div class="markdown_content"><ul> <li><strong>status</strong>: open --&gt; closed</li> <li><strong>Group</strong>: --&gt; Unstable (example)</li> </ul></div>

2016-01-01T20:00:04.529000Z2016-01-01T20:00:04.529000ZArnout Engelenhttps://sourceforge.net/u/raboofje/https://sourceforge.net325287049892538d131587ccd474641482fb93e4

<div class="markdown_content"><ul> <li><strong>status</strong>: pending --&gt; closed</li> </ul></div>

2013-05-12T20:17:41.219000Z2013-05-12T20:17:41.219000ZArnout Engelenhttps://sourceforge.net/u/raboofje/https://sourceforge.net290ae9047747ee834dc1c0b1020b902d61428c64

<div class="markdown_content"><ul> <li><strong>status</strong>: pending --&gt; closed</li> </ul></div>

2013-05-12T13:45:56.667000Z2013-05-12T13:45:56.667000ZArnout Engelenhttps://sourceforge.net/u/raboofje/https://sourceforge.netc82a12579726e3cd94fe0126b6b653384c4848e6

<div class="markdown_content"><p>It's kind of hard to see what exactly changed here, but it seems you:</p> <p>1) instead of BUFSIZ you're using a fixed value of 56. any reason for this?</p> <p>2) I was doing a usleep of 0.1ms when there were no packets to be read. You changed 2 things: changed it to 100ms and sleep every iteration.</p> <p>Indeed pcap will not lose packets, but it is also important that packets are handled quickly: nethogs looks at /proc/net/tcp to find out which process a packet belongs to, and if we wait too long, the connection might have disappeared from /proc/net/tcp. For this reason, I want to read packets as quickly as possible.</p> <p>3) you're not passing 'errbuf' to 'dp_open_live' anymore, instead allocating it on the stack. Why?</p> <p>4) you're not using pcap_open_live but instead pcap_create. why?</p></div>

2013-05-12T13:00:23.853000Z2013-05-12T13:00:23.853000ZArnout Engelenhttps://sourceforge.net/u/raboofje/https://sourceforge.netaedbe955ce225844da8920ad414a9b0c4f3fcc50

<div class="markdown_content"><ul> <li><strong>status</strong>: open --&gt; closed-accepted</li> <li><strong>Group</strong>: --&gt; Unstable (example)</li> </ul></div>

2013-05-12T12:54:27.091000Z2013-05-12T12:54:27.091000ZArnout Engelenhttps://sourceforge.net/u/raboofje/https://sourceforge.neta7c12a5708d5e4b775fb9a9ddd323773e84be0f7

<div class="markdown_content"><ul> <li><strong>status</strong>: open --&gt; closed-accepted</li> <li><strong>Group</strong>: --&gt; Unstable (example)</li> </ul></div>

2013-05-12T12:51:30.300000Z2013-05-12T12:51:30.300000ZArnout Engelenhttps://sourceforge.net/u/raboofje/https://sourceforge.net7aebd170ab4c2adbeb10b0aa28e54dc9ad527b97

<div class="markdown_content"><ul> <li><strong>status</strong>: open --&gt; closed-accepted</li> <li><strong>Group</strong>: --&gt; Unstable (example)</li> </ul></div>

2013-05-12T12:47:08.113000Z2013-05-12T12:47:08.113000ZArnout Engelenhttps://sourceforge.net/u/raboofje/https://sourceforge.net235db749c408d098b0466737ee2aba0a6331c5e1

<div class="markdown_content"><ul> <li><strong>status</strong>: open --&gt; pending</li> <li><strong>Group</strong>: --&gt; Unstable (example)</li> </ul></div>

2013-05-12T12:43:47.671000Z2013-05-12T12:43:47.671000ZArnout Engelenhttps://sourceforge.net/u/raboofje/https://sourceforge.nete5b66f8c747304509e8c920bd7df4f5d7891a934

<div class="markdown_content"><ul> <li><strong>status</strong>: open --&gt; pending</li> <li><strong>Group</strong>: --&gt; Unstable (example)</li> </ul></div>