Recent changes to patches

#7 cmake build system support

Arnout Engelen — Fri, 01 Jan 2016 20:03:02 -0000

Hello GArik,

Sorry about not responding to this patch, I'll try and do better in the future. If you're still interested in working on this, could you present it as PR on the github project at https://github.com/raboof/notion? Thanks!

Kind regards,

Arnout

#14 CPU usage improvement

Arnout Engelen — Fri, 01 Jan 2016 20:01:29 -0000

status: open --> closed
Group: --> Unstable (example)

#9 Scale to terminal size

Arnout Engelen — Fri, 01 Jan 2016 20:00:04 -0000

status: pending --> closed

#10 Hack for 32-bit pids

Arnout Engelen — Sun, 12 May 2013 20:17:41 -0000

status: pending --> closed

#14 CPU usage improvement

Arnout Engelen — Sun, 12 May 2013 13:45:56 -0000

It's kind of hard to see what exactly changed here, but it seems you:

1) instead of BUFSIZ you're using a fixed value of 56. any reason for this?

2) I was doing a usleep of 0.1ms when there were no packets to be read. You changed 2 things: changed it to 100ms and sleep every iteration.

Indeed pcap will not lose packets, but it is also important that packets are handled quickly: nethogs looks at /proc/net/tcp to find out which process a packet belongs to, and if we wait too long, the connection might have disappeared from /proc/net/tcp. For this reason, I want to read packets as quickly as possible.

3) you're not passing 'errbuf' to 'dp_open_live' anymore, instead allocating it on the stack. Why?

4) you're not using pcap_open_live but instead pcap_create. why?

#13 Dynamic default interface selection

Arnout Engelen — Sun, 12 May 2013 13:00:23 -0000

status: open --> closed-accepted
Group: --> Unstable (example)

#11 Makefile minor improvements (Wextra)

Arnout Engelen — Sun, 12 May 2013 12:54:27 -0000

status: open --> closed-accepted
Group: --> Unstable (example)

#12 Magic numbers replaced

Arnout Engelen — Sun, 12 May 2013 12:51:30 -0000

status: open --> closed-accepted
Group: --> Unstable (example)

#10 Hack for 32-bit pids

Arnout Engelen — Sun, 12 May 2013 12:47:08 -0000

status: open --> pending
Group: --> Unstable (example)

#9 Scale to terminal size

Arnout Engelen — Sun, 12 May 2013 12:43:47 -0000

status: open --> pending
Group: --> Unstable (example)