Recent changes to patches

php error in bug.php line 753

David Fore — Sat, 28 Nov 2009 21:18:39 -0000

I was getting a php error in bug.php line 753, so I added the isset()

$reporter = (isset($reporter) and is_numeric($reporter)) ? $reporter : $u;

Bogus Postgresql code (1.0.4)

Alexis Wilke — Mon, 03 Mar 2008 20:24:07 -0000

Hi guys,

There are a few bugs in the Postgresql code that make phpbt not very useful until fixed. Mainly missing spaces.

The GROUP BY requires all the fields that are defined in some way in the query. It's somewhat annoying and it may have been fixed in a newer version. But my 1 year old database is still requiring me to do that.

I'm attaching a patch. I may update my patch later if I find other problems.

Thank you.
Alexis W.
http://www.m2osw.com

After login, redirect to orignal URL (e.g. url from email)

Bryce Nesbitt — Sat, 08 Sep 2007 19:41:15 -0000

If passwords are on: clicking on a link in email leads you to the password page, then to the home page. With this patch you instead get directed to the original URL.

OS detection - complement of patch 1542005

Yep — Wed, 11 Oct 2006 10:21:41 -0000

The patch n°1542005 is correct to enable OS detection.

But there is still some problems for OS detection due
to data in database.
In phpt_os, the regex for Windows NT is wrong and
generate an error for php because there is an open
bracket without the closed one :
/Mozilla.*(Windows.*NT/

I attach mysql.in schema file with correct os regex
definition.

Furthermore, OS list is display when you add a bug
and when you query bugs. But OS must be active only
when you add a bug.
In functions.php lines 156 to 158, replace :
if ($selected == '' and isset($row['Regex']) and
preg_match($row['Regex'],$GLOBALS
['HTTP_USER_AGENT'])) {
$sel = ' selected';
by :
if (isset($_GET['op']) and $_GET['op']=='add' and
$selected == '' and isset($row['regex']) and
preg_match($row['regex'],$_SERVER
['HTTP_USER_AGENT'])) {
$sel = ' selected';

build_select does not select the operating system

Olivier Sannier — Thu, 17 Aug 2006 14:08:32 -0000

Hi,

build_select uses the regular expression for the "os"
table but does not use the correct casing for the name
of the column. Further to this, it uses $GLOBALS to get
the user agent string, but it's not in there, it's in
$_SERVER. I have thus fixed those issues and the
operating system is now automatically selected. Here is
the code (with a bit of context):

case 'os':
$rs = $db->query("select {$box}_id, {$box}_name,
regex from ".TBL_OS." where sort_order > 0 order by
sort_order");
while ($rs->fetchInto($row)) {
if ($selected == '' and isset($row['regex']) and
preg_match($row['regex'],
$_SERVER['HTTP_USER_AGENT'])) {
$sel = ' selected';
} elseif ($selected == $row[$box.'_id']) {
$sel = ' selected';

Hope this helps

Corrected bug page - $restricted_projects

berc — Mon, 01 May 2006 15:39:03 -0000

1. corrected bug in $restricted_projects cant be in
quotes (otherwise PHP resolve this as one value, not
as list)
2. added additional condition to query in combo of
users

Intuitive color display for Severity list

Louis-Eric Simard — Wed, 15 Mar 2006 22:20:19 -0000

While editing the Severity List, it is hard to visually
determine how each listing will eventually be painted
on screen. This simple change makes this
color-assignment process more immediately interactive.

attachement.php wrong filename

Sylvain Millard — Fri, 03 Feb 2006 11:14:45 -0000

Hello,

in attachement.php ( $Id: attachment.php,v 1.2
2005/12/19 12:52:43 cmoulard Exp $ ) there is a bug.

The upload is ok.

The download seems to be wrong. The attachement name is
wrong : it is the temporary file name.

Either, the sql scheme seems to be wrong : the size of
mime_type is only of 30 chars. Too short for
'application/vnd.oasis.opendocument.text' for example.

Here is my modification of attachement.php :

l171 :
header("Content-type: $mimetype");
$frontname = "attachement/".$_gv['attachid']."/";
$realfilename = substr($filename, strlen($frontname));
$realfilename = str_replace (" ", "_", $realfilename );
header('Content-Disposition: attachment; filename=' .
$realfilename);
@readfile($filename);
exit;

get_include_path requires PHP 4 >= 4.3.0, PHP 5

Genix — Tue, 06 Dec 2005 08:03:03 -0000

this patch allow to work with php4 < 4.3.0
see http://ru2.php.net/get_include_path

es-ES Translation for version 1.0.1

Bruno Suárez Laffargue — Sat, 19 Nov 2005 21:39:29 -0000

Correction of some spelling errors.
Correction of some sentences, adaptating them to
english style.