Recent changes to support-requests

Date parsing doesn't work if year is not present

2011-06-29T21:16:39Z

In the following form (from a SYSLOG event)
Jun 29 00:30:22

The code complains that [30] isn't a valid hour.

There are 2 possible ways to fix this, one is to make smarter use of the ':' and "force" it to an hour. The other is to assume no year if any of the following stuff is invalid for the type. However, 2 won't work if everything is valid.

Another way would be to add a config param for that but this kinda defeats the purpose for having the parsing be automatic.

Fooled in month detection

2010-10-14T19:30:53Z

When parse()-ing the string "Mark on October 14, 2010, 4:58 AM", the result is a March 14, 2010 date. Given that "Mark" is a full word, it seems the code is just checking the initial part for match against "Mar" as a month name for March, instead of checking the entire "Mark" word against the pattern.

Any chance to correct that?

Thanks

Add additional validation to date parsing

2010-07-31T16:23:45Z

In order to prevent dates like 2010-05-00, or 2010-00-25 additional validation code should be added to DateTime parse() method. Something like:

if (day < 1) {
throw new IllegalArgumentException("Invalid day :" + day);
}
if (month < 1) {
throw new IllegalArgumentException("Invalid month :" + month);
}
// Year can actually be BC and assumed negative, think about this one
if (year < 1) {
throw new IllegalArgumentException("Invalid year :" + year);
}
if (hour < 0 || hour >= 24) {
throw new IllegalArgumentException("Invalid hour :" + hour);
}
if (minute < 0 || minute >= 60) {
throw new IllegalArgumentException("Invalid minute :" + minute);
}
if (second < 0 || second >= 60) {
throw new IllegalArgumentException("Invalid second :" + second);
}
if (nanosecond < 0 || nanosecond >= 1000000000) {
throw new IllegalArgumentException("Invalid nanosecond :" + nanosecond);
}