Recent changes to bugs

Problem with Element.plain

Anonymous — Fri, 24 Feb 2012 12:31:48 -0000

When I disable 'pretty_xml' option, some nodes of the document came without their atrributes.
I believe it happen cause in 'send' method of 'SoapClient', if 'pretty_xml' isn't activated, Element.plain is used rather than Element.str.

Cache not thread-safe

John Nagle — Wed, 15 Sep 2010 18:34:02 -0000

The Factory for client objects has a static cache, but it is not protected by a lock. This is a race condition in threaded programs. See "sudsobject.py", line 92, class "Factory", function "subclass".

suds client throws base Exception()

JoNO — Sun, 30 May 2010 19:35:49 -0000

One example is in client.py:

if self.options.faults:
raise Exception((status, reason))

Instead it should rise transport.TransportError.

Other example:
raise Exception('(reply|fault) expected when msg=None')
One option would be to rise ValueError or a suds base exception.

Another one:
raise Exception, 'not implemented'
it should be NotImplementedError, "some text"

Either way the way exceptions are being thrown across the package should be revisited.