Recent changes to tickets

#2 Support igraph >= 0.10.0

2025-12-16T20:01:49.436000Z

This should be fixed today.

#4 Compilation failure against igraph 1.0.0

2025-12-16T20:01:29.717000Z

status: open --> closed
assigned_to: Philipp Klaus Krause

#4 Compilation failure against igraph 1.0.0

2025-10-30T11:19:20.669000Z

No surprise: the igraph 1.0 announcement explicitly states that it breaks the API.

I'll have to adapt (possibly checking the igraph version via a preprocessor macro, then calling the appropriate API).

Compilation failure against igraph 1.0.0

2025-10-30T10:32:28.629000Z

Hello,
Compilation aborts after the upgrade of igraph to 1.0.0:

/bin/sh ./libtool  --tag=CC    --mode=compile cc -DPACKAGE_NAME=\"rw\" -DPACKAGE_TARNAME=\"rw\" -DPACKAGE_VERSION=\"0.9\" -DPACKAGE_STRING=\"rw\ 0.9\" -DPACKAGE_BUGREPORT=\"philipp@informatik.uni-frankfurt.de\" -DPACKAGE_URL=\"\" -DPACKAGE=\"rw\" -DVERSION=\"0.9\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\"  -I.   -isystem /usr/local/include  --std=c99 -pedantic -O2 -pipe  -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -MT rw.lo -MD -MP -MF .deps/rw.Tpo -c -o rw.lo rw.c
libtool: compile:  cc -DPACKAGE_NAME=\"rw\" -DPACKAGE_TARNAME=\"rw\" -DPACKAGE_VERSION=\"0.9\" "-DPACKAGE_STRING=\"rw 0.9\"" -DPACKAGE_BUGREPORT=\"philipp@informatik.uni-frankfurt.de\" -DPACKAGE_URL=\"\" -DPACKAGE=\"rw\" -DVERSION=\"0.9\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -I. -isystem /usr/local/include --std=c99 -pedantic -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -MT rw.lo -MD -MP -MF .deps/rw.Tpo -c rw.c  -fPIC -DPIC -o .libs/rw.o
--- rw-simplerw.o ---
simplerw.c:124:70: error: too few arguments to function call, expected 3, have 2
  124 |         if(igraph_is_directed(&igraph) || igraph_is_simple(&igraph, &isimple) || !isimple)
      |                                           ~~~~~~~~~~~~~~~~                  ^
/usr/local/include/igraph/igraph_structural.h:56:30: note: 'igraph_is_simple' declared here
   56 | IGRAPH_EXPORT igraph_error_t igraph_is_simple(const igraph_t *graph, igraph_bool_t *res, igraph_bool_t directed);
      |                              ^                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Compilation failure against igraph 1.0.0

2025-10-30T10:32:28.629000Z

Ticket 4 has been modified: Compilation failure against igraph 1.0.0
Edited By: Philipp Klaus Krause (spth)
Status updated: 'open' => 'closed'
Owner updated: None => 'spth'

Provide pkg-config file

2024-12-01T04:17:09.688000Z

It would be nice to distribute a pkg-config file so that the library can be found more easily on the system by other programs/libraries.

#2 Support igraph >= 0.10.0

2022-09-16T07:23:56.856000Z

igraph maintainer here.

Yes, this patch will fix compilation and will restore the old behaviour. The value chosen for the loops parameter will only make a difference if the graph has self-loops (i.e. it is non-simple), so any choice is fine here.

To find out how to update code for igraph 0.10, your first stop should be the changelog, which should list all breaking changes. If anything is missing, let us know and we'll add it. https://github.com/igraph/igraph/blob/master/CHANGELOG.md

I noticed that this program attempts to check error codes returned by igraph functions. However, the default behaviour on error is to abort(), so there is no point in doing this unless the error handler is changed to something else.

Should the maintainer want to convert this code into an igraph function and include it in igraph itself, the contribution would be welcome. Just let us know.

#2 Support igraph >= 0.10.0

2022-09-11T10:44:41.247000Z

So looking at the relevant changes on igraph:

I think the following change should do the same behavior as before:

--- rw-0.9/simplerw.c.newigraph 2017-02-14 00:20:35.000000000 +0900
+++ rw-0.9/simplerw.c   2022-09-11 19:39:47.033917305 +0900
@@ -134,7 +134,11 @@ int read_graph(const char *format, const
        igraph_destroy(&igraph);
        return(-1);
    }
+#if (IGRAPH_VERSION_MAJOR >= 1) || ((IGRAPH_VERSION_MAJOR == 0) && (IGRAPH_VERSION_MINOR >= 10))
+   igraph_get_adjacency(&igraph, &imatrix, IGRAPH_GET_ADJACENCY_BOTH, NULL, IGRAPH_LOOPS_ONCE);
+#else
    igraph_get_adjacency(&igraph, &imatrix, IGRAPH_GET_ADJACENCY_BOTH, 0);
+#endif
    igraph_destroy(&igraph);
    if(igraph_matrix_nrow(&imatrix) > MAX_VERTICES)
    {

Support igraph >= 0.10.0

2022-09-07T14:31:09.080000Z

See attached build log

#1 Fix shared library build on Cygwin

2020-09-14T06:42:14.486000Z

Thanks for noticing the issue. Since rw is not downloaded often, I just replaced the previous release tarball with the fixed version.