Recent changes to bugs

mkroutercfg creates xml file with errors

2003-06-03T02:40:04Z

Running ./bin/compilexml --verbose generates the
following errors. Errors seem to be related to having the
following characters in the value= fields ( ) < >.
The Location: and City: fields also seem to have the
same limitations.

[02-Jun-2003 22:23:39*] Failed to parse /usr/local/rrfw-
0.0/share/rrfw/xmlconfig/gorddd.xml: '/usr/local/rrfw-
0.0/share/rrfw/xmlconfig/gorddd.xml:65: error: AttValue: '
expected
value="3Com 3C905TX-based Ethernet
Adapter (Generic)
^
/usr/local/rrfw-0.0/share/rrfw/xmlconfig/gorddd.xml:65:
error: attributes construct error
value="3Com 3C905TX-based Ethernet
Adapter (Generic)
^
/usr/local/rrfw-0.0/share/rrfw/xmlconfig/gorddd.xml:65:
error: Couldn't find end of Start Tag param line 64
value="3Com 3C905TX-based Ethernet
Adapter (Generic)
^
/usr/local/rrfw-0.0/share/rrfw/xmlconfig/gorddd.xml:65:
error: Premature end of data in tag subtree line 63
value="3Com 3C905TX-based Ethernet
Adapter (Generic)
^
/usr/local/rrfw-0.0/share/rrfw/xmlconfig/gorddd.xml:65:
error: Premature end of data in tag subtree line 51
value="3Com 3C905TX-based Ethernet
Adapter (Generic)
^
/usr/local/rrfw-0.0/share/rrfw/xmlconfig/gorddd.xml:65:
error: Premature end of data in tag subtree line 41
value="3Com 3C905TX-based Ethernet
Adapter (Generic)
^
/usr/local/rrfw-0.0/share/rrfw/xmlconfig/gorddd.xml:65:
error: Premature end of data in tag subtree line 39
value="3Com 3C905TX-based Ethernet
Adapter (Generic)
^
/usr/local/rrfw-0.0/share/rrfw/xmlconfig/gorddd.xml:65:
error: Premature end of data in tag datasources line 37
value="3Com 3C905TX-based Ethernet
Adapter (Generic)
^
/usr/local/rrfw-0.0/share/rrfw/xmlconfig/gorddd.xml:65:
error: Premature end of data in tag configuration line 29
value="3Com 3C905TX-based Ethernet
Adapter (Generic)
^
' at /usr/local/lib/perl/5.8.0/XML/LibXML.pm line 405.
at /usr/local/rrfw-
0.0/lib/RRFW/ConfigTree/XMLCompiler.pm line 67

[02-Jun-2003 22:23:39*] /usr/local/rrfw-
0.0/share/rrfw/xmlconfig/gorddd.xml compiled with errors

render not reentrant

2003-05-10T16:28:40Z

while rendering HTML pages:

url-variables like NOW, TZ etc are lost in all links which
appear after a rrprint item.

The problems is that Render.pm. is not reentrant. -> the
options are deleted at the end of render.

A quick and simple fix is to make rrprint read like this:

sub rrPrint
{
my $self = shift;
my $token = shift;
my $view = shift;

my @ret = ();
my %saveOptions = %{$self->{'options'}};
my($fname, $mimetype) = $self->render($token,
$view);
%{$self->{'options'}} = %saveOptions;

.
.
.

the long fix .... :-)

Regards
Christian

data-dir defaults are not consistent

2002-10-01T18:44:54Z

Hey there. Just tried out version 0.7 and I have these
suggestions:

Make the default data-dir names agree. I found three
variations.

./bin/mkroutercfg
/var/snmpcollector

./xmlconfig/snmp-collect.xml
/usr/local/rrfw-0.0/var/snmpcollect

./xmlconfig/snmp-defs.xml
/var/snmpcollect

Also, put in the instructions that you need to create
the data-dir
manually, or else add code that creates automatically.

Finally, if possible, add code to grapher.cgi that
catches misconfiguration errors and reports them in the
returned html.

For example, this is one of the error messages in my
/var/log/httpd/error_log file that resulted when I had
not yet created the snmpcollect directory by hand. The
output of grapher.cgi, however, just shows some broken
links to PNG files as a clue that something is wrong.

[30-Sep-2002 11:59:42 ] RRDs::graph arguments: --width
500 --height 250 --end now --start -24hours --img
format=PNG LINE2:A#0000FF
Use of uninitialized value in subroutine entry at
/usr/local/rrfw-0.0/lib/RRFW/Renderer.pm line 642.

Thanks.