Recent changes to patches

#20 Install PySAGA relative to install prefix

Rainer Hurling — Fri, 22 Dec 2023 11:36:37 -0000

status: open --> closed

#20 Install PySAGA relative to install prefix

Manfed Egger — Mon, 18 Dec 2023 11:49:49 -0000

Hi Rainer!

the last days I had time to build SAGA from git with your patch included. There were no problems at all. In both cases (rpmbuild and development environment) the PySAGA package installed correctly. As far as I'm concerned, this ticked can be closed. Thank you!

Regards, Manfred

#20 Install PySAGA relative to install prefix

Manfed Egger — Mon, 11 Dec 2023 19:21:25 -0000

Hello Rainer,

thank you very much for all you work regarding this patch and even reaching out to the core team to get it integrated! Interesting to see how cmake seems to handle variables on FreeBSD compared to linux. I am going to do test builds from git the following days.

Thank you again!
Kind regards,
Manfred

#20 Install PySAGA relative to install prefix

Rainer Hurling — Mon, 11 Dec 2023 18:14:00 -0000

Hi Manfred,
Sorry for the late reponse.

I have tried your patch on FreeBSD (a Unix derivative, not Linux). FreeBSD differs mainly due to partly different path conventions. In fact, the CMAKE system also seems to use some variables differently or not at all compared to Linux.

First, I checked whether the patch can be applied and what the result looks like. Since the CMakeLists.txt has been updated in the meantime, I had to make slight adjustments. Then I started testing :)

The standard case under FreeBSD is to install the existing package (under system paths) and use it. Therefore, I first checked whether the system-wide installation still works as usual with the patch. This is definitely the case :)

I then added the patch to a fresh Git repository in the home directory and then prepared the build and installation under user rights using cmake-gui. After that I built with 'make'. This also worked well. However, the subsequent 'make install' aborted with the following error message:

Install the project...
-- Install configuration: "Release"
-- Installing: /usr/local/share/saga/toolchains
CMake Error at /home/rhurlin/git/saga-gis-code/build/src/accessories/cmake_install.cmake:41 (file):
  file INSTALL cannot make directory "/usr/local/share/saga/toolchains": No
  such file or directory.
Call Stack (most recent call first):
  /home/rhurlin/git/saga-gis-code/build/src/cmake_install.cmake:42 (include)
  cmake_install.cmake:42 (include)

It turned out that I also had to specify an installation path in the user area. With CMAKE_INSTALL_PREFIX=./saga-9.3 in my case, the installation worked as expected.

After consulting with the SAGA core team, I committed the customized version of the patch, see 1010ea9d4. Many thanks for the patch!

Install PySAGA relative to install prefix

Manfed Egger — Tue, 28 Nov 2023 21:09:32 -0000

Dear SAGA Team!

Currently, the PySAGA package is installed to the Python_SITEARCH directory (e.g. /usr/lib64/python3.12/site-packages/). This normally resides in /usr/where a non-privileged user has no write access. Unfortunately, it is further not possible to change the installation directory during the installation process at all.

The main objective is to make the install path relative to a possibly specified prefix and also to follow the python directory conventions. This would non-privileged users allow installation of the PySAGA package, e.g. for development or testing.

The attached patch contains changes to the saga_api_python cmake routine: the new install path is now derived from the CMAKE_INSTALL_LIBDIR (e.g. lib64, which is relative to the given PREFIX). The rest of the path follows the directory naming for python site-packages directories. Therefore it is compatible with Linux system standards.

The changes are not tested completely -- especially on other systems. As far as I can tell, they seem to work in both cases: with specified prefix (testing) and without (rpmbuild environment). Please have a look at the provided file.

Install PySAGA relative to install prefix

Manfed Egger — Tue, 28 Nov 2023 21:09:32 -0000

Ticket 20 has been modified: Install PySAGA relative to install prefix
Edited By: Rainer Hurling (rhurlin)
Status updated: 'open' => 'closed'

#19 Update deprecated include path for Qhull

Volker Wichmann — Tue, 14 Apr 2020 07:57:17 -0000

status: open --> closed

#19 Update deprecated include path for Qhull

Timo Röhling — Tue, 14 Apr 2020 07:53:04 -0000

Tried it on my machine and looks good to me!
Thank you for the quick response!

Timo

#19 Update deprecated include path for Qhull

Volker Wichmann — Mon, 13 Apr 2020 14:14:17 -0000

Hi Timo,

I've just committed a fix

https://sourceforge.net/p/saga-gis/code/ci/6bd7b8a81c2ea1af1cef4a156c9108d48f43491b/

with a slighty different approach. Could you please check if this works for you (as I only have the old library available here)?

Thanks,
Volker

#19 Update deprecated include path for Qhull

Volker Wichmann — Sun, 12 Apr 2020 12:13:02 -0000

Perfect! I will implement this within the next days,

thanks again!
Volker