Activity for Sqrat

Patrix9999 created merge request #27 on Code

Patrix9999 — Tue, 02 Jan 2024 01:06:46 -0000

Added Sqrat::ClassType::IsValidInstance static method:

Wizzard modified a comment on merge request #26

Wizzard — Wed, 31 May 2023 19:17:04 -0000

Just to clarify: PushVarR exists to force something to be a reference even when its not, while PushVar can do copies and references

Wizzard posted a comment on merge request #26

Wizzard — Wed, 31 May 2023 19:15:08 -0000

Just to clarify: PushVarR exists to force something to be a reference even when its not

Wizzard updated merge request #26

Wizzard — Wed, 31 May 2023 19:12:36 -0000

Replaced Sqrat::PushVar to Sqrat::PushVarR in Sqrat::Function Evaluate/Execute methods.

Wizzard posted a comment on merge request #26

Wizzard — Wed, 31 May 2023 19:11:17 -0000

Glad it works!

Patrix9999 posted a comment on merge request #26

Patrix9999 — Wed, 31 May 2023 19:09:47 -0000

It works, i think it's safe to say that closing this merge request is the best approach, because this might break too many things.

Patrix9999 posted a comment on merge request #26

Patrix9999 — Wed, 31 May 2023 19:03:57 -0000

I'll try this approach and let you know about the results.

Patrix9999 modified a comment on merge request #26

Patrix9999 — Wed, 31 May 2023 19:03:09 -0000

Patrix9999 posted a comment on merge request #26

Patrix9999 — Wed, 31 May 2023 19:02:41 -0000

About that: ///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////// /// Called by Sqrat::PushVar to put a class object on the stack /// /// \param vm Target VM /// \param value Value to push on to the VM's stack /// ///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////// static void push(HSQUIRRELVM vm, const T& val) { if (ClassType::hasClassData(vm)) ClassType::PushInstanceCopy(vm,...

Patrix9999 posted a comment on merge request #26

Patrix9999 — Wed, 31 May 2023 19:02:39 -0000

Wizzard modified a comment on merge request #26

Wizzard — Wed, 31 May 2023 17:45:34 -0000

Make sure you are calling Evaluate/Execute with the correct template typenames. Do not let the compiler guess the argument types for you

Wizzard posted a comment on merge request #26

Wizzard — Wed, 31 May 2023 17:42:48 -0000

Make sure you are calling Evaluate/Execute with the correct templates. Do not let the compiler guess them for you

Wizzard posted a comment on merge request #26

Wizzard — Wed, 31 May 2023 17:38:29 -0000

If the current way doesn't work (verifiable using a debugger and some breakpoints to see if its triggering the correct code) and can't be made to work, then I'd be willing to accept this change as long as it doesn't have unforeseen consequences. It looks like it would force everything to be references always, which would definitely cause issues.

Wizzard posted a comment on merge request #26

Wizzard — Wed, 31 May 2023 17:35:05 -0000

Not that it was thoroughly tested, but notice how in sqratTypes.h there are overloads for references, pointers, and even SharedPtr that all use PushInstance rather than PushInstanceCopy. If the template magic is happening correctly, then this should be happening already.

Patrix9999 created merge request #26 on Code

Patrix9999 — Wed, 31 May 2023 17:23:18 -0000

Replaced Sqrat::PushVar to Sqrat::PushVarR in Sqrat::Function Evaluate/Execute methods.

Wizzard merged merge request #25 on Code

Wizzard — Sun, 16 Apr 2023 20:45:29 -0000

Fixed sqrat not being completely updated to squirrel 3.2

Patrix9999 created merge request #25 on Code

Patrix9999 — Sun, 16 Apr 2023 20:43:31 -0000

Fixed sqrat not being completely updated to squirrel 3.2

Wizzard merged merge request #24 on Code

Wizzard — Thu, 06 Apr 2023 22:39:58 -0000

Updated sqrat for squirrel 3.2 version

Patrix9999 created merge request #24 on Code

Patrix9999 — Thu, 06 Apr 2023 22:14:29 -0000

Updated sqrat for squirrel 3.2 version

Wizzard merged merge request #23

Wizzard — Mon, 05 Sep 2022 14:52:11 -0000

.SquirrelProp method for Sqrat::Class

Patrix9999 posted a comment on merge request #23

Patrix9999 — Mon, 05 Sep 2022 14:05:06 -0000

The comment was corrected.

Patrix9999 modified a comment on merge request #23

Patrix9999 — Mon, 05 Sep 2022 14:02:36 -0000

These method(s) are useful when you don't want to add _get & _set just to add raw closures as getter & setter. They can be utilized to make a property that can return multiple data types.

Wizzard posted a comment on merge request #23

Wizzard — Mon, 05 Sep 2022 01:06:20 -0000

The comment on the one with a getter+setter says it's read-only, but otherwise looks good

Patrix9999 posted a comment on merge request #23

Patrix9999 — Sun, 04 Sep 2022 13:29:31 -0000

Thise method(s) are useful when you don't want to add _get & _set just to add raw closures as getter & setter. They can be utilized to make a property that can return multiple data types.

Patrix9999 created merge request #23

Patrix9999 — Thu, 01 Sep 2022 17:14:45 -0000

.SquirrelProp method for Sqrat::Class

Wizzard merged merge request #22

Wizzard — Mon, 11 Jul 2022 04:25:34 -0000

Arguments validation for .SquirrelFunc method in Sqrat::Array & Sqrat::Class

Patrix9999 created merge request #22

Patrix9999 — Mon, 11 Jul 2022 04:11:25 -0000

Arguments validation for .SquirrelFunc method in Sqrat::Array & Sqrat::Class

Wizzard merged merge request #21

Wizzard — Mon, 11 Jul 2022 03:58:17 -0000

Added possibility to bind temporary cpp object

Patrix9999 created merge request #21

Patrix9999 — Mon, 11 Jul 2022 03:57:19 -0000

Added possibility to bind temporary cpp object

Wizzard merged merge request #20

Wizzard — Mon, 11 Jul 2022 03:28:10 -0000

added missing sq_pop, added #undef GetObject

Patrix9999 posted a comment on merge request #20

Patrix9999 — Mon, 11 Jul 2022 03:22:33 -0000

Now :)

Wizzard posted a comment on merge request #20

Wizzard — Mon, 11 Jul 2022 03:19:12 -0000

The merge request still has zero commits. Let me know when it has content

Patrix9999 created merge request #20

Patrix9999 — Mon, 11 Jul 2022 03:17:57 -0000

added missing sq_pop, added #undef GetObject

Wizzard merged merge request #19

Wizzard — Mon, 11 Jul 2022 02:35:06 -0000

Added Sqrat::Var support

Patrix9999 posted a comment on merge request #19

Patrix9999 — Mon, 11 Jul 2022 02:34:21 -0000

Done

Wizzard posted a comment on merge request #19

Wizzard — Mon, 11 Jul 2022 01:47:01 -0000

Tabs to spaces and should be good :)

Patrix9999 posted a comment on merge request #19

Patrix9999 — Mon, 11 Jul 2022 01:45:14 -0000

Done.

Patrix9999 modified a comment on merge request #19

Patrix9999 — Mon, 11 Jul 2022 00:58:16 -0000

Similarly, maybe moving Sqrat::Var would also be good idea to this file? What do you think?

Patrix9999 posted a comment on merge request #19

Patrix9999 — Mon, 11 Jul 2022 00:57:28 -0000

Ok, i'll make some adjustments.

Patrix9999 posted a comment on merge request #19

Patrix9999 — Mon, 11 Jul 2022 00:57:07 -0000

Similarly, maybe moving Sqrat::Var would also be good idea to this file? What do you think?

Wizzard posted a comment on merge request #19

Wizzard — Mon, 11 Jul 2022 00:54:55 -0000

That would be more fitting. It'd also make sense to put sqratNull.h in there

Patrix9999 modified a comment on merge request #19

Patrix9999 — Mon, 11 Jul 2022 00:47:43 -0000

No problem, i'll correct it, one question, maybe it would be more fitting to move the code into sqratTypes.h file?

Patrix9999 posted a comment on merge request #19

Patrix9999 — Mon, 11 Jul 2022 00:43:56 -0000

No problem, i'll correct it, one question, maybe it would be more fitting to move it into sqratTypes.h file?

Wizzard posted a comment on merge request #19

Wizzard — Mon, 11 Jul 2022 00:26:41 -0000

Needs the tabs to be spaces so it matches the current code but then can be merged

Patrix9999 created merge request #19

Patrix9999 — Mon, 11 Jul 2022 00:14:48 -0000

Added Sqrat::Var support

Wizzard merged merge request #18

Wizzard — Wed, 06 Jul 2022 23:06:07 -0000

Fixed possible compiler error in SqratBytecode.h

Patrix9999 created merge request #18

Patrix9999 — Wed, 06 Jul 2022 23:04:27 -0000

Fixed possible compiler error in SqratBytecode.h

Wizzard merged merge request #17

Wizzard — Wed, 06 Jul 2022 19:35:17 -0000

Add null support

Paul C created merge request #17

Paul C — Wed, 06 Jul 2022 19:31:46 -0000

Add null support

Wizzard merged merge request #16

Wizzard — Sun, 03 Jul 2022 01:47:14 -0000

Arguments validation for .SquirrelFunc method

Patrix9999 created merge request #16

Patrix9999 — Sat, 02 Jul 2022 21:20:06 -0000

Arguments validation for .SquirrelFunc method

Wizzard modified a comment on ticket #107

Wizzard — Fri, 26 Nov 2021 19:22:47 -0000

Glad you got it worked out! The way I chose to do errors is pretty weird, but I was trying to make it backwards compatible because Sqrat started off with no error checking at all! (it actually works quite a bit faster too when you compile with error checking off)

Wizzard modified ticket #107

Wizzard — Fri, 26 Nov 2021 19:19:23 -0000

Different behavior if calling GetValue before SetValue on table

Wizzard posted a comment on ticket #107

Wizzard — Fri, 26 Nov 2021 19:19:23 -0000

Glad you got it worked out! The way I chose to do errors is pretty weird, but I was trying to make it backwards compatible because Sqrat started off with no error checking at all!

Omega posted a comment on ticket #107

Omega — Fri, 26 Nov 2021 15:50:29 -0000

Hi Wizzard, it looks like I didn't read the API documentation very well. It's setting the error in the VM and it needs to be cleared. Clearing the error between the GetValue and SetValue fixed it: Sqrat::Error::Clear(vm); It's a bit unfortunate you have to know to do this but no change to the code should be needed.

Omega posted a comment on ticket #107

Omega — Fri, 26 Nov 2021 13:56:48 -0000

Hi Wizzard. I was able to isolate the problem in the code I was writing to this behavior in Sqrat/squirrel. I haven't taken the time yet to find and fix the issue. I was hoping you had some idea what might be going wrong. I can keep looking at it if you like. Below is the output I got from the test case. In both cases it will call the SetValue but only case A returns the table in the last GetValue call (the one after SetValue). Test Case A =========== Set Get OK Test Case B =========== Set Get F...

Wizzard modified ticket #107

Wizzard — Fri, 26 Nov 2021 07:00:54 -0000

Different behavior if calling GetValue before SetValue on table

Wizzard posted a comment on ticket #107

Wizzard — Fri, 26 Nov 2021 07:00:36 -0000

Can you tell me the output of your example? I'm willing to accept a pull request submitted by you that fixes this behavior and try to help you work through it if needed.

Omega created ticket #107

Omega — Thu, 25 Nov 2021 18:18:53 -0000

Different behavior if calling GetValue before SetValue on table

Wizzard modified ticket #106

Wizzard — Thu, 22 Apr 2021 19:43:12 -0000

HSQAPI and typeof (compile error)

Wizzard merged merge request #15

Wizzard — Thu, 22 Apr 2021 19:42:41 -0000

Fix compile error for gcc

Wizzard posted a comment on ticket #106

Wizzard — Thu, 22 Apr 2021 19:42:01 -0000

type_of should be fine

Patrix9999 created merge request #15

Patrix9999 — Thu, 22 Apr 2021 14:06:47 -0000

Fix compile error for gcc

Patrix9999 posted a comment on ticket #106

Patrix9999 — Thu, 22 Apr 2021 13:47:58 -0000

Propably the best name for this function would be: type_of. It kinda breaks the naming rule, but it's the most elegant equivalent that i thought of.

Patrix9999 posted a comment on merge request #14

Patrix9999 — Thu, 22 Apr 2021 11:30:27 -0000

I've discovered a new issue with changes made in this MR. https://sourceforge.net/p/scrat/sqrat/106/ Please, give me some feedback.

Patrix9999 created ticket #106

Patrix9999 — Thu, 22 Apr 2021 11:29:10 -0000

HSQAPI and typeof (compile error)

Wizzard modified ticket #105

Wizzard — Sun, 11 Apr 2021 23:30:36 -0000

Sqrat::Function fails to release env ref when the obj closure is null

Wizzard posted a comment on ticket #105

Wizzard — Sun, 11 Apr 2021 23:30:21 -0000

I think you should pass valid functions/closures to Sqrat::Function instead of null. I remember trying to look through this when it was first posted to figure out what the exact behavior should be but getting sidetracked. I'm going to close this for now, but if the behavior could be made more convenient then feel free to submit a pull request with some changes!

Wizzard posted a comment on merge request #14

Wizzard — Sun, 11 Apr 2021 23:22:43 -0000

I went ahead and merged this. Hopefully incompatibilities are easily resolved!

Wizzard merged merge request #14

Wizzard — Sun, 11 Apr 2021 23:22:10 -0000

Added missing function in HSQAPI struct

Patrix9999 created merge request #14

Patrix9999 — Sun, 11 Apr 2021 21:49:01 -0000

Added missing function in HSQAPI struct

shatteredmoon created ticket #105

shatteredmoon — Sat, 19 Dec 2020 16:53:34 -0000

Sqrat::Function fails to release env ref when the obj closure is null

Wizzard modified ticket #103

Wizzard — Mon, 09 Nov 2020 01:27:24 -0000

Function::Evaluate doesn't handle native closures correctly when SCRAT_NO_ERROR_CHECKING is undefined

Wizzard posted a comment on ticket #103

Wizzard — Mon, 09 Nov 2020 01:27:24 -0000

Fixed by https://sourceforge.net/p/scrat/code/ci/6758c0010cdcabab0bcc033f64a4d01d7ec3a9a9/

Wizzard merged merge request #13

Wizzard — Mon, 09 Nov 2020 01:25:57 -0000

Pull request for Issue #103: Function::Evaluate doesn't handle native closures correctly when SCRAT_NO_ERROR_CHECKING is undefined

shatteredmoon created merge request #13

shatteredmoon — Sat, 07 Nov 2020 23:41:32 -0000

Pull request for Issue #103: Function::Evaluate doesn't handle native closures correctly when SCRAT_NO_ERROR_CHECKING is undefined

Wizzard modified ticket #104

Wizzard — Sat, 07 Nov 2020 03:13:33 -0000

Setting an object equal to itself yields unexpected results

Wizzard posted a comment on ticket #104

Wizzard — Sat, 07 Nov 2020 03:13:33 -0000

Fixed in https://sourceforge.net/p/scrat/code/ci/36392c35317708a3616f24f6742d163002b8ee7a/

Wizzard merged merge request #12

Wizzard — Sat, 07 Nov 2020 03:12:48 -0000

Pull request for Issue #104 fix

shatteredmoon created merge request #12

shatteredmoon — Sat, 07 Nov 2020 00:34:50 -0000

Pull request for Issue #104 fix

shatteredmoon modified a comment on ticket #104

shatteredmoon — Fri, 06 Nov 2020 21:25:18 -0000

Sorry, it's a bit more complicated than that: error C2678: binary '!=': no operator found which takes a left-hand operand of type 'HSQOBJECT' (or there is no acceptable conversion)

shatteredmoon posted a comment on ticket #104

shatteredmoon — Fri, 06 Nov 2020 21:24:48 -0000

Yes, this does the trick, thanks!

shatteredmoon modified a comment on ticket #104

shatteredmoon — Fri, 06 Nov 2020 21:17:51 -0000

Nevermind, just saw your reply

shatteredmoon posted a comment on ticket #104

shatteredmoon — Fri, 06 Nov 2020 21:17:13 -0000

This works, but could probably be done better. I'm having to use DefaultVM::Get() because in my project I hit various points where either the left hand object has a null vm or the right hand object has a null vm, and either case will crash. Object& operator=(const Object& so) { if(*this != so) { if(release) { Release(); } vm = so.vm; obj = so.obj; sq_addref(vm, &GetObject()); } return *this; } bool operator!= ( const Object& so ) const { return !( *this == so ); } bool operator== ( const Object&...

Wizzard posted a comment on ticket #104

Wizzard — Fri, 06 Nov 2020 20:17:39 -0000

I mistook HSQOBJECT to by a typedef to a pointer. As long as every Sqrat::Object has its own unique HSQOBJECT, the following will work as far as I can tell. Object& operator=(const Object& so) { if(this != &so) { if(release) { Release(); } vm = so.vm; obj = so.obj; sq_addref(vm, &GetObject()); } return *this; }

shatteredmoon posted a comment on ticket #104

shatteredmoon — Fri, 06 Nov 2020 20:06:11 -0000

Sorry, it's a bit more complicated than that: error C2678: binary '!=': no operator found which takes a left-hand operand of type 'HSQOBJECT' (or there is no acceptable conversion) SqPlus uses this for operator== bool SquirrelObject::operator == (const SquirrelObject &o) { bool cmp = false; HSQUIRRELVM v = SquirrelVM::GetVMPtr(); int oldtop = (int)sq_gettop(v); sq_pushobject(v, GetObjectHandle()); sq_pushobject(v, o.GetObjectHandle()); if(sq_cmp(v) == 0) cmp = true; sq_settop(v, oldtop); return cmp;...

Wizzard posted a comment on ticket #104

Wizzard — Fri, 06 Nov 2020 05:46:02 -0000

If you could check if that works and do a pull request it'd be appreciated!

Wizzard posted a comment on ticket #104

Wizzard — Fri, 06 Nov 2020 05:45:32 -0000

The sq_resetobject call probably needs to stay immediately after the sq_release call (problems were introduced by not following this convention in other places before), and so the issue should be fixed by checking if the object is the same. I also took the liberty of removing the release = so.release part because it felt correct to, but that might be wrong. Object& operator=(const Object& so) { if(obj != so.obj) { if(release) { Release(); } vm = so.vm; obj = so.obj; sq_addref(vm, &GetObject()); }...

Wizzard posted a comment on ticket #103

Wizzard — Fri, 06 Nov 2020 05:24:26 -0000

if (SQ_SUCCEEDED(sq_getclosureinfo(vm, -2, &nparams, &nfreevars)) && (nparams != 1) && (nparams != 0)) {

Wizzard posted a comment on ticket #103

Wizzard — Fri, 06 Nov 2020 05:23:03 -0000

This is definitely an issue with Sqrat. You're not really supposed to call sq_getclosureinfo on a native closure. The most correct thing to do would be to ignore this check if it's a native closure. However, it might also suffice just to add a nparams != 0 check to all the Evaluate functions. I'll accept a pull request if you add the checks in and can verify it fixes the issue.

shatteredmoon posted a comment on ticket #104

shatteredmoon — Fri, 06 Nov 2020 04:33:06 -0000

Sorry, meant to say "or the intrinsic sq_resetobject should be rethought."

shatteredmoon created ticket #104

shatteredmoon — Fri, 06 Nov 2020 04:28:54 -0000

Setting an object equal to itself yields unexpected results

shatteredmoon created ticket #103

shatteredmoon — Mon, 02 Nov 2020 03:37:30 -0000

Function::Evaluate doesn't handle native closures correctly when SCRAT_NO_ERROR_CHECKING is undefined

Wizzard posted a comment on ticket #102

Wizzard — Mon, 05 Oct 2020 04:58:29 -0000

If you're able to submit a pull request that fixes these compiler-specific warnings without changing any functionality, I'll accept it.

shatteredmoon created ticket #102

shatteredmoon — Sat, 03 Oct 2020 23:52:02 -0000

Binding a member float var produces verbose compiler warnings in MSVC 2017

Wizzard modified ticket #101

Wizzard — Fri, 05 Jul 2019 15:53:19 -0000

Missing sq->getfloat pointer assignment in sqratimport.cpp

Wizzard posted a comment on ticket #101

Wizzard — Fri, 05 Jul 2019 15:53:19 -0000

Merged fix by Patrix

Wizzard merged merge request #11

Wizzard — Fri, 05 Jul 2019 15:44:37 -0000

#101 Fix (sq->getfloat)

Patrix9999 created merge request #11

Patrix9999 — Fri, 05 Jul 2019 08:48:39 -0000

#101 Fix (sq->getfloat)

Wizzard modified ticket #101

Wizzard — Mon, 25 Mar 2019 06:23:10 -0000

Missing sq->getfloat pointer assignment in sqratimport.cpp