Fixes for compiling with newer compilers e.g. clang-15

Florian Weimer — Thu, 13 Apr 2023 09:04:52 -0000

Don't you need #include <stdlib.h> as well, for exit?

Fixes for compiling with newer compilers e.g. clang-15

Khem Raj — Mon, 15 Aug 2022 20:14:37 -0000

While using newer llvm/clang we encountered some compiler errors about implicit function declarations and return type.

setserial.c:639:2: error: call to undeclared function 'close'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declarat
ion]
close(fd);
^
setserial.c:718:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
main(int argc, char **argv)
^
int
setserial.c:728:14: error: call to undeclared function 'getopt'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declar
ation]
while ((c = getopt(argc, argv, "abgGqvVWz")) != EOF) {
^

Attached patch fixes it. Please apply if you find it ok.

setserial does not use appropriate exit values

Rob Urban — Thu, 26 Jan 2017 12:11:44 -0000

setserial (v2.17) returns an exit value of 0 for two error cases (and maybe all?)

permission denied:

 setserial /dev/ttyS18; echo $?
/dev/ttyS18: Permission denied
0

non-existent device:

# setserial /dev/ttyS50; echo $?
/dev/ttyS50: No such file or directory
0

should be fixed, eh?
rob

Recent posts to Help

Fixes for compiling with newer compilers e.g. clang-15

Fixes for compiling with newer compilers e.g. clang-15

setserial does not use appropriate exit values