Recent changes to bugs

404 Redirect fixes

Tristan Marlow — Mon, 18 Aug 2014 07:10:51 -0000

Hi,

thanks for URL Shortener, I have made a few changes to get it working using 404 redirect.

1.) ShortURL.Utils

InternalShortURL, replacing domain does not actually clean up the string enough. this just gets the last part of the string after the last "/"

public static string InternalShortUrl(string short_url)
{
int position = short_url.LastIndexOf('/');
if (position != -1)
{
return short_url.Substring(position + 1);
} else
{
return String.Empty;
}
}

2.) Redirection.ASPX.cs

I removed code in regards to "(ShortUrl.Utils.HasValue(Request.QueryString["page"].ToString())) // checks in case ISAPIRewrite is being used" because it contains an error.

protected void Page_Load(object sender, EventArgs e)
{
ShortUrl.Container oShortUrl;

    oShortUrl = ShortUrl.Utils.RetrieveUrlFromDatabase(ShortUrl.Utils.InternalShortUrl(Request.Url.ToString()));

    if (oShortUrl.RealUrl != null)
    {
        Response.Redirect(oShortUrl.RealUrl);
    }
    else
    {
        Response.Redirect("MissingUrl.aspx");
    }
}

Redirection Parsing does not work

GM Lucid — Wed, 21 Mar 2012 22:25:46 -0000

I set up my DefaultAppPool to redirect to /shorturl/Redirection.aspx. The redirection page could not parse the URL. There were several bugs with the parsing. Here they are, in order:

1. Request.QueryString["page"].ToString() is bad code. It does not properly check for NULL before calling .ToString(). This is crucial. I commented out that line of code.
2. oShortUrl = "http://gmlucid.localhost.com/shorturl/Redirection.aspx?404;http://gmlucid.localhost.com:80/Li4t5
This is not parsed properly by Utils.Clean() method or the RetrieveUrlFromDatabase() method.
3. The Utils.Clean code works for "AddUrlToDatabase(Container)" but NOT for "RetrieveUrlFromDatabase(oShortUrl)". The key here is oShortUrl.
LOOK at the CLEAN method!!! IT is not even doing anything!!!! Just creating a Regex, but not applying it to the URL at all.
public static string Clean(string url)
{
string filter = @"((https?):((//)|(\\\\))+[\w\d:#@%/;$()~_?\+-=\\\.&]*)";
Regex rx = new Regex(filter);
return url;
}
LOOK at the CLEAN method!!! IT is not even doing anything!!!! Just creating a Regex, but not applying it to the URL at all.

Please Fix.

Please urgent !

savita singh — Mon, 29 Nov 2010 08:23:58 -0000

I want to use this project with own web site using (IIS7) can you help me.

Please send me step by step

File Not Found

Sachin Agrawal — Thu, 11 Feb 2010 03:42:52 -0000

Hi. I uploaded this script on http://smartlabsolution.com .. everything works fine, but when I get ShortURL and click on it, it leads to 404 error. Please tell me what to do...