https://sourceforge.net/p/tcljava/bugs/47/2008-08-25T04:53:10ZRecent changes to 47: ReflectObject loses command2008-08-25T04:53:10Z2008-08-25T04:53:10ZTom Poindexterhttps://sourceforge.net/u/tpoindex/https://sourceforge.netd2ac6f7f2d4e70506889e90efabf5624eacf40f6

<div class="markdown_content"><p>There seems to be a situation where a Java Object command is<br /> deleted from the interpreter, but the object still resides<br /> in the interp.reflectObjTable. This patch causes the<br /> java object command to be re-created if the command no<br /> longer exists.</p> <p>Note that this bug is exposed when using Incr Tcl, I'm not sure<br /> if there are other cases where the bug is exposed.</p> <p>Also note: my first attempt at a patch simply invoked<br /> interp.createCommand() if the command was missing, but<br /> that yielded "reflected object is no longer valid" when used (from the<br /> cmdProc() method.)</p> <p>---------------------------------------------------------------------------------</p> <p>IncrTcl method that exposes the bug, part of Aejaks 'Table' class.<br /> (The ::Label constructor '-from $c' wraps up an existing Java<br /> object, rather than creating a new one.)</p> <p>----------------------------------------------------------------------------------</p> <p>public method setCellLabelAttrs {columnIdx rowNum args} {<br /> if {[catch {<br /> set c [::java::cast [::Label::_getObjType_] [$_obj_ -noconvert getCellComponent $columnIdx $rowNum]]<br /> puts "getCellComponent return object $c"<br /> puts "check for command defined: [info commands $c]"</p> <p>set label [::Label #auto -from $c]<br /> } result]} {<br /> error "invalid column or row, or cell component is not a Label: $result"<br /> }<br /> set result ""<br /> set rc [catch {eval $label configure $args} result]<br /> ::itcl::delete object $label<br /> if {$rc} {<br /> error $result<br /> } else {<br /> return $result<br /> }<br /> }</p> <p>----------------------------------------------------------------------------------</p> <p>Test case, first time works; second time through, the java object command is<br /> missing. This example creates a table with one row and two columns.<br /> Invoking the 'setCellLabelAttrs' method changes the foreground color and text<br /> of the Label in the first column. The first invocation works (setting the<br /> text as 'RED' and changes its color to red.) The second invocation fails,<br /> as the java object command no longer exists. The error raised is a result<br /> of the 'from $c' missing the java object command.<br /> ----------------------------------------------------------------------------------<br /> % Table .t -columns 2<br /> % Pack .t<br /> % .t insertRow 0 {first second}<br /> % .t setCellLabelAttrs 0 0 -foreground red -text RED<br /> %<br /> getCellComponent return object java0x66<br /> check for command defined: java0x66</p> <p>% .t setCellLabelAttrs 0 0 -foreground blue -text BLUE<br /> %<br /> getCellComponent return object java0x66<br /> check for command defined:<br /> invalid column or row, or cell component is not a Label: unknown option "-from"</p></div>