Recent changes to patches

#4 Animation Frame Interpolation Patch

Steven — Tue, 21 Sep 2021 08:28:57 -0000

Awesome matey, thanks. Ozkan's 0001 patch works fine for me on my Mac.

#4 Animation Frame Interpolation Patch

Mattias Cibien — Tue, 21 Sep 2021 08:17:06 -0000

Ok. I'll adjust the patch

#4 Animation Frame Interpolation Patch

Ozkan Sezer — Tue, 21 Sep 2021 08:11:19 -0000

but I'll do my best to test it thorugh the game and the expansion.

Yes please.

(BTW, your v2-patch still has some of the pedantic issues:
The one I attached above has things right.)

#4 Animation Frame Interpolation Patch

Mattias Cibien — Tue, 21 Sep 2021 07:50:28 -0000

Here is the new patch with the modifications you asked.

Regarding testing: this was merely an excercise to explain frame interpolation to a collague so it was not exensively tested but I'll do my best to test it thorugh the game and the expansion.

#4 Animation Frame Interpolation Patch

Ozkan Sezer — Mon, 20 Sep 2021 16:03:36 -0000

Some pedantry:

No author name comments: they are ugly, not a big fan. Instead,
we usually give credit in docs/AUTHORS file.
The new cvar is defined wrong: the last field is not a boolean
but a flag, so it should be CVAR_ARCHIVE, not true.
When checking a cvar's value as a boolean we use it's 'integer'
member instead of 'value' when possible.
Newly added 'Blended' procedures and the lastpose0 var should be
static to gl_rmain.c.
Additions to entity_t structure should be guarded by GLQUAKE
because the patch only touches OpenGL path.
Whitespace style should match other places.

Attached a revised patch which does the above changes.

Question: Have you extensively tested the patch in the whole game
in all episodes and maps, including the Portal of Praevus mission
pack? IIRC, this functionality can be a tricksy one.

#4 Animation Frame Interpolation Patch

Mattias Cibien — Mon, 20 Sep 2021 14:56:42 -0000

If accepted I can continue to work on this providing both pos/rot and shadows.

Animation Frame Interpolation Patch

Mattias Cibien — Mon, 20 Sep 2021 14:55:56 -0000

This adds animation frame interpolation (no pos/rot or shadows) and it is loosely based on what is found here for quake.

Fix for crosslevel with spawnflag 8

Keith Rozett — Sun, 21 Feb 2010 13:49:50 -0000

The original gamecode has a bug that prevents any crosslevel triggers from working if they use spawnflag 8. This is most noticeable in the original Hexen II, where one of the prizes in the Temple of Mars doesn't appear.

You can test the bug yourself by making a small level with a button that targets a crosslevel trigger using spawnflag 8, and then a separate level with a crosslevel_target trigger attached to something like an item spawner. The spawner will never create the item. But if you use any other spawnflag number, the item spawner will work correctly.

I traced the bug down to subs.hc, which defines a constant SPAWNFLAG_ACTIVATED, with a value of 8. There is a function called InitTrigger, which deactivates the trigger if its spawnflags match this flag... but that shouldn't happen since crosslevel triggers can't be deactivated anyway. I made a lazy fix by setting the inactive property to FALSE on the trigger after calling InitTrigger. This fixes the problem with no ill side-effects, from what I can tell.

Grab mouse in window mode after save

plusminus — Sat, 18 Oct 2008 09:34:22 -0000

In windowed mode, when you save using the menus the game quits the menu without grabbing the mouse properly. This should fix it.

I don't *think* there are any other cases where this happens, other than saving in SP and MP, but maybe I missed one. I have no idea if hexenworld has similar issues.

mouse buttons 4 and 5

Julien Langer — Sun, 23 Jan 2005 11:28:41 -0000

Hi,

attached is a little patch to enable mouse buttons 4
and 5 (thumb buttons) which newer mice have.