Recent changes to patches

#57 port to sdl2

galtgendo — Mon, 16 Nov 2015 17:53:47 -0000

TBH, you could have just removed those OpenAL parts...

On the other hand, as mentioned before, that file has very little changes from src/win32/OpenAL.cpp. It's far older than SDL2 changes.

The changes were mostly:
- linking, not loading
- drop loging, when too spammy or pointless
- (possibly incorrect, but working) drop Sleep from write
- when curent context is NULL, alGetError doesn't work
- oalBuferCount is constant, to make things more simple

The header is just the removed class definition without ALFunction (and the preceeding LOGALL block) prefixed by SoundDriver.h and OpenAL includes.

#57 port to sdl2

wowzaman12 — Mon, 16 Nov 2015 04:21:09 -0000

Your patch is missing SoundOAL.cpp, without this I can't really fully test your changes

#57 port to sdl2

galtgendo — Thu, 12 Nov 2015 01:35:04 -0000

...?
While a few commits were pulled (haven't done it in awhile, but the last post was already git based), there were no changes in the patch itself...

Well, what might mater was that the patch was produced via 'git diff -w' preceded with 'git mv src/gba/debugger-expr.y{,pp}' (parser/lexer changes might be flex/bison specific and not tied into the build system (yet ?)).
That's mainly because at the time of writing, the sources in the repo are a horrible mess, both wrt. line endings and indent style (that's how things ended up when Forgotten has left and there was nobody to set janitorial policies).

Which reminds me: could someone look into fixing the strict aliasing warning flood ? Preferably in a way not involving '-fno-strict-aliasing'.

Ataching more reasonably stripped dump.

#57 port to sdl2

wowzaman12 — Wed, 11 Nov 2015 16:01:40 -0000

Could you rebase off of current git https://github.com/visualboyadvance-m/visualboyadvance-m

#57 port to sdl2

galtgendo — Wed, 11 Nov 2015 15:00:28 -0000

...and now I've noticed, that my trimming was a bit random - I've trimmed some parts that are needed by non-trimmed parts..:sigh:
:shrug:
Whatever, the older patches should have the mising bits...

#57 port to sdl2

galtgendo — Wed, 11 Nov 2015 14:46:43 -0000

This wil be yet another dump...(I really should finaly make use of git and split this into a patch series; for some reason though I just can't get around to it).

Anyway, it's not a complete dump, as some filter changes were cut out...On that note, I wonder about two things:if perhaps it would be worthwhile to pull lq3x and lq4x from the place lq2x comes from and how hard it would be for someone more skilled in python to adapt the scripts used to create ffmpeg's hqx implementation to work on those three (the compilation time is much shorted with those and the resulting code is much smaller; haven't tested if there's a speed difference too). On a different, but somewhat related note, does anyone have an idea where do the factors of the orignal pseudo-yuv conversion come from ? Not the ones in the more modern versions, where real factors are used, but those in RGBtoYUV_16.

The changes since last version (IIRC) are little but cosmetic, mostly moving a call of a function to a different place, so it's not caled redundantly.

I don't quite understand that line about X11 - about the only thing I see it could be refering to is that XInitThreads call, which should land behing a properly picked define, but is still mandatory as a crasher fix on xserver.
gtk3 itself can be built with wayland backend, but that's handled internally.

...and a minor note about gtk3 OpenGL widget: IMHO, it sucks; upstream might have considered sticking to >= OpenGL 3.0 a right idea, but that throws away quite a bit of older hardware and pretty much forces you to work with shaders; well, that has its advantages, but ticks me off nevertheless.

#57 port to sdl2

wowzaman12 — Tue, 10 Nov 2015 00:47:04 -0000

Hey, Just been following up on your patch (been playing catch up on some things etc) So far I'm liking some of the changes you've made and may merge some of them in. Now regarding the gtk ui changes you've made. I'd personally would like to avoid some specific X11 changes, Yes X11 is still supported, however we should be thinking about wayland support. Could you rework your gtk changes to at least reflect wayland support on top of X11?

#67 HLE BIOS SoundDriver

skid — Fri, 16 Oct 2015 23:45:20 -0000

status: open --> closed-accepted

HLE BIOS SoundDriver

Juha Laukkanen — Fri, 16 Oct 2015 16:26:17 -0000

This patch adds those missing HLE BIOS functions for sound driver: https://sourceforge.net/p/vbam/bugs/24/

It is utilized by Phantasy Star Collection at intro. I don't know any other games using this BIOS driver, so I just implemented the parts that Phantasy Star Collection uses.

This patch is far away from perfect yet. Sound quality is not the same as with original BIOS. Also code is horrible to read, since I just kept translating arm instructions to C without thinking too much. Got it done quickly so if anyone has keen interest on continuing from here.

HLE BIOS SoundDriver

Juha Laukkanen — Fri, 16 Oct 2015 16:26:17 -0000

Ticket 67 has been modified: HLE BIOS SoundDriver
Edited By: skid (skidau)
Status updated: u'open' => u'closed-accepted'