#24 Possible information leakage from IoSocketDispatcher through an IOException without LOGGER severe control such as LOG.isLoggable(Level.SEVERE)

Xiaoqin Fu — Sun, 22 Nov 2020 18:13:31 -0000

Could I open a PR for it?

Possible information leakage from IoSocketDispatcher through an IOException without LOGGER severe control such as LOG.isLoggable(Level.SEVERE)

Xiaoqin Fu — Sat, 03 Aug 2019 17:49:34 -0000

In org.xsocket.connection.IoSocketDispatcher,
public IoSocketDispatcher(AbstractMemoryManager memoryManager, String name) {
......
try {
selector = Selector.open();
} catch (IOException ioe) {
String text = "exception occured while opening selector. Reason: " + ioe.toString();
LOG.isLoggable(Level.SEVERE)
LOG.severe(text);
throw new RuntimeException(text, ioe);
}
......
}
Sensitive information about the selector may be leaked. The LOG.isLoggable(Level.SEVERE) conditional statement should be added
public IoSocketDispatcher(AbstractMemoryManager memoryManager, String name) {
......
try {
selector = Selector.open();
} catch (IOException ioe) {
String text = "exception occured while opening selector. Reason: " + ioe.toString();
if (LOG.isLoggable(Level.SEVERE))
LOG.severe(text);
throw new RuntimeException(text, ioe);
}
......
}

Recent changes to 24: Possible information leakage from IoSocketDispatcher through an IOException without LOGGER severe control such as LOG.isLoggable(Level.SEVERE)

#24 Possible information leakage from IoSocketDispatcher through an IOException without LOGGER severe control such as LOG.isLoggable(Level.SEVERE)

Possible information leakage from IoSocketDispatcher through an IOException without LOGGER severe control such as LOG.isLoggable(Level.SEVERE)