Re: [Ogoglio-developers] [Ogoglio-commits] SF.net SVN: ogoglio: [224] spaces/trunk/src/com/ogoglio

Hi Trevor,

Thanks for adding the patches... I still need to figure out what goes where
:) and how.

In regards to using log4j I believe it to be a better solution than using
System.out/err, since we can benefit from the logging levels, changing
logging level at runtime, code guards etc.

Just as an example, "System.out.println(new Date() + ": Deleted space: " +
spaceID);"
Why would I want to have this line in the logs when the system is stable? It
can help me debugging the system but not more than that. If we used log4j I
might have marked this message as info level and usually I would run the
system at warn level...

In regards to the space delete issue, I think it make more sense to put the
DELETE in the AccountServlet and not in the SpaceServlet. The reason is that
since spaces are created in the AccountServlet it would make more sense to
delete it in the same place i.e. AccountServlet. Also, since SpaceServlet
manages the space's inner data only, I think it is better that the creation
and deletion of space stays in the level of the account.

Gal.