Re: [SQLObject] Possible bug in EnumCol/EnumValidator
SQLObject is a Python ORM.
Brought to you by:
ianbicking,
phd
|
From: Oleg B. <ph...@ph...> - 2013-08-07 17:51:34
|
Hi!
On Wed, Aug 07, 2013 at 11:52:15AM +0200, Gert Burger <ger...@gm...> wrote:
> Attached is a test case demonstrating the issue. Tested with version
> 1.5.0b1 and some previous versions.
Thanks for the report!
> The EnumValidator checks if the value given is in the list of valid
> enumValues but this allows unicode values to match normal string values.
>
> That allows unicode objects into the SQL generation code which forces
> python to create unicode strings instead of normal strings. This means
> already encoded values will be decoded again and probably with the wrong
> encoding.
>
> My guess is that the EnumValidator should return only str objects that
> are properly encoded.
At the first glance I'm not sure what should be the correct behaviour
for EnumValidator. I'll think about it.
Oleg.
--
Oleg Broytman http://phdru.name/ ph...@ph...
Programmers don't die, they just GOSUB without RETURN.
|