squirrel-sql-develop Mailing List for SQuirreL SQL Client (Page 46)

> - Windows batch file now passes the -classic flag  to the VM to stop
>   plugins looking for files in the "Colin Bell" or "Johan Compagner"
>   directories instead of the plugins private directory.

??? what kind of problems does hotspot give you?

> - If selected String are longer then 50 chars then 45 chars + "......" 
>   will be displayed. (Johan Compagner)

i don't do this anymore, this is the responsibilty of the DataSetViewer.
And the JTableDataset does this right from the start (it's build in)
This way if you select it to see the complete text in the popup dialog
you really have the complete text.
The TextAreaDataset should do cutting itself. (i don't know if it already does this)

Johan

Theres the beginnings of an FAQ up on the web site now
http://squirrel-sql.sourceforge.net/faq.html

If anybody has any questions (and hopefully answers) that they believe
should be included in the FAQ please send them to the list.

Col

Version 0.11 of the Look and Feel plugin has been released. It
can be downloaded from
http://sourceforge.net/project/showfiles.php?group_id=28383&release_id=81655

The full list of changes are:

Bug Fixes 
------------ 
- Skin Look and Feel jar placed in correct directory. 

Other 
----- 
- All Skin Look and Feel theme packs are now placed in the subdirectory
skinlf-theme-packs instead of theme_packs. 

Version 1.1beta2 of SQuirreL SQL Client has been released. It
can be downloaded from
http://sourceforge.net/project/showfiles.php?group_id=28383&release_id=81649

The full list of changes are:

Bug Fixes
------------
- Windows batch file now allows for spaces in the classpath (Bruno Haas).
- Windows batch file now passes the -classic flag  to the VM to stop
  plugins looking for files in the "Colin Bell" or "Johan Compagner"
  directories instead of the plugins private directory.
- "Torn off" SQL results windows are now closed when the session is
  closed.
- Unix shell script now has correct line terminators.
- QueryTokenizer improperly parsed strings with quotes on multiple lines
  and caused SQLException (Todd Larsen).
- Application Settings dialog now has a more sensible width under JDK1.4.
- If no alises defined then the Alises dropdown has a sensible width
  under JDK1.4.
- If Aliases dropdown is empty when adding the first one to it then make
  the new one the selected one.
- When adding aliases/drivers then select the newly added one in the list.
- When deleting aliases/drivers then ensure that another one selected
  in the list.
- longvarchars will now be displayed instead of <null> (Johan Compagner)
- JDBC drivers reloaded when they have been modified through the
  maintenance window.
- Keeping the state when refreshing the tree works now (Johan Compagner)

Enhancements
------------
- Now showing all columns in meta data displays.
- Drop table menu item on the ObjectTree (Johan Compagner)
- Full column data can be displayed in a popup window if you double click on
  it (Johan Compagner)
- If selected String are longer then 50 chars then 45 chars + "......" 
  will be displayed. (Johan Compagner)
- If only one cell selected in table when pressing copy then no header 
  will be appended. (Johan Compagner)
- Icon shown for drivers that are loaded or not (Johan Compagner/Henner
Zeller) 
- TableSorting by clicking column headers (Johan Compagner)
- Escape now cancels Connection Dialog.

Other
-----
- Licence for the client application changed from GPL to LGPL.
- JDK1.4 specific code now called through reflection so application
  can be compiled using JDK1.3.

Doesn't show anything over here (now talking as a user, haven't got the =
time to look at yet)

johan

Hi Wayne,

"Done in haste" describes it perfectly. The magic numbers refer to the
columns in the information retrieved from the metadata. We've display only
the "relevant" information. In the future this is going to be configurable
in the session properties dialog.

I don't have your problem with Oracle via the ODBC driver. I'm using Oracle
8.1.6 with version 2.573.4202.00 of the Microsoft Oracle ODBC driver. Are
you using an older version of the driver?

In any case I'm probably going to rip out the "magic numbers" in the next
release and just display all columns.

Col

-----Original Message-----
From: Rogers,Wayne [mailto:way...@CH...]
Sent: Tuesday, 19 March 2002 8:34
To: 'squ...@li...'
Subject: [Squirrel-sql-develop] Array of magic numbers in several
TablePanel load routines



IRT
com.bigfoot.colbell.squirrel.sessionsheet.objectstree.TablePanel

I notice that several of the load methods in MyBaseViewer derived classes do
something like this:
show(new ResultSetDataSet(rs, new int[]
{4,5,6,7,9,10,11,12,13,14,15,16,17,18}), getSession().getMessageHandler());

In my case, these methods throw an error and show no data. If I change the
method to use the constructor without the int array, it seems to work. Is
this an optimization of some kind or simply something done in haste? Also, I
personally prefer to define constants for each of the column indices that I
hope to retrieve. (readability issue)

Any thoughts?

Wayne

p.s.
using  Microsoft ODBC for Oracle driver, no known problems with other
clients

_______________________________________________
Squirrel-sql-develop mailing list
Squ...@li...
https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop

IRT
com.bigfoot.colbell.squirrel.sessionsheet.objectstree.TablePanel

I notice that several of the load methods in MyBaseViewer derived classes do
something like this:
show(new ResultSetDataSet(rs, new int[]
{4,5,6,7,9,10,11,12,13,14,15,16,17,18}), getSession().getMessageHandler());

In my case, these methods throw an error and show no data. If I change the
method to use the constructor without the int array, it seems to work. Is
this an optimization of some kind or simply something done in haste? Also, I
personally prefer to define constants for each of the column indices that I
hope to retrieve. (readability issue)

Any thoughts?

Wayne

p.s.
using  Microsoft ODBC for Oracle driver, no known problems with other
clients

Hi Michael,

>> SQuirreL's just what I was looking for, thanks all!

Thank you, we all love our egos being stroked.

>> Where do I get started developing a plugin?

Theres a little bit of information in the document plugins.html which you
can find in the docs directory within your SQuirreL program directory. This
document badly needs a lot of work and its on my todo list. Your can also
look at the existing plugins to see how they've done things.

If you have got an idea for a plugin just send a msg to this list giving a
brief description. This helps to ensure that two people don't develop the
same plugin.

I'm looking forward to seeing what you do.

Col

SQuirreL's just what I was looking for, thanks all!

Where do I get started developing a plugin?

Done all.

About that compile error: I really think this is a bug of javac and not eclipse:

see my mail that i send to the eclipse newsgroup:


Take this file:

-------------------------------------------
package test;

import javax.swing.JTable;
import javax.swing.table.DefaultTableModel;
import javax.swing.table.TableModel;

public class A
{
 public class AA extends JTable
 {
  public AA(TableModel model)
  {
   super(new TestModel());
  }
 }

 public class TestModel extends DefaultTableModel
 {
 }
}
---------------------------------------------------------

Eclipse compiles fine but
javac:
C:\eclipse\workspace\Test>javac test\A.java
test\A.java:14: cannot reference this before supertype constructor has been call
ed
                        super(new TestModel());
                              ^
1 error

But i think eclipse is the one that does this right. Because it should be possible to do this
i think this can be generated: (and i think eclipse compiler does this)

  public AA(A outer, TableModel model)
  {
   super(new TestModel(outer));
  }

I think javac tries to do this:

  public AA(A outer, TableModel model)
  {
   super(new TestModel(this.A.this));
  }

johan

Hi Johan,

Unfortunately its still broken. I'm not sure what is going on here; it
builds happily in Eclipse with JDK1.4 but not with Ant with the very same
copy of the JDK. Gives the following error:

[javac] D:\src\squirrel-sql\squirrel-sql\fw\src\net\sourceforge\squirrel_sql
\fw\datasetviewer\DataSetViewerTablePanel.java:157: cannot reference this
before
 supertype constructor has been called
    [javac]                     super(new SortableTableModel(new
MyTableModel())
);

I don't understand why it builds in Eclipse but not in Ant.

Anyway heres another patch. Now builds in both. Could you please apply this
one to CVS as well.

I can't generate a diff because my CVS client now won't load. Definitely
time to rebuild this PC.

You need to make the following changes to DataSetViewerTablePanel:

Add
		private ColumnDisplayDefinition[] _colDefs = new
ColumnDisplayDefinition[0];
to MyTableModel

and replace
	private final class MyTableModel extends AbstractTableModel {
with
	private final static class MyTableModel extends AbstractTableModel {




As well my build scripts don't take .png files into account.

In /squirrel-sql/build/build.xml could you add the line

	<include name="**/*.png"/>

after both occurences of

	<include name="**/*.jpeg"/>

They're in the targets compile_app and compile_fw.

Thanks
Col

-----Original Message-----
From: Johan Compagner [mailto:jco...@j-...]
Sent: Thursday, 14 March 2002 9:26
To: squ...@li...
Subject: Re: [Squirrel-sql-develop] Something changed over weekend to
break build?


Fixed,

also fixed 2 other bugs:

Sorting on a column that is moved doesn't work 
Displaying the value of a moved column doesn't work
for both  cases : it uses the values of the column that is now under that
old position.

johan


----- Original Message ----- 
From: "Colin Bell" <Col...@as...>
To: "'BradLyon'" <bra...@nt...>;
<squ...@li...>
Sent: Wednesday, March 13, 2002 10:54 PM
Subject: RE: [Squirrel-sql-develop] Something changed over weekend to break
build?


> Brad,
> 
> Just apply the attached diff to your copy of
>
fw/src/net/sourceforge/squirrel_sql/fw/datasetviewer/DataSetViewerTablePanel
> .java and the build should work.
> 
> 
> Johan,
> 
> Sorry, I gave you a bum steer on the fix for the build, its a lot simpler
> than what I said. Could you apply the attached diff to the CVS on
> SourceForge. Its going to be a couple of days till I can get SSH access to
> SF.
> 
> Thanks
> Col
> 
> 
> -----Original Message-----
> From: BradLyon [mailto:bra...@nt...]
> Sent: Thursday, 14 March 2002 7:50
> To: squ...@li...
> Subject: [Squirrel-sql-develop] Something changed over weekend to break
> build?
> 
> 
> I did a quick test build after Johan checked things in this past weekend, 
> and it didn't work.  I haven't looked into detail yet, but I know it was 
> building before that.  Did anything else change that I need?
> 
> _______________________________________________
> Squirrel-sql-develop mailing list
> Squ...@li...
> https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
> 
> 



_______________________________________________
Squirrel-sql-develop mailing list
Squ...@li...
https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop

Fixed,

also fixed 2 other bugs:

Sorting on a column that is moved doesn't work 
Displaying the value of a moved column doesn't work
for both  cases : it uses the values of the column that is now under that old position.

johan


----- Original Message ----- 
From: "Colin Bell" <Col...@as...>
To: "'BradLyon'" <bra...@nt...>; <squ...@li...>
Sent: Wednesday, March 13, 2002 10:54 PM
Subject: RE: [Squirrel-sql-develop] Something changed over weekend to break build?


> Brad,
> 
> Just apply the attached diff to your copy of
> fw/src/net/sourceforge/squirrel_sql/fw/datasetviewer/DataSetViewerTablePanel
> .java and the build should work.
> 
> 
> Johan,
> 
> Sorry, I gave you a bum steer on the fix for the build, its a lot simpler
> than what I said. Could you apply the attached diff to the CVS on
> SourceForge. Its going to be a couple of days till I can get SSH access to
> SF.
> 
> Thanks
> Col
> 
> 
> -----Original Message-----
> From: BradLyon [mailto:bra...@nt...]
> Sent: Thursday, 14 March 2002 7:50
> To: squ...@li...
> Subject: [Squirrel-sql-develop] Something changed over weekend to break
> build?
> 
> 
> I did a quick test build after Johan checked things in this past weekend, 
> and it didn't work.  I haven't looked into detail yet, but I know it was 
> building before that.  Did anything else change that I need?
> 
> _______________________________________________
> Squirrel-sql-develop mailing list
> Squ...@li...
> https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
> 
> 

Brad,

Just apply the attached diff to your copy of
fw/src/net/sourceforge/squirrel_sql/fw/datasetviewer/DataSetViewerTablePanel
.java and the build should work.


Johan,

Sorry, I gave you a bum steer on the fix for the build, its a lot simpler
than what I said. Could you apply the attached diff to the CVS on
SourceForge. Its going to be a couple of days till I can get SSH access to
SF.

Thanks
Col


-----Original Message-----
From: BradLyon [mailto:bra...@nt...]
Sent: Thursday, 14 March 2002 7:50
To: squ...@li...
Subject: [Squirrel-sql-develop] Something changed over weekend to break
build?


I did a quick test build after Johan checked things in this past weekend, 
and it didn't work.  I haven't looked into detail yet, but I know it was 
building before that.  Did anything else change that I need?

_______________________________________________
Squirrel-sql-develop mailing list
Squ...@li...
https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop

I did a quick test build after Johan checked things in this past weekend, 
and it didn't work.  I haven't looked into detail yet, but I know it was 
building before that.  Did anything else change that I need?

Great. Thanks Johan.

Col

-----Original Message-----
From: Johan Compagner [mailto:jco...@j-...]
Sent: Thursday, 14 March 2002 6:40
To: Squirrel Developers List (E-mail)
Subject: Re: [Squirrel-sql-develop] updated


Both bugs/rfe fixed:

Null Check with compare
and
Doesn't sort when column moved/expanded

johan

----- Original Message ----- 
From: "Colin Bell" <Col...@as...>
To: "Squirrel Developers List (E-mail)"
<squ...@li...>
Sent: Wednesday, March 13, 2002 5:35 AM
Subject: RE: [Squirrel-sql-develop] updated


> > i tried to get the selection back after a refresh on the tree but that
> doesn't seem
> > to work completely only database or catalogs keep the selections ??
> 
> Very peculiar. The weird thing is it must actually select the table node
in
> the tree because the details panel for the table gets redisplayed which is
> the important thing. I wouldn't worry about it for the moment as its more
> cosmetic than anything.
> 
> A couple of little things with the table sorting. When you resize a column
> it actually sorts by one of the columns as well. Would it be possible to
> have a "dead" area in the table header that when the cursor has changed
for
> resizing the column that the click is ignored for sorting? I don't know if
> there is any way of getting feedback from the table when it has gone into
> "column resize mode". Hopefully there is.
> 
> I get an exception thrown if I sort by a column that contains an empty
> string. I.E. If you issue the SQL cmd
> 
> select '', 1 from some_table
> 
> and then sort by the second column it works but sorting by the first
column
> gives a NullPointerException. Copying the data from the results gives the
> following
> 
> '       1
> ----------------------
> <null> 1.0
> <null> 1.0
> 
> Exception occurred during event dispatching:
> java.lang.NullPointerException
>         at java.lang.String.compareTo(String.java:797)
>         at java.lang.String.compareTo(String.java:847)
>         at
>
net.sourceforge.squirrel_sql.fw.gui.SortableTableModel$TableModelComparator.
> compare(SortableTableModel.java:260)
>         at java.util.Arrays.mergeSort(Arrays.java:1181)
>         at java.util.Arrays.mergeSort(Arrays.java:1188)
>         at java.util.Arrays.mergeSort(Arrays.java:1188)
>         at java.util.Arrays.sort(Arrays.java:1128)
>         at
>
net.sourceforge.squirrel_sql.fw.gui.SortableTableModel.sortByColumn(Sortable
> TableModel.java:226)
>         at
>
net.sourceforge.squirrel_sql.fw.gui.SortableTableModel.sortByColumn(Sortable
> TableModel.java:208)
>         at
>
net.sourceforge.squirrel_sql.fw.gui.ButtonTableHeader$HeaderListener.mouseRe
> leased(ButtonTableHeader.java:101)
>         at
> java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:231)
>         at java.awt.Component.processMouseEvent(Component.java:3715)
>         at java.awt.Component.processEvent(Component.java:3544)
>         at java.awt.Container.processEvent(Container.java:1164)
>         at java.awt.Component.dispatchEventImpl(Component.java:2593)
>         at java.awt.Container.dispatchEventImpl(Container.java:1213)
>         at java.awt.Component.dispatchEvent(Component.java:2497)
>         at
> java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:2451)
>         at
> java.awt.LightweightDispatcher.processMouseEvent(Container.java:2216)
>         at
java.awt.LightweightDispatcher.dispatchEvent(Container.java:2125)
>         at java.awt.Container.dispatchEventImpl(Container.java:1200)
>         at java.awt.Window.dispatchEventImpl(Window.java:914)
>         at java.awt.Component.dispatchEvent(Component.java:2497)
>         at java.awt.EventQueue.dispatchEvent(EventQueue.java:339)
>         at
>
java.awt.EventDispatchThread.pumpOneEventForHierarchy(EventDispatchThread.ja
> va:131)
>         at
>
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java
> :98)
>         at
> java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
>         at java.awt.EventDispatchThread.run(EventDispatchThread.java:85)
> 
> Other than that its looking really good.
> 
> Col
> 
> _______________________________________________
> Squirrel-sql-develop mailing list
> Squ...@li...
> https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
> 



_______________________________________________
Squirrel-sql-develop mailing list
Squ...@li...
https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop

Both bugs/rfe fixed:

Null Check with compare
and
Doesn't sort when column moved/expanded

johan

----- Original Message ----- 
From: "Colin Bell" <Col...@as...>
To: "Squirrel Developers List (E-mail)" <squ...@li...>
Sent: Wednesday, March 13, 2002 5:35 AM
Subject: RE: [Squirrel-sql-develop] updated


> > i tried to get the selection back after a refresh on the tree but that
> doesn't seem
> > to work completely only database or catalogs keep the selections ??
> 
> Very peculiar. The weird thing is it must actually select the table node in
> the tree because the details panel for the table gets redisplayed which is
> the important thing. I wouldn't worry about it for the moment as its more
> cosmetic than anything.
> 
> A couple of little things with the table sorting. When you resize a column
> it actually sorts by one of the columns as well. Would it be possible to
> have a "dead" area in the table header that when the cursor has changed for
> resizing the column that the click is ignored for sorting? I don't know if
> there is any way of getting feedback from the table when it has gone into
> "column resize mode". Hopefully there is.
> 
> I get an exception thrown if I sort by a column that contains an empty
> string. I.E. If you issue the SQL cmd
> 
> select '', 1 from some_table
> 
> and then sort by the second column it works but sorting by the first column
> gives a NullPointerException. Copying the data from the results gives the
> following
> 
> '       1
> ----------------------
> <null> 1.0
> <null> 1.0
> 
> Exception occurred during event dispatching:
> java.lang.NullPointerException
>         at java.lang.String.compareTo(String.java:797)
>         at java.lang.String.compareTo(String.java:847)
>         at
> net.sourceforge.squirrel_sql.fw.gui.SortableTableModel$TableModelComparator.
> compare(SortableTableModel.java:260)
>         at java.util.Arrays.mergeSort(Arrays.java:1181)
>         at java.util.Arrays.mergeSort(Arrays.java:1188)
>         at java.util.Arrays.mergeSort(Arrays.java:1188)
>         at java.util.Arrays.sort(Arrays.java:1128)
>         at
> net.sourceforge.squirrel_sql.fw.gui.SortableTableModel.sortByColumn(Sortable
> TableModel.java:226)
>         at
> net.sourceforge.squirrel_sql.fw.gui.SortableTableModel.sortByColumn(Sortable
> TableModel.java:208)
>         at
> net.sourceforge.squirrel_sql.fw.gui.ButtonTableHeader$HeaderListener.mouseRe
> leased(ButtonTableHeader.java:101)
>         at
> java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:231)
>         at java.awt.Component.processMouseEvent(Component.java:3715)
>         at java.awt.Component.processEvent(Component.java:3544)
>         at java.awt.Container.processEvent(Container.java:1164)
>         at java.awt.Component.dispatchEventImpl(Component.java:2593)
>         at java.awt.Container.dispatchEventImpl(Container.java:1213)
>         at java.awt.Component.dispatchEvent(Component.java:2497)
>         at
> java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:2451)
>         at
> java.awt.LightweightDispatcher.processMouseEvent(Container.java:2216)
>         at java.awt.LightweightDispatcher.dispatchEvent(Container.java:2125)
>         at java.awt.Container.dispatchEventImpl(Container.java:1200)
>         at java.awt.Window.dispatchEventImpl(Window.java:914)
>         at java.awt.Component.dispatchEvent(Component.java:2497)
>         at java.awt.EventQueue.dispatchEvent(EventQueue.java:339)
>         at
> java.awt.EventDispatchThread.pumpOneEventForHierarchy(EventDispatchThread.ja
> va:131)
>         at
> java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java
> :98)
>         at
> java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
>         at java.awt.EventDispatchThread.run(EventDispatchThread.java:85)
> 
> Other than that its looking really good.
> 
> Col
> 
> _______________________________________________
> Squirrel-sql-develop mailing list
> Squ...@li...
> https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
> 

> i tried to get the selection back after a refresh on the tree but that
doesn't seem
> to work completely only database or catalogs keep the selections ??

Very peculiar. The weird thing is it must actually select the table node in
the tree because the details panel for the table gets redisplayed which is
the important thing. I wouldn't worry about it for the moment as its more
cosmetic than anything.

A couple of little things with the table sorting. When you resize a column
it actually sorts by one of the columns as well. Would it be possible to
have a "dead" area in the table header that when the cursor has changed for
resizing the column that the click is ignored for sorting? I don't know if
there is any way of getting feedback from the table when it has gone into
"column resize mode". Hopefully there is.

I get an exception thrown if I sort by a column that contains an empty
string. I.E. If you issue the SQL cmd

select '', 1 from some_table

and then sort by the second column it works but sorting by the first column
gives a NullPointerException. Copying the data from the results gives the
following

'	      1
----------------------
<null>	1.0
<null>	1.0

Exception occurred during event dispatching:
java.lang.NullPointerException
        at java.lang.String.compareTo(String.java:797)
        at java.lang.String.compareTo(String.java:847)
        at
net.sourceforge.squirrel_sql.fw.gui.SortableTableModel$TableModelComparator.
compare(SortableTableModel.java:260)
        at java.util.Arrays.mergeSort(Arrays.java:1181)
        at java.util.Arrays.mergeSort(Arrays.java:1188)
        at java.util.Arrays.mergeSort(Arrays.java:1188)
        at java.util.Arrays.sort(Arrays.java:1128)
        at
net.sourceforge.squirrel_sql.fw.gui.SortableTableModel.sortByColumn(Sortable
TableModel.java:226)
        at
net.sourceforge.squirrel_sql.fw.gui.SortableTableModel.sortByColumn(Sortable
TableModel.java:208)
        at
net.sourceforge.squirrel_sql.fw.gui.ButtonTableHeader$HeaderListener.mouseRe
leased(ButtonTableHeader.java:101)
        at
java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:231)
        at java.awt.Component.processMouseEvent(Component.java:3715)
        at java.awt.Component.processEvent(Component.java:3544)
        at java.awt.Container.processEvent(Container.java:1164)
        at java.awt.Component.dispatchEventImpl(Component.java:2593)
        at java.awt.Container.dispatchEventImpl(Container.java:1213)
        at java.awt.Component.dispatchEvent(Component.java:2497)
        at
java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:2451)
        at
java.awt.LightweightDispatcher.processMouseEvent(Container.java:2216)
        at java.awt.LightweightDispatcher.dispatchEvent(Container.java:2125)
        at java.awt.Container.dispatchEventImpl(Container.java:1200)
        at java.awt.Window.dispatchEventImpl(Window.java:914)
        at java.awt.Component.dispatchEvent(Component.java:2497)
        at java.awt.EventQueue.dispatchEvent(EventQueue.java:339)
        at
java.awt.EventDispatchThread.pumpOneEventForHierarchy(EventDispatchThread.ja
va:131)
        at
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java
:98)
        at
java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
        at java.awt.EventDispatchThread.run(EventDispatchThread.java:85)

Other than that its looking really good.

Col

i updated the cvs stream to better images i got from colin
also the table headers have a ascending or descending arrow pictures now.

i tried to get the selection back after a refresh on the tree but that doesn't seem
to work completely only database or catalogs keep the selections ??

johan

> It must be very late for you there! Good to see you're working on Squirrel
> into the wee small hours. Thats what I call dedication <grin/>.

sunday it was 2:30 i believe!! (AM)

 
> <snip>
> If i did a refresh pressing the button then the cursor did stay wrong
> i added a _cursor.restore() after i do the refresh now just to be sure.
> </snip>
> 
> Peculiar, now its not showing the wait cursor for me at all. _However_ I
> must say that the refresh seems to be running a lot faster now than it was
> previously so it may not have time to show the cursor.

at this time the refresh is being done in the main thread i believe!
this should be altered. But some other small modifications has to  be done
then, but this isn't to hard.

 
> It is convienient to expand them. The previous behaviour was an irritation
> when something externally has changed the structure of a table or added a
> table, you do a refresh and then you had to expand the tree to find where
> you were. I much prefer your new behaviour.

me to i will leave it for now.
(or maybe one other thing: trying to select the selected again)
 
> One peculiarity. When you first open a database it expands the database tab
> showing all schemas/catalogs and selects the datbase node for display
> (exactly what it should do) but if you then Refresh it, it expands all the
> schema/catalog tabs but doesn't remember the node that was selected. 

selecting the selected is a feature that should be done yes.

> In fact refresh _always_ expands the schema/catalog tabs even if they weren't
> expanded.

Yes i have tested this and it does happen because a Catalog Tree node has
build in children i believe. And i do the testing what i have to expand again
on if they have children or not. (that's why it always expand also the ones that
where onces expanded.)

This should be altered i believe but the current way was the fasted wat to do it
at this time.

i updated just the cvs tree so that this does not happen anymore.

 
> It would be nice if you could take the code you have written
> saving/restoring the expansion state of a tree and abstract it out into a
> separate class (like SavedExpansionState). A component that you could use to
> save and restore the state of any JTree would be very convienient.

it is a separate class, It is the basenode  :-) 
it needs to have access to the internals of all the nodes (like children array)

johan

Hey Johan,

It must be very late for you there! Good to see you're working on Squirrel
into the wee small hours. Thats what I call dedication <grin/>.

I've just synched with the latest version from CVS (damn firewalls) and had
a quick play with it. Works properly with Mckoi now (longvarchar works).

<snip>
If i did a refresh pressing the button then the cursor did stay wrong
i added a _cursor.restore() after i do the refresh now just to be sure.
</snip>

Peculiar, now its not showing the wait cursor for me at all. _However_ I
must say that the refresh seems to be running a lot faster now than it was
previously so it may not have time to show the cursor.

<snip>
I already did a rewrite :-)
</snip>

Excellent!!!.

<snip>
the problem with the previous approacher (TreeState object or something)
was that this only stored treepaths and then say to the tree expand
But the problem if you do a reload of the tree then that tree path isn't
there
anymore because it is not loaded yet.
I fixed that because the refresh is now really done by the model and its
nodes
and not just a call on root.reload() (look at BaseNode)

But i don't use the methods: getExpandedNodes(TreePath) or isExpanded()
anymore so maybe i should first try to get those and the do the current
refresh
and then expand those. (but not really those? because that real objects
treepath
are removed and replaced with something else.
</snip>

It is convienient to expand them. The previous behaviour was an irritation
when something externally has changed the structure of a table or added a
table, you do a refresh and then you had to expand the tree to find where
you were. I much prefer your new behaviour.

One peculiarity. When you first open a database it expands the database tab
showing all schemas/catalogs and selects the datbase node for display
(exactly what it should do) but if you then Refresh it, it expands all the
schema/catalog tabs but doesn't remember the node that was selected. In fact
refresh _always_ expands the schema/catalog tabs even if they weren't
expanded.

It would be nice if you could take the code you have written
saving/restoring the expansion state of a tree and abstract it out into a
separate class (like SavedExpansionState). A component that you could use to
save and restore the state of any JTree would be very convienient.

Nice work!

Col

> <snip>
> 2>
> If you do a refresh on a tree then the the cursor doesn't go to normal
> anymore (stays in wait)
> </snip>
> 
> This works for me. Is it any refresh (I.E. Does F5, menu option or clicking
> the toolbar button make a difference)? For F5 does it make a difference if
> your cursor is over the object tree or elsewhere?

If i did a refresh pressing the button then the cursor did stay wrong
i added a _cursor.restore() after i do the refresh now just to be sure.

 
> <snip>
> 3>
> The tree will be expanded with all the children are loaded before (so not
> really yhe expanded
> state but the complete state of all the nodes that are onces expanded.
> To go around this is a bit difficult at them moment.
> </snip>
> 
> Known bug. I'll be fixing this in the rewrite. As well as actually creating
> the previously expanded nodes its supposed to display them.

I already did a rewrite :-)
That's why i added this as an bug that is introduced in my code.

the problem with the previous approacher (TreeState object or something)
was that this only stored treepaths and then say to the tree expand
But the problem if you do a reload of the tree then that tree path isn't there
anymore because it is not loaded yet.
I fixed that because the refresh is now really done by the model and its nodes
and not just a call on root.reload() (look at BaseNode)

But i don't use the methods: getExpandedNodes(TreePath) or isExpanded()
anymore so maybe i should first try to get those and the do the current refresh
and then expand those. (but not really those? because that real objects treepath
are removed and replaced with something else.

johan

Hi Johan,

<snip>
2>
If you do a refresh on a tree then the the cursor doesn't go to normal
anymore (stays in wait)
</snip>

This works for me. Is it any refresh (I.E. Does F5, menu option or clicking
the toolbar button make a difference)? For F5 does it make a difference if
your cursor is over the object tree or elsewhere?

<snip>
3>
The tree will be expanded with all the children are loaded before (so not
really yhe expanded
state but the complete state of all the nodes that are onces expanded.
To go around this is a bit difficult at them moment.
</snip>

Known bug. I'll be fixing this in the rewrite. As well as actually creating
the previously expanded nodes its supposed to display them.

Col

Hi,

i encountered a couple of things that should be fixed in the latest cvs release.

1> 
if varchar > 50 then i set the lenght and append "..."
this should not be done anymore in the ResultSetDataSet but thould be done
with a Renderer in a IDataSetViewer implementation
So that when you double click on it you will get all the text in the popup textarea

2>
If you do a refresh on a tree then the the cursor doesn't go to normal anymore (stays in wait)

3>
The tree will be expanded with all the children are loaded before (so not really yhe expanded
state but the complete state of all the nodes that are onces expanded.
To go around this is a bit difficult at them moment.


johan

please get the latest version from cvs and look at the new IDataSetViewer class
I think that class should get a setCellRenderer(int column (or type??), IRenderer renderer)

then look at the implementations of IDataSetViewer to let them work with that renderer
(table should use it inside the CellRenderer of its own)

johan


----- Original Message ----- 
From: "Brad Lyon" <bra...@nt...>
To: <squ...@li...>
Sent: Sunday, March 10, 2002 6:35 PM
Subject: Re: [Squirrel-sql-develop] "Date" field display options?


> So, I guess I'll do nothing here?  Fine with me, of course.  Let me know 
> what you want me to do - can't wait to test it.
> 
> 
> At 05:39 PM 3/10/2002 +0100, you wrote:
> >Almost finished with that.
> >I will check it in this evening
> >I am just adding 2 more things to the changes
> >
> >But about that rendering problem:
> >
> >You can't do that anymore at that place!
> >For example the IDataSetViewer (a combination of IDataSetViewerDestination
> >and DataSetViewer class)
> >is now incontrol of how it will render it!!
> >
> >A IDataSetViewer implementation is for example the JTable view or the
> >JTextArea view
> >And the JTable view doesn't do toString() on the object when inserting them
> >in the model
> >like before. Because is need Date's and Numbers in the output and not a
> >String representation
> >of that, this is because i implemented Sorting on column now.
> >So i need real numbers or date's in them to get the sorting right.
> >
> >So if you want to set some dateformatter then we need that for the different
> >implementations of IDataSetViewer.
> >For exasmple the JTable implementation has to do that through the normal
> >CellRenderers
> >So we could make a special Interface which definces how a renderer works
> >(with
> >giving it a object and getting back a string. Then the
> >DataSetViewerJTablePanel class
> >should be able to get that interface for a specific column and it access
> >that through
> >its CellRenderer. This is not to much work.
> >
> >So i think:
> >
> >IDataSetViewer has to get a setRenderer(int iColumn, IRenderer) method
> >this must be set right after the creation of it. How it is used depends on
> >the implementation.
> >
> >The current changes:
> >
> >- TableSorting by pressing column headers, need small icons
> >(ascending/descending)
> >- Icon shown for drivers, instead of colors, that are loaded or not (Need
> >better Icons!!)
> >- If only one cell selected in table when pressing copy then no header will
> >be appended.
> >- longvarchars will also be displayed now instead of <null>
> >- If selected String are longer then 50 chars then 45 chars + "......"  wil
> >be displayed.
> >- Those strings (and everything else) can also be displayed in a TextArea if
> >   you double click on it, so that you can display the whole value of a cell
> >
> >2 i am busy on right now:
> >
> >- Drop table menu item on the ObjectTree (i personally really need this :-)
> >- Refresh table menu item option (so that you can refresh the selected item
> >instead of the complete tree)
> >
> >johan
> >
> >P.S. Why doesn't this list set the reply adress? (If i press reply then i
> >get the senders adress not the
> >         list adress filled in. The list should set this to itself.
> >
> >

So, I guess I'll do nothing here?  Fine with me, of course.  Let me know 
what you want me to do - can't wait to test it.


At 05:39 PM 3/10/2002 +0100, you wrote:
>Almost finished with that.
>I will check it in this evening
>I am just adding 2 more things to the changes
>
>But about that rendering problem:
>
>You can't do that anymore at that place!
>For example the IDataSetViewer (a combination of IDataSetViewerDestination
>and DataSetViewer class)
>is now incontrol of how it will render it!!
>
>A IDataSetViewer implementation is for example the JTable view or the
>JTextArea view
>And the JTable view doesn't do toString() on the object when inserting them
>in the model
>like before. Because is need Date's and Numbers in the output and not a
>String representation
>of that, this is because i implemented Sorting on column now.
>So i need real numbers or date's in them to get the sorting right.
>
>So if you want to set some dateformatter then we need that for the different
>implementations of IDataSetViewer.
>For exasmple the JTable implementation has to do that through the normal
>CellRenderers
>So we could make a special Interface which definces how a renderer works
>(with
>giving it a object and getting back a string. Then the
>DataSetViewerJTablePanel class
>should be able to get that interface for a specific column and it access
>that through
>its CellRenderer. This is not to much work.
>
>So i think:
>
>IDataSetViewer has to get a setRenderer(int iColumn, IRenderer) method
>this must be set right after the creation of it. How it is used depends on
>the implementation.
>
>The current changes:
>
>- TableSorting by pressing column headers, need small icons
>(ascending/descending)
>- Icon shown for drivers, instead of colors, that are loaded or not (Need
>better Icons!!)
>- If only one cell selected in table when pressing copy then no header will
>be appended.
>- longvarchars will also be displayed now instead of <null>
>- If selected String are longer then 50 chars then 45 chars + "......"  wil
>be displayed.
>- Those strings (and everything else) can also be displayed in a TextArea if
>   you double click on it, so that you can display the whole value of a cell
>
>2 i am busy on right now:
>
>- Drop table menu item on the ObjectTree (i personally really need this :-)
>- Refresh table menu item option (so that you can refresh the selected item
>instead of the complete tree)
>
>johan
>
>P.S. Why doesn't this list set the reply adress? (If i press reply then i
>get the senders adress not the
>         list adress filled in. The list should set this to itself.
>
>
>
>
>Johan
>
>
> > Hi Brad,
> >
> > I knew there was something I forgot about this. Johan Compagner is
>currently
> > heavily refactoring this code so you might want to talk to him about these
> > changes. One of the things he's looking at doing is allowing "renderers"
>for
> > columns.
> >
> > Col
> >
> > -----Original Message-----
> > From: squ...@li...
> > [mailto:squ...@li...]On Behalf Of
> > Colin Bell
> > Sent: Friday, 22 February 2002 10:59 AM
> > To: 'BradLyon'; squ...@li...
> > Subject: RE: [Squirrel-sql-develop] "Date" field display options?
> >
> >
> > Hi Brad,
> >
> >
>net.sourceforge.squirrel_sql.fw.datasetviewer.ResultSetDataSet.setResultSet(
> > ..) is where the result set gets read. I'd suggest overloading this
>function
> > to take an additional parameter of type DataFormatter (or whatever you
>want
> > to call it).
> >
> > DataFormatter would be a new class that would contain the formatters for
> > dates, time, timestamps etc. Also nice would be formatting for the
>different
> > numerics but these could be added later.
> >
> > I think that this formatting should be able to be specified at a "per
> > session" basis so I think they should be specified on the SQL panel
> > net.sourceforge.squirrel_sql.client.session.properties.SQLPropertiesPanel.
> > This panel is used by both the New Sessions dialog and the Session
> > Properties dialog.
> >
> > You'd need to store the new settings in the propeties class
> > net.sourceforge.squirrel_sql.client.session.properties.SessionProperties
>and
> > its associated BeanInfo class.
> >
> > I think that should be it.
> >
> > Thanks
> > Col
> >
> > -----Original Message-----
> > From: BradLyon [mailto:bra...@nt...]
> > Sent: Wednesday, 20 February 2002 2:20
> > To: squ...@li...
> > Subject: RE: [Squirrel-sql-develop] "Date" field display options?
> >
> >
> > Colin:
> >
> > If you can point me to the relevant place (I want to be sure), I'll see if
> > I can poke at it.
> >
> >
> >
> > At 11:24 AM 2/19/02 +1100, you wrote:
> > >Hi Brad,
> > >
> > ><snip>
> > >I need to see the date columns shown with seconds, etc.  It's not
>happening
> > >with the version I have (several months old).  Are there more options for
> > >showing dates in the most recent version?
> > ></snip>
> > >
> > >Not yet but there should be. Whats needed (I think, feel free to
>disagree)
> > >is replacing the getString() method with an appropriate getXXX() function
> > >for date, time and timestamp and then using a DateFormat (or whatever its
> > >called) to format that object for display. Both the New Session
>Properties
> > >dialog and the Session Properties dialog should allow the user to specify
> > >the format they want to see date, time and timestamp columns in.
> > >
> > >If you've got the time to make the changes to the latest CVS source and
> > send
> > >me a diff I'd really appreciate it, otherwise I'll add it to my todo
>list.
> > >
> > >Thanks
> > >Col
> > >
> > >-----Original Message-----
> > >From: BradLyon [mailto:bra...@nt...]
> > >Sent: Sunday, 17 February 2002 1:52
> > >To: squ...@li...
> > >Subject: [Squirrel-sql-develop] "Date" field display options?
> > >
> > >
> > >I need to see the date columns shown with seconds, etc.  It's not
>happening
> > >with the version I have (several months old).  Are there more options for
> > >showing dates in the most recent version?
> > >
> > >Where in the code would I look to do this?  I poked around a little, and
>it
> > >looked like there was just a general toString called on object, but I
>might
> > >have been looking at the wrong place.
> > >
> > >_______________________________________________
> > >Squirrel-sql-develop mailing list
> > >Squ...@li...
> > >https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
> > >
> > >_______________________________________________
> > >Squirrel-sql-develop mailing list
> > >Squ...@li...
> > >https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
> >
> >
> > _______________________________________________
> > Squirrel-sql-develop mailing list
> > Squ...@li...
> > https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
> >
> > _______________________________________________
> > Squirrel-sql-develop mailing list
> > Squ...@li...
> > https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
> >
> >
> >
> > _______________________________________________
> > Squirrel-sql-develop mailing list
> > Squ...@li...
> > https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
> >
>
>
>
>_______________________________________________
>Squirrel-sql-develop mailing list
>Squ...@li...
>https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop

Bradford F. Lyon, Ph.D.
Center for Information Studies
University of Tennessee

Mailing Address:
Brad Lyon
1515 Randall Park
Knoxville, TN 37922

ORNL Office: 865-241-8195
Home Office: 865-671-8953 or 671-3952

email:  bra...@nt..., ly...@y1...