Almost finished with that.
I will check it in this evening
I am just adding 2 more things to the changes
But about that rendering problem:
You can't do that anymore at that place!
For example the IDataSetViewer (a combination of IDataSetViewerDestination
and DataSetViewer class)
is now incontrol of how it will render it!!
A IDataSetViewer implementation is for example the JTable view or the
JTextArea view
And the JTable view doesn't do toString() on the object when inserting them
in the model
like before. Because is need Date's and Numbers in the output and not a
String representation
of that, this is because i implemented Sorting on column now.
So i need real numbers or date's in them to get the sorting right.
So if you want to set some dateformatter then we need that for the different
implementations of IDataSetViewer.
For exasmple the JTable implementation has to do that through the normal
CellRenderers
So we could make a special Interface which definces how a renderer works
(with
giving it a object and getting back a string. Then the
DataSetViewerJTablePanel class
should be able to get that interface for a specific column and it access
that through
its CellRenderer. This is not to much work.
So i think:
IDataSetViewer has to get a setRenderer(int iColumn, IRenderer) method
this must be set right after the creation of it. How it is used depends on
the implementation.
The current changes:
- TableSorting by pressing column headers, need small icons
(ascending/descending)
- Icon shown for drivers, instead of colors, that are loaded or not (Need
better Icons!!)
- If only one cell selected in table when pressing copy then no header will
be appended.
- longvarchars will also be displayed now instead of <null>
- If selected String are longer then 50 chars then 45 chars + "......" wil
be displayed.
- Those strings (and everything else) can also be displayed in a TextArea if
you double click on it, so that you can display the whole value of a cell
2 i am busy on right now:
- Drop table menu item on the ObjectTree (i personally really need this :-)
- Refresh table menu item option (so that you can refresh the selected item
instead of the complete tree)
johan
P.S. Why doesn't this list set the reply adress? (If i press reply then i
get the senders adress not the
list adress filled in. The list should set this to itself.
Johan
> Hi Brad,
>
> I knew there was something I forgot about this. Johan Compagner is
currently
> heavily refactoring this code so you might want to talk to him about these
> changes. One of the things he's looking at doing is allowing "renderers"
for
> columns.
>
> Col
>
> -----Original Message-----
> From: squ...@li...
> [mailto:squ...@li...]On Behalf Of
> Colin Bell
> Sent: Friday, 22 February 2002 10:59 AM
> To: 'BradLyon'; squ...@li...
> Subject: RE: [Squirrel-sql-develop] "Date" field display options?
>
>
> Hi Brad,
>
>
net.sourceforge.squirrel_sql.fw.datasetviewer.ResultSetDataSet.setResultSet(
> ..) is where the result set gets read. I'd suggest overloading this
function
> to take an additional parameter of type DataFormatter (or whatever you
want
> to call it).
>
> DataFormatter would be a new class that would contain the formatters for
> dates, time, timestamps etc. Also nice would be formatting for the
different
> numerics but these could be added later.
>
> I think that this formatting should be able to be specified at a "per
> session" basis so I think they should be specified on the SQL panel
> net.sourceforge.squirrel_sql.client.session.properties.SQLPropertiesPanel.
> This panel is used by both the New Sessions dialog and the Session
> Properties dialog.
>
> You'd need to store the new settings in the propeties class
> net.sourceforge.squirrel_sql.client.session.properties.SessionProperties
and
> its associated BeanInfo class.
>
> I think that should be it.
>
> Thanks
> Col
>
> -----Original Message-----
> From: BradLyon [mailto:bra...@nt...]
> Sent: Wednesday, 20 February 2002 2:20
> To: squ...@li...
> Subject: RE: [Squirrel-sql-develop] "Date" field display options?
>
>
> Colin:
>
> If you can point me to the relevant place (I want to be sure), I'll see if
> I can poke at it.
>
>
>
> At 11:24 AM 2/19/02 +1100, you wrote:
> >Hi Brad,
> >
> ><snip>
> >I need to see the date columns shown with seconds, etc. It's not
happening
> >with the version I have (several months old). Are there more options for
> >showing dates in the most recent version?
> ></snip>
> >
> >Not yet but there should be. Whats needed (I think, feel free to
disagree)
> >is replacing the getString() method with an appropriate getXXX() function
> >for date, time and timestamp and then using a DateFormat (or whatever its
> >called) to format that object for display. Both the New Session
Properties
> >dialog and the Session Properties dialog should allow the user to specify
> >the format they want to see date, time and timestamp columns in.
> >
> >If you've got the time to make the changes to the latest CVS source and
> send
> >me a diff I'd really appreciate it, otherwise I'll add it to my todo
list.
> >
> >Thanks
> >Col
> >
> >-----Original Message-----
> >From: BradLyon [mailto:bra...@nt...]
> >Sent: Sunday, 17 February 2002 1:52
> >To: squ...@li...
> >Subject: [Squirrel-sql-develop] "Date" field display options?
> >
> >
> >I need to see the date columns shown with seconds, etc. It's not
happening
> >with the version I have (several months old). Are there more options for
> >showing dates in the most recent version?
> >
> >Where in the code would I look to do this? I poked around a little, and
it
> >looked like there was just a general toString called on object, but I
might
> >have been looking at the wrong place.
> >
> >_______________________________________________
> >Squirrel-sql-develop mailing list
> >Squ...@li...
> >https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
> >
> >_______________________________________________
> >Squirrel-sql-develop mailing list
> >Squ...@li...
> >https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
>
>
> _______________________________________________
> Squirrel-sql-develop mailing list
> Squ...@li...
> https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
>
> _______________________________________________
> Squirrel-sql-develop mailing list
> Squ...@li...
> https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
>
>
>
> _______________________________________________
> Squirrel-sql-develop mailing list
> Squ...@li...
> https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
>
|